Added dev container #385
Merged
Added dev container #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
LGTM, thanks! |
wslaghekke
pushed a commit
to recognizegroup/imaginary
that referenced
this pull request
Feb 1, 2023
* Fixed Timeout in readme, 30 ~> 60 (h2non#340) * Fix invalid parameters "-path-prefix" (h2non#344) * fix: small errors in docs (h2non#346) * fix: use proper formatter for usage template (h2non#347) Co-authored-by: Mads Moeller <[email protected]> * Add Cloud Run Button (h2non#362) * Delete app.json * Update README.md * Update README.md * updated docker builder OS to go version 1.17 (h2non#371) * fix(readme): remove gocard obsolete badge * feat(readme): update placeholder description * fix(readme): update fly deploy tutorial * fix(docs): allowed-origins examples h2non#333 * memory leak issue fixed with jemalloc (h2non#381) * exposed palette from GET endpoints (h2non#380) * Updated Dockerfile (h2non#384) 1. Changed base image to bullseye 2. The updated base image contains an updated version of libjemalloc too, so building from source is no longer necessary 3. Updated libvips version too * Added dev container (h2non#385) * Added dev container * Removed irrelevant lines * allow speed from get (h2non#383) * allow speed from get * updating the version to use effor param in libvips * Return with and heigh of the generated images (h2non#382) * Return with and heigh of the generated images Use case: When using the fit image transformation, it is helpful to know the size of the resulting image without having to either read the image locally or do another request to the info endpoint. Used in: nextcloud/server#24166 Signed-off-by: Carl Schwan <[email protected]> * Make mimetype support always return true * Add command line option to enable this feature Signed-off-by: Carl Schwan <[email protected]> * refactor: remove deprecated X- prefix in response headers Co-authored-by: Tom <[email protected]> * Decompression exploit check (h2non#404) * Bump bimg version to 1.1.7 * Add decompression bomb exploit check * Update README with new flag * Fix tests * Fix typos (h2non#405) Found via `codespell -S .git`. --------- Co-authored-by: Julian <[email protected]> Co-authored-by: liuxu <[email protected]> Co-authored-by: 0xflotus <[email protected]> Co-authored-by: Mads Moeller <[email protected]> Co-authored-by: Mads Moeller <[email protected]> Co-authored-by: James Ward <[email protected]> Co-authored-by: Angelo Girardi <[email protected]> Co-authored-by: Tom <[email protected]> Co-authored-by: Vaibhav Sharma <[email protected]> Co-authored-by: Alessandro (Ale) Segala <[email protected]> Co-authored-by: Vaibhav Sharma <[email protected]> Co-authored-by: Carl Schwan <[email protected]> Co-authored-by: SeaaaaaSharp <[email protected]> Co-authored-by: Kian-Meng Ang <[email protected]>
suntong
pushed a commit
to suntong/imaginary
that referenced
this pull request
Nov 28, 2023
* Added dev container * Removed irrelevant lines
gkmw
pushed a commit
to gkmw/imaginary
that referenced
this pull request
Jun 19, 2024
* Added dev container * Removed irrelevant lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Dev Container which can be used to work on the codebase more easily, through VS Code (via the Remote-Containers extension) or GitHub Codespaces.
Because imaginary needs some libraries installed, setting them up–and having the right versions–on a development machine can be a pain. Using a dev container removes the problem and allows working on imaginary quickly and without messing up with the host.
The dev container is based on the official containers for Go 1.17 and it includes the libraries that imaginary needs as per the Dockerfile (both dev and runtime). Note that this used Debian Bullseye as base, so see also #384.