Skip to content

Conversation

@aurexav
Copy link
Member

@aurexav aurexav commented Jun 4, 2025

Summary

  • call hexify_prefixed_upper in ser_hexify_prefixed_upper
  • update serde test expectations for uppercase hex

Testing

  • cargo test --quiet (fails: could not download Rust toolchain)

https://chatgpt.com/codex/tasks/task_e_683ff08b415c83269ebb8c3b6320a53d

Copilot AI review requested due to automatic review settings June 4, 2025 07:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates serialization behavior to use an uppercase hexadecimal output and aligns the corresponding test expectations.

  • Changed serializer to call hexify_prefixed_upper.
  • Updated JSON test expectations to reflect uppercase serialization.
Comments suppressed due to low confidence (2)

src/serde.rs:405

  • [nitpick] Review the updated test expectations to ensure all cases where uppercase output is required are covered and reflect the behavior of hexify_prefixed_upper.
r#"{"_0":"34","_1":"208","_2":"0x4f5da2","_3":"0x4F5DA2","_4":"4f5da2","_5":"4F5DA2","_6":"0x4c6f7665204a616e6520466f7265766572","_7":"0x4C6F7665204A616E6520466F7265766572","_8":"Love Jane Forever"}"#

src/serde.rs:157

  • Ensure that the hexify_prefixed_upper function consistently returns uppercase values as expected, and consider adding unit tests to cover edge cases if not already present.
serializer.serialize_str(&value.hexify_prefixed_upper())

@aurexav aurexav changed the title Fix uppercase serialization Release v9.2.2 Jun 4, 2025
@aurexav aurexav added Dep Dependency R Release and removed codex labels Jun 4, 2025
Signed-off-by: Xavier Lau <[email protected]>
@aurexav aurexav force-pushed the codex/find-and-fix-a-bug branch from c140383 to 82b97d7 Compare June 4, 2025 12:03
@aurexav aurexav enabled auto-merge June 4, 2025 12:03
@aurexav aurexav disabled auto-merge June 4, 2025 12:59
@aurexav aurexav merged commit 740e991 into main Jun 4, 2025
6 checks passed
@aurexav aurexav deleted the codex/find-and-fix-a-bug branch June 4, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dep Dependency R Release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants