fix/remove gecko from captureRightClick
#27
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer version of Firefox behaves more like Chrome, where right-click does not trigger a
mouseupevent onwindow. This causes the editor to break since the regular events are always prevented and never restored.CodeMirror/src/input/TextareaInput.js
Lines 354 to 363 in 2b27904
In this PR, I've removed gecko from the
captureRightClickcondition check, verified to work on Firefox versions newer than 124.0.1 (2024/03/22, the oldest version I am able to rollback to).