Skip to content

Conversation

@stanley2058
Copy link

Newer version of Firefox behaves more like Chrome, where right-click does not trigger a mouseup event on window. This causes the editor to break since the regular events are always prevented and never restored.

if (captureRightClick) {
e_stop(e)
let mouseup = () => {
off(window, "mouseup", mouseup)
setTimeout(rehide, 20)
}
on(window, "mouseup", mouseup)
} else {
setTimeout(rehide, 50)
}

In this PR, I've removed gecko from the captureRightClick condition check, verified to work on Firefox versions newer than 124.0.1 (2024/03/22, the oldest version I am able to rollback to).

@stanley2058 stanley2058 requested review from Yukaii and jackycute April 8, 2025 04:42
Copy link
Member

@jackycute jackycute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me.

@Yukaii Yukaii merged commit 7454ba3 into hackmdio:master Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants