refactor: Remove deprecated export inter-dependency feature

[kingston]

Summary by CodeRabbit

• Dependency Updates

  • Patched dependencies for @halfdomelabs/fastify-generators, @halfdomelabs/react-generators, and @halfdomelabs/sync

• Refactoring

  • Removed deprecated export dependencies across multiple packages
  • Simplified dependency management and build process configurations
  • Removed export inter-dependency handling in sorting logic

• Chores

  • Cleaned up provider-related interfaces and removed unused methods

[changeset-bot]

🦋 Changeset detected

Latest commit: 2783f81

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages

Name	Type
@halfdomelabs/fastify-generators	Patch
@halfdomelabs/react-generators	Patch
@halfdomelabs/sync	Patch
@halfdomelabs/cli	Patch
@halfdomelabs/project-builder-common	Patch
@halfdomelabs/project-builder-server	Patch
@halfdomelabs/project-builder-test	Patch
@halfdomelabs/baseplate-plugin-storage	Patch
@halfdomelabs/core-generators	Patch
@halfdomelabs/project-builder-lib	Patch
@halfdomelabs/project-builder-cli	Patch
@halfdomelabs/project-builder-web	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[linear]

ENG-530 Remove provider interdependencies

dependsOn was replaced by creating multiple tasks - we should remove that

[coderabbitai]

Walkthrough

The pull request introduces a series of changes across multiple packages, focusing on removing deprecated export dependencies and simplifying dependency management. The modifications primarily affect the @halfdomelabs/fastify-generators, @halfdomelabs/react-generators, and @halfdomelabs/sync packages. The changes involve removing .modifiedInBuild() method calls from dependency declarations and eliminating complex export interdependency logic, streamlining the provider and dependency handling mechanisms.

Changes

File	Change Summary
.changeset/twelve-turkeys-dream.md	Patch for dependencies: @halfdomelabs/fastify-generators, @halfdomelabs/react-generators, and @halfdomelabs/sync
packages/fastify-generators/src/generators/*/index.ts	Removed .modifiedInBuild() from serviceFile and prismaSchemaProvider dependency declarations
packages/react-generators/src/generators/*/index.ts	Removed .modifiedInBuild() from reactApolloSetup and reactRoutes dependency declarations
packages/sync/src/core/engine/dependency-sort.ts	Removed normalizeExportMap and getExportInterdependencies functions
packages/sync/src/core/engine/dependency-sort.unit.test.ts	Removed test cases for export inter-dependencies
packages/sync/src/core/provider.ts	Removed modifiedInBuild properties, ProviderExportOptions interface, and dependsOn method

Sequence Diagram

sequenceDiagram
    participant Provider as Provider
    participant Generator as Generator
    participant DependencyEngine as Dependency Engine

    Provider->>Generator: Define Dependencies
    Generator->>DependencyEngine: Register Dependencies
    DependencyEngine->>DependencyEngine: Sort Dependencies
    DependencyEngine-->>Generator: Return Sorted Dependencies

Loading

This sequence diagram illustrates the simplified dependency management process after the changes, showing how providers define dependencies, which are then sorted by the dependency engine without the previous complex interdependency logic.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Lite

📥 Commits

Reviewing files that changed from the base of the PR and between a09b91f and 2783f81.

📒 Files selected for processing (9)

• .changeset/twelve-turkeys-dream.md (1 hunks)
• packages/fastify-generators/src/generators/prisma/prisma-crud-create/index.ts (1 hunks)
• packages/fastify-generators/src/generators/prisma/prisma-crud-update/index.ts (1 hunks)
• packages/fastify-generators/src/generators/prisma/prisma-model/index.ts (1 hunks)
• packages/react-generators/src/generators/auth/auth-apollo/index.ts (1 hunks)
• packages/react-generators/src/generators/core/react-routes/index.ts (1 hunks)
• packages/sync/src/core/engine/dependency-sort.ts (1 hunks)
• packages/sync/src/core/engine/dependency-sort.unit.test.ts (0 hunks)
• packages/sync/src/core/provider.ts (1 hunks)

💤 Files with no reviewable changes (1)

• packages/sync/src/core/engine/dependency-sort.unit.test.ts

✅ Files skipped from review due to trivial changes (1)

• .changeset/twelve-turkeys-dream.md

🔇 Additional comments (8)

packages/sync/src/core/engine/dependency-sort.ts (2)

57-57: Confirm the new dependency resolution covers all use cases.

By returning the sorted steps directly without filtering out interdependent nodes, the final list may include run steps that were previously excluded under the old approach. Verify that no necessary constraints or additional filtering were unintentionally removed.

If further tests exist for advanced dependency scenarios, run them to confirm that the new logic still behaves correctly. Otherwise, creating tests that capture these scenarios is advisable.

---

51-52: Straightforward approach after removing interdependency logic.

Replacing the complex export/interdependency logic with a direct flattening of entries into fullSteps and using dependencyGraph as fullEdges greatly simplifies the sorting process. This is consistent with the PR objective to remove deprecated export inter-dependency functionality. However, ensure no legacy references to the old, removed methods or data structures remain in the codebase.

Here is a script you can run to validate the absence of references to the removed methods:

✅ Verification successful

Verification successful: No legacy export interdependency references found

The codebase is clean of any references to the removed export interdependency functionality. The remaining dependency-related code serves different purposes (task dependencies, provider dependencies) and is part of the core functionality.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Searching for references to the removed functions "normalizeExportMap" and "getExportInterdependencies"
rg "normalizeExportMap|getExportInterdependencies"

Length of output: 52

---

Script:

#!/bin/bash
# Broader search for export and interdependency related terms
rg -i "export.*interdepend|export.*depend" -g '!*.{json,md}'

# Search for any function declarations related to exports
ast-grep --pattern 'function $FNAME($_) { $$$ }' | rg -i 'export'

# Check specifically in test files
rg -i "export.*depend|normalizeExport|getExport" -g "*.test.*"

Length of output: 3827

packages/fastify-generators/src/generators/prisma/prisma-model/index.ts (1)

77-77: Consistent removal of .modifiedInBuild() usage.

Removing the .modifiedInBuild() method call from this dependency is aligned with the PR’s objective to clean up deprecated features and simplify dependency handling. Please ensure any references to .modifiedInBuild() in related files are also removed.

packages/sync/src/core/provider.ts (1)

58-58: Ensure no references remain to the removed export properties.

The removal of the modifiedInBuild property and the old export options in this interface aligns with the deprecation plan. Verify that no downstream or upstream code relies on the removed properties.

To confirm, please run the following script to look for references of modifiedInBuild, ProviderExportOptions, and dependsOn across the codebase:

✅ Verification successful

No references remain to the removed export properties

The deprecated properties (modifiedInBuild, ProviderExportOptions, and related interface properties) have been successfully removed from the codebase. The only occurrences of "dependsOn" are in build configuration files (nx.json, package.json) and are unrelated to the interface changes.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Searching for any leftover references to deprecated properties & methods
rg -A 4 "modifiedInBuild|ProviderExportOptions|dependsOn"

Length of output: 2143

---

Script:

#!/bin/bash
# Search for TypeScript interface/type references
ast-grep --pattern 'interface $_ {
  modifiedInBuild?: $_
}'

# Search for direct property access
ast-grep --pattern '$_.modifiedInBuild'

# Search for interface usage
ast-grep --pattern 'type $_ = ProviderExportOptions'
ast-grep --pattern 'implements ProviderExportOptions'
ast-grep --pattern ': ProviderExportOptions'

Length of output: 262

---

Script:

#!/bin/bash
# Search specifically in TypeScript files for any remaining references
rg -t typescript "modifiedInBuild" 
rg -t typescript "ProviderExportOptions" 
rg -t typescript "interface.*\{[^}]*dependsOn[^}]*\}"

Length of output: 236

---

Script:

#!/bin/bash
# Search in .ts and .tsx files with context
rg -g "*.{ts,tsx}" -A 2 "modifiedInBuild"
rg -g "*.{ts,tsx}" -A 2 "ProviderExportOptions"
rg -g "*.{ts,tsx}" "interface.*\{[^}]*dependsOn[^}]*\}"

Length of output: 147

packages/react-generators/src/generators/auth/auth-apollo/index.ts (1)

24-24: Removal of .modifiedInBuild() from reactApolloSetup dependency.

This simplification helps maintain a cleaner dependency structure. The refactor is consistent with the removal of deprecated features across the codebase.

packages/react-generators/src/generators/core/react-routes/index.ts (1)

31-31: PR objective alignment – removing .modifiedInBuild().

This change consistently continues the removal of deprecated configuration methods. It's good to see consistent usage of minimal dependency syntax.

packages/fastify-generators/src/generators/prisma/prisma-crud-create/index.ts (1)

133-133: Removal of .modifiedInBuild() is consistent with the deprecation plan.

This line correctly removes the deprecated .modifiedInBuild() call. Ensure that no further logic in your codebase depends on that method’s side effects, and confirm that all related references to .modifiedInBuild() have been removed throughout the repository.

Run the following script to confirm no references remain:

✅ Verification successful

Verified: .modifiedInBuild() has been completely removed from the codebase

The removal is complete and consistent. No remaining references to modifiedInBuild() were found in the codebase, confirming that the deprecation plan has been successfully implemented.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Searching for any remaining occurrences of .modifiedInBuild() across the repo
rg "\.modifiedInBuild\("

Length of output: 26

---

Script:

#!/bin/bash
# Try broader text-based search patterns
echo "=== Searching for any occurrence of 'modifiedInBuild' ==="
rg "modifiedInBuild"

echo -e "\n=== Searching for method calls using AST pattern ==="
ast-grep --pattern 'modifiedInBuild($_)'

Length of output: 315

packages/fastify-generators/src/generators/prisma/prisma-crud-update/index.ts (1)

153-153: Dependency update aligns with the streamlined approach.

By dropping .modifiedInBuild(), you eliminate a potential overhead from build-time modifications. Make sure your build process or code generation logic has no hidden reliance on .modifiedInBuild().

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.