-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Add delete confirmation modal for deleting model transformers #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add delete confirmation modal for deleting model transformers #421
Conversation
ENG-481 Delete confirmation modal for deleting Transformer(Model/Service)
We should add some kind of security to prevent accidental deletion of transformer. |
🦋 Changeset detectedLatest commit: 331d942 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughA new patch has been introduced for the Changes
Sequence DiagramsequenceDiagram
participant User
participant ServiceTransformersSection
participant ConfirmDialog
participant RemoveTransformer
User->>ServiceTransformersSection: Attempt to remove transformer
ServiceTransformersSection->>ConfirmDialog: requestConfirm()
ConfirmDialog->>User: Display confirmation dialog
User->>ConfirmDialog: Confirm deletion
ConfirmDialog->>RemoveTransformer: Execute removal
The sequence diagram illustrates the new workflow where a confirmation dialog is introduced between the user's removal action and the actual transformer deletion, providing an additional verification step. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
Note 🎁 Summarized by CodeRabbit FreeYour organization has reached its limit of developer seats under the Pro Plan. For new users, CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please add seats to your subscription by visiting https://app.coderabbit.ai/login.If you believe this is a mistake and have available seats, please assign one to the pull request author through the subscription management page using the link above. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
kingston
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary by CodeRabbit
New Features
Patch
@halfdomelabs/project-builder-webpackage with request model transformer delete confirmation functionality