fix: Fix crash when creating a new relation

[kingston]

Summary by CodeRabbit

• Bug Fixes
  • Resolved an issue causing a crash when creating a new relation.
• Style
  • Enhanced error message presentation so they span the full width for improved visibility.
• Refactor
  • Streamlined relation configuration defaults to ensure consistent behavior and reduce runtime issues.

[linear]

ENG-555 Fix crash when creating new relation

The relation modal dialog crashes when creating a new relation.

[changeset-bot]

🦋 Changeset detected

Latest commit: 7642858

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages

Name	Type
@halfdomelabs/ui-components	Patch
@halfdomelabs/project-builder-web	Patch
@halfdomelabs/project-builder-lib	Patch
@halfdomelabs/baseplate-plugin-storage	Patch
@halfdomelabs/project-builder-cli	Patch
@halfdomelabs/project-builder-test	Patch
@halfdomelabs/project-builder-common	Patch
@halfdomelabs/project-builder-server	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

Walkthrough

This pull request introduces two sets of patches. One update adjusts the error display style in the UI components package to render at full width, ensuring centered error messages. The other patch addresses a crash in the project builder web package that occurred when creating a new relation. In addition, the relation form has been made more robust by updating the function to return a fully populated configuration with default values and simplifying the event handling for field changes in the relation form component. No changes were made to public API declarations.

Changes

File(s)	Change Summary
.changeset/dry-beans-visit.md, packages/ui-components/.../ErrorDisplay.tsx	Updated error display component styling to full-width with improved class name formatting; no change to functionality or API.
.changeset/mean-years-jump.md, packages/project-builder-web/.../ModelRelationForm.tsx	Modified getRelationDefaultsFromModel to return a complete config (default values applied) and simplified the ComboboxField.Controller onChange handler to directly set the references, addressing a crash during new relation creation.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant MF as ModelRelationForm
    participant GF as getRelationDefaultsFromModel
    participant C as ComboboxField.Controller

    U->>MF: Open relation form
    MF->>GF: Request default relation config
    GF-->>MF: Return complete ModelRelationFieldConfig (with defaults)
    U->>C: Change references via combobox
    C->>MF: Trigger onChange event
    MF->>MF: Update state using setValue(references) directly

Loading

Tip

🌐 Web search-backed reviews and chat

• We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
• You can disable this feature by setting web_search: false in the knowledge_base settings.
• Please share any feedback in the Discord discussion.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Lite

📥 Commits

Reviewing files that changed from the base of the PR and between 52600ce and 7642858.

📒 Files selected for processing (4)

• .changeset/dry-beans-visit.md (1 hunks)
• .changeset/mean-years-jump.md (1 hunks)
• packages/project-builder-web/src/pages/data/models/edit/[id]/_components/fields/relations/ModelRelationForm.tsx (3 hunks)
• packages/ui-components/src/components/ErrorDisplay/ErrorDisplay.tsx (1 hunks)

✅ Files skipped from review due to trivial changes (2)

• .changeset/dry-beans-visit.md
• packages/ui-components/src/components/ErrorDisplay/ErrorDisplay.tsx

🔇 Additional comments (4)

packages/project-builder-web/src/pages/data/models/edit/[id]/_components/fields/relations/ModelRelationForm.tsx (3)

86-88: LGTM! Type safety improvement.

The return type change from Partial<ModelRelationFieldConfig> to ModelRelationFieldConfig ensures the function always returns a complete configuration object, preventing potential runtime errors.

---

142-144: LGTM! Robust default values.

The use of nullish coalescing operator ensures that the function always returns non-null values, preventing potential crashes from undefined values:

• name ?? '': Defaults to empty string if name is null/undefined
• foreignRelationName ?? '': Defaults to empty string if foreignRelationName is null/undefined
• references ?? []: Defaults to empty array if references is null/undefined

---

319-319: LGTM! Simplified value assignment.

The direct assignment of references is now safe due to the guaranteed non-null values from getRelationDefaultsFromModel.

.changeset/mean-years-jump.md (1)

1-6: LGTM! Clear and appropriate changeset.

The patch version bump and description accurately reflect the bug fix nature of the changes.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.