Skip to content

Conversation

@kingston
Copy link
Collaborator

@kingston kingston commented Mar 6, 2025

  • Also upgrade eslint dependencies

Summary by CodeRabbit

  • Chores
    • Upgraded key dependencies including vite to version 6.2.0 and vitest to version 3.0.7 for improved performance and reliability.
  • Refactor
    • Streamlined merging logic and simplified type definitions to enhance internal consistency.
  • Style
    • Adopted an enhanced linting rule to promote robust coding practices across the project.

- Also upgrade eslint dependencies
@linear
Copy link

linear bot commented Mar 6, 2025

@coderabbitai
Copy link

coderabbitai bot commented Mar 6, 2025

Walkthrough

The pull request introduces a new changeset file that documents dependency updates across several packages and tools. Several package files now reference newer versions or use catalog-based resolution for dependencies such as vite and vitest. Additionally, there are minor code adjustments: one file changes how arguments are spread into a merge function, and another simplifies a function’s type signature. The ESLint configuration is also updated with a new rule, and the workspace configuration has been altered to update and remove specific dependency entries.

Changes

File(s) Change Summary
.changeset/hungry-singers-unite.md
pnpm-workspace.yaml
Adds a changeset file documenting dependency patches and updates the workspace configuration by upgrading versions for packages like vite, vitest, @eslint/js, and eslint, as well as removing the entry for @types/eslint__js.
packages/core-generators/.../core-packages.ts
tests/simple/packages/backend/package.json
tests/simple/packages/web/package.json
packages/react-generators/.../react-packages.ts
packages/ui-components/package.json
plugins/baseplate-plugin-storage/package.json
Updates dependency versions: bumps vitest from 3.0.5 to 3.0.7 and changes the vite dependency from a fixed version (e.g. "6.0.11") to either a catalog reference or a newer version (6.2.0).
packages/tools/.../typescript.js
packages/tools/package.json
Introduces a new ESLint rule (@typescript-eslint/prefer-nullish-coalescing) with configuration options and updates dependency versions for @vitest/eslint-plugin, typescript-eslint, and @typescript-eslint/utils.
packages/core-generators/.../typescript/index.ts
packages/project-builder-web/.../GraphQLObjectTypeSection.tsx
Adjusts code behavior: changes the spread operator usage in a merge function to pass array elements individually, and simplifies the getUpdatedOrderedList function signature by removing the generic type parameter.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Lite

📥 Commits

Reviewing files that changed from the base of the PR and between bb787ce and c5d3461.

⛔ Files ignored due to path filters (1)
  • tests/simple/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (4)
  • tests/simple/packages/backend/baseplate/.clean/package.json (1 hunks)
  • tests/simple/packages/backend/package.json (1 hunks)
  • tests/simple/packages/web/baseplate/.clean/package.json (1 hunks)
  • tests/simple/packages/web/package.json (1 hunks)
🔇 Additional comments (4)
tests/simple/packages/backend/package.json (1)

82-82: Update vitest Dependency Version

The vitest version in devDependencies has been updated from 3.0.5 to 3.0.7 in accordance with the PR objectives. This change is consistent with the project's dependency upgrade efforts.

tests/simple/packages/backend/baseplate/.clean/package.json (1)

82-82: Ensure Consistent vitest Dependency Upgrade

The update of vitest to version 3.0.7 in the devDependencies aligns with similar changes across the workspace. Please confirm that tests and tooling remain compatible with the newly upgraded version.

tests/simple/packages/web/package.json (1)

76-76: Dependency Update: Vite upgraded to 6.2.0.
The "vite" dependency has been updated from an older version (presumably 6.0.11) to 6.2.0 as expected per the PR objectives. This change is straightforward and aligns with the coordinated upgrade effort across the project.

tests/simple/packages/web/baseplate/.clean/package.json (1)

76-76: Dependency Update: Vite upgraded to 6.2.0.
The "vite" dependency in the devDependencies section is now set to 6.2.0, matching the update in other parts of the repository. This consistent version upgrade ensures uniformity across dependency management.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@socket-security
Copy link

socket-security bot commented Mar 6, 2025

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@changesets/[email protected] Transitive: environment, filesystem, network +5 331 kB changesets-release-bot
npm/@changesets/[email protected] environment, filesystem, shell Transitive: eval, unsafe +74 15.6 MB changesets-release-bot
npm/@cocalc/[email protected] None +2 67.1 kB wstein
npm/@dnd-kit/[email protected] environment +1 1.07 MB clauderic
npm/@dnd-kit/[email protected] environment 0 48.1 kB clauderic
npm/@dnd-kit/[email protected] environment 0 233 kB clauderic
npm/@dnd-kit/[email protected] environment 0 88.5 kB clauderic
npm/@eslint/[email protected]9.21.0 None 0 14.9 kB eslintbot, openjsfoundation
npm/@fastify/[email protected] Transitive: environment +5 244 kB eomm
npm/@headlessui/[email protected] environment 0 10.3 kB malfaitrobin
npm/@inquirer/[email protected] Transitive: environment, filesystem, shell +19 823 kB sboudrias
npm/@originjs/[email protected] filesystem +4 732 kB flyfishzy
npm/@prisma/[email protected] environment, eval, filesystem, network, shell +10 8.78 MB prismabot
npm/@radix-ui/[email protected] None +10 179 kB vladmoroz
npm/@radix-ui/[email protected] None +19 539 kB vladmoroz
npm/@radix-ui/[email protected] None +32 1.48 MB vladmoroz
npm/@radix-ui/[email protected] None +1 30.3 kB vladmoroz
npm/@radix-ui/[email protected] None +15 474 kB vladmoroz
npm/@radix-ui/[email protected] None +28 1.12 MB vladmoroz
npm/@radix-ui/[email protected] None +9 314 kB vladmoroz
npm/@radix-ui/[email protected] None +32 1.37 MB vladmoroz
npm/@radix-ui/[email protected] None +1 34 kB vladmoroz
npm/@radix-ui/[email protected] None +1 33.2 kB vladmoroz
npm/@radix-ui/[email protected] None +9 138 kB vladmoroz
npm/@radix-ui/[email protected] None +12 275 kB vladmoroz
npm/@radix-ui/[email protected] None +22 945 kB vladmoroz
npm/@storybook/[email protected] Transitive: filesystem +4 2.24 MB storybook-bot
npm/@storybook/[email protected] Transitive: environment +15 3.6 MB storybook-bot
npm/@storybook/[email protected] Transitive: environment +7 3.65 MB storybook-bot
npm/@storybook/[email protected] None +2 70.9 kB storybook-bot
npm/@storybook/[email protected] environment, eval +2 1.86 MB storybook-bot
npm/@storybook/[email protected] None 0 1.29 kB storybook-bot
npm/@storybook/[email protected] Transitive: environment, eval, filesystem, unsafe +59 13.7 MB storybook-bot
npm/@storybook/[email protected] environment +4 941 kB storybook-bot
npm/@storybook/[email protected] environment, eval +28 5.91 MB storybook-bot
npm/@storybook/[email protected] None 0 1.58 kB storybook-bot
npm/@testing-library/[email protected] environment Transitive: eval +18 3.63 MB testing-library-bot
npm/@testing-library/[email protected] None +9 2.42 MB testing-library-bot
npm/@testing-library/[email protected] None +1 586 kB brrianalexis, cmckinstry, dfcook, ...13 more
npm/@testing-library/[email protected] None 0 438 kB brrianalexis, cmckinstry, dfcook, ...13 more
npm/@trpc/[email protected] network 0 253 kB katt
npm/@trpc/[email protected] environment 0 713 kB katt
npm/@tsconfig/[email protected] None 0 2.36 kB typescript-deploys
npm/@tsconfig/[email protected] None 0 3.02 kB typescript-deploys
npm/@types/[email protected] None 0 91.7 kB types
npm/@types/[email protected] None 0 16.9 kB types
npm/@types/[email protected] None 0 2.77 kB types
npm/@types/[email protected] None 0 3.61 kB types
npm/@types/[email protected] None 0 3.27 kB types
npm/@types/[email protected] None +2 253 kB types
npm/@types/[email protected] None 0 4.56 kB types
npm/@types/[email protected] None 0 3.06 kB types
npm/@types/[email protected] None 0 3.2 kB types
npm/@types/[email protected]20.12.7 None 0 2.03 MB types
npm/@types/[email protected] None 0 49.8 kB types
npm/@types/[email protected] None 0 23.3 kB types
npm/@types/[email protected] None 0 5.02 kB types
npm/@typescript-eslint/[email protected], 7.18.08.26.0 Transitive: environment, filesystem +24 2.04 MB
npm/@vitest/[email protected] None 0 283 kB veritemm
npm/[email protected] network Transitive: environment, filesystem +8 2.48 MB jasonsaayman
npm/[email protected] None 0 43.7 kB sindresorhus
npm/[email protected]5.4.4 None 0 35.9 kB blakeembrey
npm/[email protected] Transitive: environment, filesystem +7 698 kB bmishkin
npm/[email protected] environment, filesystem +1 202 kB paulmillr
npm/[email protected] None +1 15.7 kB joebell93
npm/[email protected] None +21 657 kB paco
npm/[email protected] environment 0 186 kB abetomo
npm/[email protected] environment, filesystem, shell +5 1.9 MB gustavohenke
npm/[email protected] filesystem Transitive: environment, shell +23 3.38 MB bret
npm/[email protected] None 0 1.11 MB danburzo
npm/[email protected]16.4.5 None 0 79.1 kB motdotla
npm/[email protected] eval, filesystem Transitive: environment, shell +13 1.34 MB mde
npm/[email protected] None 0 2.56 MB toss-build-bot
npm/[email protected]3.7.0 Transitive: environment, filesystem, unsafe +19 910 kB jounqin
npm/[email protected] Transitive: environment, filesystem, unsafe +18 2.47 MB jounqin
npm/[email protected]6.10.2 Transitive: eval +62 9.36 MB ljharb
npm/[email protected] Transitive: environment +2 542 kB azat-io
npm/[email protected]5.1.0 None 0 169 kB react-bot
npm/[email protected]7.37.2 Transitive: environment, eval +67 5.28 MB ljharb
npm/[email protected] filesystem +1 186 kB yannbf
npm/[email protected] Transitive: environment, filesystem +16 932 kB francoismassart
npm/[email protected] Transitive: environment, filesystem, unsafe +38 5.9 MB sindresorhus
npm/[email protected]9.21.0 Transitive: eval, shell, unsafe +69 6.02 MB
npm/[email protected] None 0 272 kB nebrelbug
npm/[email protected] environment Transitive: filesystem, shell +14 506 kB ehmicky
npm/[email protected] None 0 159 kB mountain-jack
npm/[email protected] None 0 25.2 kB kibertoad
npm/[email protected] Transitive: filesystem +16 545 kB sindresorhus
npm/[email protected] environment 0 627 kB mweststrate
npm/[email protected] None 0 4.74 kB sindresorhus
npm/[email protected] None 0 90.4 kB patcher56
npm/[email protected]2.15.1 None +2 72.9 kB ljharb
npm/[email protected] None 0 4.44 MB catamphetamine
npm/[email protected] Transitive: environment, filesystem, network +25 7.77 MB domenic, joris-van-der-wel, sebmaster, ...3 more
npm/[email protected] environment, eval Transitive: filesystem, shell, unsafe +36 5.41 MB webpro
npm/[email protected] None +4 2.35 MB streamich
npm/[email protected] None 0 137 kB broofa
npm/[email protected] None 0 11 kB ai
npm/[email protected] None 0 110 kB bhousel
npm/[email protected] environment +7 81.7 kB sindresorhus
npm/[email protected]8.0.1 environment +6 80.1 kB sindresorhus
npm/[email protected] None 0 8.23 kB sindresorhus
npm/[email protected] None +1 12.1 kB sindresorhus
npm/[email protected] Transitive: filesystem +3 67.4 kB ryanzim
npm/[email protected] None +3 59.8 kB marceloucker
npm/[email protected]8.4.38 None +2 261 kB ai
npm/[email protected]2.5.6 None 0 5.55 kB matzkoh
npm/[email protected]0.6.9 None 0 2.67 MB thecrypticace
npm/[email protected]3.4.2 None 0 7.83 MB prettier-bot
npm/[email protected] None 0 391 kB omgovich
npm/[email protected] Transitive: environment +8 3.71 MB catamphetamine

🚮 Removed packages: npm/@apollo/[email protected], npm/@envelop/[email protected], npm/@envelop/[email protected], npm/@envelop/[email protected], npm/@fastify/[email protected], npm/@fastify/[email protected], npm/@graphql-codegen/[email protected], npm/@graphql-codegen/[email protected], npm/@graphql-codegen/[email protected], npm/@graphql-codegen/[email protected], npm/@parcel/[email protected], npm/@playwright/[email protected], npm/@pothos/[email protected], npm/@pothos/[email protected], npm/@pothos/[email protected], npm/@pothos/[email protected], npm/@pothos/[email protected], npm/@pothos/[email protected], npm/@prisma/[email protected], npm/@prisma/[email protected], npm/@sentry/[email protected], npm/@sentry/[email protected], npm/@sentry/[email protected], npm/@sentry/[email protected], npm/@sentry/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@changeset-bot
Copy link

changeset-bot bot commented Mar 6, 2025

🦋 Changeset detected

Latest commit: c5d3461

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@halfdomelabs/baseplate-plugin-storage Patch
@halfdomelabs/project-builder-web Patch
@halfdomelabs/fastify-generators Patch
@halfdomelabs/react-generators Patch
@halfdomelabs/core-generators Patch
@halfdomelabs/ui-components Patch
@halfdomelabs/project-builder-common Patch
@halfdomelabs/project-builder-cli Patch
@halfdomelabs/project-builder-test Patch
@halfdomelabs/project-builder-server Patch
@halfdomelabs/project-builder-lib Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kingston kingston merged commit ed229ab into main Mar 6, 2025
7 checks passed
@kingston kingston deleted the kingston/eng-565-upgrade-vite-to-620-and-vitest-to-307 branch March 6, 2025 06:21
This was referenced Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants