refactor: Remove activeDescendentId workaround now that CMDK has patched it

[kingston]

Summary by CodeRabbit

• Refactor
  • The combobox component has been streamlined by removing redundant active selection tracking. This simplification improves internal handling without altering visible behavior.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 95f1b9f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The pull request simplifies the Combobox component by removing the active descendant state management. The changes eliminate the activeDescendentId state, its updater, and the fixActiveDescendant function, as well as removing all references to this state in the context, props, and the aria-activedescendant attribute in the input element.

Changes

File(s)	Change Summary
packages/ui-components/src/components/Combobox/Combobox.tsx	Removed the activeDescendentId state and its setter; deleted the fixActiveDescendant function; eliminated the activeDescendentId property from the context interface and related props; and removed the aria-activedescendant attribute from the ComboboxInput component’s input element.

Sequence Diagram(s)

Previous Active Descendant Flow

sequenceDiagram
    participant Input as ComboboxInput
    participant Root as ComboboxRoot
    participant Context as ComboboxContext
    Input->>Root: User types input
    Root->>Context: Invoke fixActiveDescendant(newActiveValue)
    Context-->>Root: Update activeDescendentId
    Root->>Input: Render input with aria-activedescendant

Loading

Simplified Flow Without Active Descendant

sequenceDiagram
    participant Input as ComboboxInput
    participant Root as ComboboxRoot
    Input->>Root: User types input
    Root->>Input: Render input without aria-activedescendant

Loading

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Lite

📥 Commits

Reviewing files that changed from the base of the PR and between c5aa78e and 95f1b9f.

📒 Files selected for processing (1)

• packages/ui-components/src/components/Combobox/Combobox.tsx (0 hunks)

💤 Files with no reviewable changes (1)

• packages/ui-components/src/components/Combobox/Combobox.tsx

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.