Skip to content

Conversation

@kingston
Copy link
Collaborator

@kingston kingston commented Jun 21, 2025

Summary by CodeRabbit

  • Refactor

    • Updated naming conventions throughout the user interface and documentation, changing all references from "project path" to "output path" and from "projectScope" to "packageScope" for improved clarity.
    • Adjusted interface and method names, comments, and error messages to align with the new terminology.
    • No changes to application logic or workflows; only terminology and naming were updated.
  • Documentation

    • Updated comments and documentation to reflect the new "output path" terminology.
  • Bug Fixes

    • None.
  • New Features

    • None.

@vercel
Copy link

vercel bot commented Jun 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
baseplate-project-builder-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2025 4:17pm

@coderabbitai
Copy link

coderabbitai bot commented Jun 21, 2025

Note

Reviews paused

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Walkthrough

This change refactors naming conventions throughout the codebase, replacing "project paths" with "output paths" and "projectScope" with "packageScope" across multiple packages and files. Function and variable names, comments, and exported constants are updated to reflect this terminology shift. No functional logic or control flow is altered.

Changes

Files / Groups Change Summary
packages/core-generators/src/providers/scopes.ts Renamed exported constant projectScope to packageScope.
Files importing or using projectScope (multiple packages) Replaced all imports/usages of projectScope with packageScope in generators, providers, and exports.
Files referencing "project relative path" (multiple packages) Renamed all references, comments, and variable names from "project relative path" to "output relative path".
Path normalization utilities and usages (canonical-path.ts, normalize-module-specifier.ts, etc.) Renamed functions and parameters: normalizePathToProjectPathnormalizePathToOutputPath, similarly for others.
TypeScript generator and related interfaces Updated interface methods, comments, and logic to use output-relative path terminology.
Test and code snippet files Updated test cases and code snippets to use new function and variable names.
Error and utility classes Renamed constructor parameters and error messages from project-relative to output-relative path.
Comments/documentation in types and interfaces Updated comments to clarify output-relative path semantics.

Sequence Diagram(s)

sequenceDiagram
    participant Generator as Generator
    participant Provider as Provider
    participant Scope as packageScope
    participant PathUtil as OutputPathUtil

    Generator->>Provider: createConfigProviderTask({ configScope: packageScope })
    Generator->>Provider: provider.export(packageScope)
    Generator->>PathUtil: normalizePathToOutputPath(path)
    Note over Generator, Provider: All references to projectScope/projectPath replaced with packageScope/outputPath
Loading

Possibly related PRs

  • halfdomelabs/baseplate#473: Introduces a new "output provider" concept and modifies generators to use output providers, which is closely related to this PR's terminology and scope refactor.
  • halfdomelabs/baseplate#414: Implements the initial scoped export mechanism using projectScope; this PR builds upon and renames that mechanism to packageScope.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kingston
Copy link
Collaborator Author

@coderabbitai ignore

@changeset-bot
Copy link

changeset-bot bot commented Jun 21, 2025

🦋 Changeset detected

Latest commit: 66901a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
@baseplate-dev/project-builder-test Patch
@baseplate-dev/fastify-generators Patch
@baseplate-dev/react-generators Patch
@baseplate-dev/core-generators Patch
@baseplate-dev/plugin-storage Patch
@baseplate-dev/code-morph Patch
@baseplate-dev/plugin-auth Patch
@baseplate-dev/sync Patch
@baseplate-dev/project-builder-server Patch
@baseplate-dev/project-builder-common Patch
@baseplate-dev/project-builder-lib Patch
@baseplate-dev/project-builder-cli Patch
@baseplate-dev/project-builder-web Patch
@baseplate-dev/create-project Patch
@baseplate-dev/tools Patch
@baseplate-dev/ui-components Patch
@baseplate-dev/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (4)
packages/react-generators/src/generators/core/react-tailwind/react-tailwind.generator.ts (1)

6-6: LGTM! Refactoring from projectScope to packageScope is consistent.

The naming change aligns with the PR objective to clarify terminology. However, please fix the import ordering issue.

 import {
   createNodePackagesTask,
   eslintConfigProvider,
   extractPackageVersions,
-  prettierProvider,
   packageScope,
+  prettierProvider,
   renderTextTemplateGroupAction,
   tsCodeFragment,
 } from '@baseplate-dev/core-generators';

Also applies to: 56-56

packages/fastify-generators/src/generators/core/app-module/app-module.generator.ts (1)

7-7: LGTM! Consistent refactoring with proper conditional logic preserved.

The refactoring correctly updates the scope naming while maintaining the conditional logic for root vs non-root modules. However, please fix the import ordering issue.

 import {
   featureScope,
-  pathRootsProvider,
   packageScope,
+  pathRootsProvider,
   tsCodeFragment,
   TsCodeUtils,
   tsImportBuilder,
   typescriptFileProvider,
 } from '@baseplate-dev/core-generators';

Also applies to: 88-88, 91-91

packages/react-generators/src/generators/apollo/react-apollo/react-apollo.generator.ts (1)

13-13: Fix import ordering and approve the change.

The import correctly uses packageScope, but ESLint indicates it should be ordered before prettierProvider.

-  packageScope,
   prettierProvider,
+  packageScope,
packages/fastify-generators/src/generators/pothos/pothos/pothos.generator.ts (1)

8-8: Fix import order to satisfy ESLint.

The ESLint rule perfectionist/sort-named-imports expects packageScope to come before prettierProvider in the named imports.

import {
  createNodePackagesTask,
  extractPackageVersions,
  nodeProvider,
-  prettierProvider,
  packageScope,
+  prettierProvider,
  tsCodeFragment,
  TsCodeUtils,
  tsImportBuilder,
  tsUtilsImportsProvider,
  typescriptFileProvider,
} from '@baseplate-dev/core-generators';
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 748b3fe and 8b920c4.

⛔ Files ignored due to path filters (38)
  • packages/core-generators/src/generators/node/ts-utils/generated/ts-import-providers.ts is excluded by !**/generated/**
  • packages/fastify-generators/src/generators/auth/auth-context/generated/ts-import-providers.ts is excluded by !**/generated/**
  • packages/fastify-generators/src/generators/auth/auth-roles/generated/ts-import-providers.ts is excluded by !**/generated/**
  • packages/fastify-generators/src/generators/auth/password-hasher-service/generated/ts-import-providers.ts is excluded by !**/generated/**
  • packages/fastify-generators/src/generators/auth/placeholder-auth-service/generated/ts-import-providers.ts is excluded by !**/generated/**
  • packages/fastify-generators/src/generators/auth/user-session-types/generated/ts-import-providers.ts is excluded by !**/generated/**
  • packages/fastify-generators/src/generators/bull/bull-mq/generated/ts-import-providers.ts is excluded by !**/generated/**
  • packages/fastify-generators/src/generators/core/app-module-setup/generated/ts-import-providers.ts is excluded by !**/generated/**
  • packages/fastify-generators/src/generators/core/axios/generated/ts-import-providers.ts is excluded by !**/generated/**
  • packages/fastify-generators/src/generators/core/config-service/generated/ts-import-providers.ts is excluded by !**/generated/**
  • packages/fastify-generators/src/generators/core/error-handler-service/generated/ts-import-providers.ts is excluded by !**/generated/**
  • packages/fastify-generators/src/generators/core/fastify-redis/generated/ts-import-providers.ts is excluded by !**/generated/**
  • packages/fastify-generators/src/generators/core/fastify-sentry/generated/ts-import-providers.ts is excluded by !**/generated/**
  • packages/fastify-generators/src/generators/core/logger-service/generated/ts-import-providers.ts is excluded by !**/generated/**
  • packages/fastify-generators/src/generators/core/request-context/generated/ts-import-providers.ts is excluded by !**/generated/**
  • packages/fastify-generators/src/generators/core/request-service-context/generated/ts-import-providers.ts is excluded by !**/generated/**
  • packages/fastify-generators/src/generators/core/service-context/generated/ts-import-providers.ts is excluded by !**/generated/**
  • packages/fastify-generators/src/generators/pothos/pothos/generated/ts-import-providers.ts is excluded by !**/generated/**
  • packages/fastify-generators/src/generators/prisma/prisma-utils/generated/ts-import-providers.ts is excluded by !**/generated/**
  • packages/fastify-generators/src/generators/prisma/prisma/generated/ts-import-providers.ts is excluded by !**/generated/**
  • packages/fastify-generators/src/generators/stripe/fastify-stripe/generated/ts-import-providers.ts is excluded by !**/generated/**
  • packages/fastify-generators/src/generators/vitest/prisma-vitest/generated/ts-import-providers.ts is excluded by !**/generated/**
  • packages/react-generators/src/generators/admin/admin-components/generated/ts-import-providers.ts is excluded by !**/generated/**
  • packages/react-generators/src/generators/apollo/apollo-error/generated/ts-import-providers.ts is excluded by !**/generated/**
  • packages/react-generators/src/generators/apollo/react-apollo/generated/ts-import-providers.ts is excluded by !**/generated/**
  • packages/react-generators/src/generators/auth/placeholder-auth-hooks/generated/ts-import-providers.ts is excluded by !**/generated/**
  • packages/react-generators/src/generators/core/react-components/generated/ts-import-providers.ts is excluded by !**/generated/**
  • packages/react-generators/src/generators/core/react-config/generated/ts-import-providers.ts is excluded by !**/generated/**
  • packages/react-generators/src/generators/core/react-error/generated/ts-import-providers.ts is excluded by !**/generated/**
  • packages/react-generators/src/generators/core/react-logger/generated/ts-import-providers.ts is excluded by !**/generated/**
  • packages/react-generators/src/generators/core/react-sentry/generated/ts-import-providers.ts is excluded by !**/generated/**
  • packages/react-generators/src/generators/core/react-utils/generated/ts-import-providers.ts is excluded by !**/generated/**
  • plugins/plugin-auth/src/auth/generators/fastify/auth-module/generated/ts-import-providers.ts is excluded by !**/generated/**
  • plugins/plugin-auth/src/auth0/generators/fastify/auth0-module/generated/ts-import-providers.ts is excluded by !**/generated/**
  • plugins/plugin-auth/src/auth0/generators/react/auth0-components/generated/ts-import-providers.ts is excluded by !**/generated/**
  • plugins/plugin-auth/src/auth0/generators/react/auth0-hooks/generated/ts-import-providers.ts is excluded by !**/generated/**
  • plugins/plugin-storage/src/generators/fastify/storage-module/generated/ts-import-providers.ts is excluded by !**/generated/**
  • plugins/plugin-storage/src/generators/react/upload-components/generated/ts-import-providers.ts is excluded by !**/generated/**
📒 Files selected for processing (65)
  • .changeset/early-friends-punch.md (1 hunks)
  • .vscode/generator.json.code-snippets (3 hunks)
  • packages/code-morph/src/morphers/tests/build-tasks-as-object/converted/input.ts (4 hunks)
  • packages/code-morph/src/morphers/tests/build-tasks-as-object/converted/output.ts (4 hunks)
  • packages/code-morph/src/morphers/tests/build-tasks-as-object/simple/input.ts (2 hunks)
  • packages/code-morph/src/morphers/tests/build-tasks-as-object/simple/output.ts (2 hunks)
  • packages/code-morph/src/morphers/tests/deprecate-create-task-builder/simple/input.ts (2 hunks)
  • packages/code-morph/src/morphers/tests/deprecate-create-task-builder/simple/output.ts (2 hunks)
  • packages/code-morph/src/morphers/utils/normalize-module-specifier.ts (3 hunks)
  • packages/core-generators/src/generators/metadata/path-roots/path-roots.generator.ts (2 hunks)
  • packages/core-generators/src/generators/node/eslint/eslint.generator.ts (2 hunks)
  • packages/core-generators/src/generators/node/node-git-ignore/node-git-ignore.generator.ts (2 hunks)
  • packages/core-generators/src/generators/node/node/node.generator.ts (4 hunks)
  • packages/core-generators/src/generators/node/prettier/prettier.generator.ts (2 hunks)
  • packages/core-generators/src/generators/node/typescript/typescript.generator.ts (10 hunks)
  • packages/core-generators/src/generators/node/vitest/vitest.generator.ts (2 hunks)
  • packages/core-generators/src/providers/scopes.ts (1 hunks)
  • packages/core-generators/src/renderers/typescript/actions/render-ts-template-file-action.ts (2 hunks)
  • packages/core-generators/src/renderers/typescript/actions/render-ts-template-group-action.ts (2 hunks)
  • packages/core-generators/src/renderers/typescript/extractor/render-ts-import-providers.ts (3 hunks)
  • packages/core-generators/src/renderers/typescript/imports/normalize-module-specifier.test.ts (2 hunks)
  • packages/core-generators/src/renderers/typescript/imports/normalize-module-specifier.ts (4 hunks)
  • packages/core-generators/src/renderers/typescript/imports/types.ts (1 hunks)
  • packages/fastify-generators/src/generators/bull/fastify-bull-board/fastify-bull-board.generator.ts (2 hunks)
  • packages/fastify-generators/src/generators/core/app-module-setup/app-module-setup.generator.ts (2 hunks)
  • packages/fastify-generators/src/generators/core/app-module/app-module.generator.ts (2 hunks)
  • packages/fastify-generators/src/generators/core/config-service/config-service.generator.ts (2 hunks)
  • packages/fastify-generators/src/generators/core/error-handler-service/error-handler-service.generator.ts (2 hunks)
  • packages/fastify-generators/src/generators/core/fastify-health-check/fastify-health-check.generator.ts (2 hunks)
  • packages/fastify-generators/src/generators/core/fastify-scripts/fastify-scripts.generator.ts (2 hunks)
  • packages/fastify-generators/src/generators/core/fastify-sentry/fastify-sentry.generator.ts (2 hunks)
  • packages/fastify-generators/src/generators/core/fastify-server/fastify-server.generator.ts (2 hunks)
  • packages/fastify-generators/src/generators/core/fastify/fastify.generator.ts (2 hunks)
  • packages/fastify-generators/src/generators/core/logger-service/logger-service.generator.ts (2 hunks)
  • packages/fastify-generators/src/generators/core/request-service-context/request-service-context.generator.ts (2 hunks)
  • packages/fastify-generators/src/generators/core/service-context/service-context.generator.ts (2 hunks)
  • packages/fastify-generators/src/generators/core/service-file/service-file.generator.ts (2 hunks)
  • packages/fastify-generators/src/generators/email/fastify-postmark/fastify-postmark.generator.ts (2 hunks)
  • packages/fastify-generators/src/generators/pothos/pothos-auth/pothos-auth.generator.ts (2 hunks)
  • packages/fastify-generators/src/generators/pothos/pothos-prisma-object/pothos-prisma-object.generator.ts (2 hunks)
  • packages/fastify-generators/src/generators/pothos/pothos-prisma-primary-key/pothos-prisma-primary-key.generator.ts (2 hunks)
  • packages/fastify-generators/src/generators/pothos/pothos-prisma/pothos-prisma.generator.ts (2 hunks)
  • packages/fastify-generators/src/generators/pothos/pothos/pothos.generator.ts (3 hunks)
  • packages/fastify-generators/src/generators/prisma/prisma-crud-service/prisma-crud-service.generator.ts (2 hunks)
  • packages/fastify-generators/src/generators/prisma/prisma-model/prisma-model.generator.ts (2 hunks)
  • packages/fastify-generators/src/generators/prisma/prisma/prisma.generator.ts (2 hunks)
  • packages/fastify-generators/src/generators/yoga/yoga-plugin/yoga-plugin.generator.ts (2 hunks)
  • packages/project-builder-test/src/types.ts (1 hunks)
  • packages/react-generators/src/generators/apollo/apollo-error-link/apollo-error-link.generator.ts (2 hunks)
  • packages/react-generators/src/generators/apollo/react-apollo/react-apollo.generator.ts (3 hunks)
  • packages/react-generators/src/generators/auth/auth-identify/auth-identify.generator.ts (2 hunks)
  • packages/react-generators/src/generators/core/react-app/react-app.generator.ts (2 hunks)
  • packages/react-generators/src/generators/core/react-components/react-components.generator.ts (2 hunks)
  • packages/react-generators/src/generators/core/react-config/react-config.generator.ts (2 hunks)
  • packages/react-generators/src/generators/core/react-error/react-error.generator.ts (2 hunks)
  • packages/react-generators/src/generators/core/react-not-found-handler/react-not-found-handler.generator.ts (2 hunks)
  • packages/react-generators/src/generators/core/react-proxy/react-proxy.generator.ts (2 hunks)
  • packages/react-generators/src/generators/core/react-router/react-router.generator.ts (3 hunks)
  • packages/react-generators/src/generators/core/react-sentry/react-sentry.generator.ts (2 hunks)
  • packages/react-generators/src/generators/core/react-tailwind/react-tailwind.generator.ts (2 hunks)
  • packages/react-generators/src/generators/core/react/react.generator.ts (2 hunks)
  • packages/sync/src/actions/copy-file-action.ts (2 hunks)
  • packages/sync/src/output/errors.ts (1 hunks)
  • packages/sync/src/output/post-write-commands/filter-commands.ts (2 hunks)
  • packages/sync/src/utils/canonical-path.ts (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
packages/code-morph/src/morphers/utils/normalize-module-specifier.ts (2)
Learnt from: kingston
PR: halfdomelabs/baseplate#571
File: packages/core-generators/src/renderers/extractor/plugins/typed-templates-file.ts:102-106
Timestamp: 2025-06-11T18:31:22.247Z
Learning: For `templateExtractorBarrelExportPlugin.addGeneratedBarrelExport`, the generated barrel exports are written into `generated/index.ts`, therefore the `moduleSpecifier` must be specified relative to that file (e.g., `./typed-templates.js`), not the project root.
Learnt from: kingston
PR: halfdomelabs/baseplate#521
File: packages/react-generators/src/generators/admin/admin-crud-edit/admin-crud-edit.generator.ts:90-94
Timestamp: 2025-05-05T06:36:50.687Z
Learning: In this codebase, import paths can include `.ts` extensions, and the `resolveModuleSpecifier` function will handle them appropriately. There's no need to strip file extensions before passing paths to functions like `TsCodeUtils.importFragment`.
packages/core-generators/src/renderers/typescript/imports/normalize-module-specifier.ts (2)
Learnt from: kingston
PR: halfdomelabs/baseplate#571
File: packages/core-generators/src/renderers/extractor/plugins/typed-templates-file.ts:102-106
Timestamp: 2025-06-11T18:31:22.247Z
Learning: For `templateExtractorBarrelExportPlugin.addGeneratedBarrelExport`, the generated barrel exports are written into `generated/index.ts`, therefore the `moduleSpecifier` must be specified relative to that file (e.g., `./typed-templates.js`), not the project root.
Learnt from: kingston
PR: halfdomelabs/baseplate#521
File: packages/react-generators/src/generators/admin/admin-crud-edit/admin-crud-edit.generator.ts:90-94
Timestamp: 2025-05-05T06:36:50.687Z
Learning: In this codebase, import paths can include `.ts` extensions, and the `resolveModuleSpecifier` function will handle them appropriately. There's no need to strip file extensions before passing paths to functions like `TsCodeUtils.importFragment`.
🧬 Code Graph Analysis (54)
packages/core-generators/src/generators/node/vitest/vitest.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/react-generators/src/generators/apollo/apollo-error-link/apollo-error-link.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/react-generators/src/generators/core/react-error/react-error.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/fastify-generators/src/generators/pothos/pothos-prisma-primary-key/pothos-prisma-primary-key.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/react-generators/src/generators/core/react-config/react-config.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/fastify-generators/src/generators/core/config-service/config-service.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/fastify-generators/src/generators/core/app-module/app-module.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (2)
  • packageScope (3-6)
  • featureScope (8-11)
packages/react-generators/src/generators/core/react-sentry/react-sentry.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/code-morph/src/morphers/tests/deprecate-create-task-builder/simple/input.ts (2)
packages/code-morph/src/morphers/tests/deprecate-create-task-builder/simple/output.ts (1)
  • userSessionTypesProvider (21-22)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/code-morph/src/morphers/tests/build-tasks-as-object/simple/output.ts (2)
packages/code-morph/src/morphers/tests/build-tasks-as-object/simple/input.ts (1)
  • nodeGitIgnoreProvider (21-22)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/fastify-generators/src/generators/core/app-module-setup/app-module-setup.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/core-generators/src/renderers/typescript/imports/normalize-module-specifier.test.ts (1)
packages/core-generators/src/renderers/typescript/imports/normalize-module-specifier.ts (1)
  • getOutputRelativePathFromModuleSpecifier (142-155)
packages/fastify-generators/src/generators/prisma/prisma-crud-service/prisma-crud-service.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/fastify-generators/src/generators/core/logger-service/logger-service.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/react-generators/src/generators/core/react-app/react-app.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/fastify-generators/src/generators/core/error-handler-service/error-handler-service.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/fastify-generators/src/generators/core/fastify-server/fastify-server.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/core-generators/src/generators/node/prettier/prettier.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/fastify-generators/src/generators/pothos/pothos-auth/pothos-auth.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/core-generators/src/generators/node/node-git-ignore/node-git-ignore.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/fastify-generators/src/generators/core/service-context/service-context.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/core-generators/src/generators/node/eslint/eslint.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/react-generators/src/generators/core/react/react.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/core-generators/src/renderers/typescript/actions/render-ts-template-group-action.ts (1)
packages/sync/src/utils/canonical-path.ts (1)
  • normalizePathToOutputPath (16-21)
packages/fastify-generators/src/generators/core/request-service-context/request-service-context.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/fastify-generators/src/generators/core/service-file/service-file.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/fastify-generators/src/generators/prisma/prisma/prisma.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/fastify-generators/src/generators/bull/fastify-bull-board/fastify-bull-board.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/fastify-generators/src/generators/core/fastify-health-check/fastify-health-check.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/core-generators/src/generators/metadata/path-roots/path-roots.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/core-generators/src/providers/scopes.ts (1)
packages/sync/src/providers/export-scopes.ts (1)
  • createProviderExportScope (24-34)
packages/react-generators/src/generators/core/react-tailwind/react-tailwind.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/fastify-generators/src/generators/core/fastify-scripts/fastify-scripts.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/fastify-generators/src/generators/yoga/yoga-plugin/yoga-plugin.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/fastify-generators/src/generators/pothos/pothos-prisma-object/pothos-prisma-object.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/react-generators/src/generators/core/react-proxy/react-proxy.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/fastify-generators/src/generators/core/fastify-sentry/fastify-sentry.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/code-morph/src/morphers/tests/build-tasks-as-object/simple/input.ts (2)
packages/code-morph/src/morphers/tests/build-tasks-as-object/simple/output.ts (1)
  • nodeGitIgnoreProvider (21-22)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/react-generators/src/generators/auth/auth-identify/auth-identify.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/fastify-generators/src/generators/email/fastify-postmark/fastify-postmark.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/sync/src/output/post-write-commands/filter-commands.ts (1)
packages/sync/src/utils/canonical-path.ts (1)
  • normalizePathToOutputPath (16-21)
packages/core-generators/src/renderers/typescript/actions/render-ts-template-file-action.ts (1)
packages/sync/src/utils/canonical-path.ts (1)
  • normalizePathToOutputPath (16-21)
packages/fastify-generators/src/generators/pothos/pothos/pothos.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/sync/src/actions/copy-file-action.ts (1)
packages/sync/src/utils/canonical-path.ts (1)
  • normalizePathToOutputPath (16-21)
packages/fastify-generators/src/generators/prisma/prisma-model/prisma-model.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/code-morph/src/morphers/tests/deprecate-create-task-builder/simple/output.ts (2)
packages/code-morph/src/morphers/tests/deprecate-create-task-builder/simple/input.ts (1)
  • userSessionTypesProvider (25-26)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/fastify-generators/src/generators/pothos/pothos-prisma/pothos-prisma.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/react-generators/src/generators/apollo/react-apollo/react-apollo.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/fastify-generators/src/generators/core/fastify/fastify.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/react-generators/src/generators/core/react-components/react-components.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/react-generators/src/generators/core/react-router/react-router.generator.ts (2)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/react-generators/src/providers/routes.ts (2)
  • reactRoutesProvider (26-27)
  • reactRoutesReadOnlyProvider (34-37)
packages/react-generators/src/generators/core/react-not-found-handler/react-not-found-handler.generator.ts (1)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/core-generators/src/generators/node/node/node.generator.ts (5)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/sync/src/generators/generators.ts (1)
  • createGeneratorTask (196-204)
packages/fastify-generators/src/generators/core/error-handler-service/error-handler-service.generator.ts (1)
  • configTask (25-38)
packages/core-generators/src/providers/project.ts (1)
  • packageInfoProvider (18-19)
packages/code-morph/src/morphers/tests/build-tasks-as-object/converted/input.ts (1)
  • nodeProvider (71-71)
packages/core-generators/src/generators/node/typescript/typescript.generator.ts (3)
packages/core-generators/src/providers/scopes.ts (1)
  • packageScope (3-6)
packages/core-generators/src/renderers/typescript/imports/normalize-module-specifier.ts (1)
  • getOutputRelativePathFromModuleSpecifier (142-155)
packages/sync/src/utils/canonical-path.ts (1)
  • normalizePathToOutputPath (16-21)
🪛 ESLint
packages/fastify-generators/src/generators/core/app-module/app-module.generator.ts

[error] 7-7: Expected "packageScope" to come before "pathRootsProvider".

(perfectionist/sort-named-imports)

packages/react-generators/src/generators/core/react-tailwind/react-tailwind.generator.ts

[error] 6-6: Expected "packageScope" to come before "prettierProvider".

(perfectionist/sort-named-imports)

packages/fastify-generators/src/generators/pothos/pothos/pothos.generator.ts

[error] 8-8: Expected "packageScope" to come before "prettierProvider".

(perfectionist/sort-named-imports)

packages/react-generators/src/generators/apollo/react-apollo/react-apollo.generator.ts

[error] 13-13: Expected "packageScope" to come before "prettierProvider".

(perfectionist/sort-named-imports)

⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Lint
  • GitHub Check: test
  • GitHub Check: Test E2E
🔇 Additional comments (98)
packages/project-builder-test/src/types.ts (1)

42-45: ```shell
#!/bin/bash
set -e

Print lines 1–70 to capture the definition around line 42

sed -n '1,70p' packages/project-builder-test/src/types.ts


</details>
<details>
<summary>packages/core-generators/src/generators/node/vitest/vitest.generator.ts (2)</summary>

`9-9`: **Renamed import for clarity**  
The import of `packageScope` correctly replaces the previous `projectScope` import, aligning with the global refactor.

---

`39-39`: **Updated configScope to use packageScope**  
The `configScope` option now references `packageScope`, ensuring the config provider task uses the new identifier.

</details>
<details>
<summary>packages/fastify-generators/src/generators/core/config-service/config-service.generator.ts (2)</summary>

`7-7`: **Imported `packageScope`**  
Adding `packageScope` here aligns with the renaming of the config provider scope.

---

`69-69`: **Refactored configScope to packageScope**  
The `createConfigProviderTask` now uses `packageScope` for its `configScope`, consistent with the new naming convention.

</details>
<details>
<summary>packages/react-generators/src/generators/core/react-config/react-config.generator.ts (2)</summary>

`6-6`: **Imported `packageScope`**  
Replaces the old `projectScope` import to match the updated scope terminology.

---

`55-55`: **Updated configScope to packageScope**  
Ensures the config provider task uses `packageScope` for its `configScope` option.

</details>
<details>
<summary>packages/react-generators/src/generators/apollo/apollo-error-link/apollo-error-link.generator.ts (2)</summary>

`2-2`: **Imported `packageScope`**  
Swapping in `packageScope` here maintains consistency with the refactored scope naming.

---

`38-38`: **Export using packageScope**  
The `.export(packageScope)` call now uses the updated `packageScope` identifier.

</details>
<details>
<summary>packages/react-generators/src/generators/core/react/react.generator.ts (2)</summary>

`8-8`: **Imported `packageScope`**  
Updating the import to use `packageScope` follows the new naming standard.

---

`42-42`: **Set configScope to packageScope**  
The `createConfigProviderTask` now correctly uses `packageScope` for its `configScope`.

</details>
<details>
<summary>packages/react-generators/src/generators/core/react-app/react-app.generator.ts (2)</summary>

`4-4`: **Update import to `packageScope`.**

Replaced `projectScope` with `packageScope` from `@baseplate-dev/core-generators` to align with updated scope naming conventions.

---

`55-55`: **Use `packageScope` for config provider.**

Updated `configScope` to `packageScope` ensuring consistent scope naming for the `react-app` configuration provider.

</details>
<details>
<summary>packages/fastify-generators/src/generators/pothos/pothos-auth/pothos-auth.generator.ts (2)</summary>

`4-4`: **Import `packageScope` instead of `projectScope`.**

Aligned with refactor to use `packageScope` for provider exports.

---

`109-109`: **Export using `packageScope`.**

Updated `pothosAuthProvider.export` to use `packageScope`, reflecting the new scope naming convention.

</details>
<details>
<summary>packages/fastify-generators/src/generators/core/logger-service/logger-service.generator.ts (2)</summary>

`6-6`: **Import `packageScope` for config scope.**

Replaced `projectScope` with `packageScope` in core-generators import to match updated scope semantics.

---

`32-32`: **Apply `packageScope` to `createConfigProviderTask`.**

Changed `configScope` to `packageScope` for the logger-service configuration provider.

</details>
<details>
<summary>packages/fastify-generators/src/generators/core/app-module-setup/app-module-setup.generator.ts (2)</summary>

`4-4`: **Import `packageScope` for config providers.**

Updated import to use `packageScope` rather than `projectScope` across configuration providers.

---

`27-28`: **Replace scope options with `packageScope`.**

Changed both `configScope` and `configValuesScope` to `packageScope` in `createConfigProviderTask` to standardize scope naming.

</details>
<details>
<summary>packages/fastify-generators/src/generators/pothos/pothos-prisma-primary-key/pothos-prisma-primary-key.generator.ts (2)</summary>

`1-1`: **Import `packageScope` for provider export.**

Replaced `projectScope` import with `packageScope` to align with new scope convention.

---

`49-49`: **Use `packageScope` in export call.**

Updated `pothosTypeOutputProvider.export` to accept `packageScope` as its first argument, reflecting the refactor.

</details>
<details>
<summary>packages/fastify-generators/src/generators/core/error-handler-service/error-handler-service.generator.ts (2)</summary>

`4-4`: **LGTM: Import statement updated consistently.**

The import has been correctly updated to use `packageScope` instead of `projectScope`, aligning with the refactoring objectives.

---

`36-36`: **LGTM: Configuration scope updated consistently.**

The `configScope` parameter has been correctly updated to use `packageScope`, maintaining consistency with the import change.

</details>
<details>
<summary>packages/fastify-generators/src/generators/core/fastify-sentry/fastify-sentry.generator.ts (2)</summary>

`7-7`: **LGTM: Import statement updated consistently.**

The import has been correctly updated to use `packageScope` instead of `projectScope`.

---

`58-58`: **LGTM: Configuration scope updated consistently.**

The `configScope` parameter has been correctly updated to use `packageScope`.

</details>
<details>
<summary>packages/fastify-generators/src/generators/yoga/yoga-plugin/yoga-plugin.generator.ts (2)</summary>

`11-11`: **LGTM: Import statement updated consistently.**

The import has been correctly updated to use `packageScope` instead of `projectScope`.

---

`101-101`: **LGTM: Export scope updated consistently.**

The provider export has been correctly updated to use `packageScope`, maintaining consistency with the import change.

</details>
<details>
<summary>packages/react-generators/src/generators/core/react-sentry/react-sentry.generator.ts (2)</summary>

`6-6`: **LGTM: Import statement updated consistently.**

The import has been correctly updated to use `packageScope` instead of `projectScope`.

---

`41-41`: **LGTM: Configuration scope updated consistently.**

The `configScope` parameter has been correctly updated to use `packageScope`.

</details>
<details>
<summary>packages/fastify-generators/src/generators/bull/fastify-bull-board/fastify-bull-board.generator.ts (3)</summary>

`7-7`: **LGTM: Import statement updated consistently.**

The import has been correctly updated to use `packageScope` instead of `projectScope`.

---

`45-45`: **LGTM: Configuration scope updated consistently.**

The `configScope` parameter has been correctly updated to use `packageScope`.

---

`1-157`: **Verify complete refactoring across the codebase.**

The refactoring from `projectScope` to `packageScope` appears consistent across all reviewed files. To ensure no instances were missed, please verify that all references have been updated.


```shell
#!/bin/bash
# Description: Verify that all projectScope references have been updated to packageScope
# Expected: No remaining references to projectScope in the codebase

echo "Searching for any remaining 'projectScope' references..."
rg "projectScope" --type ts --type js

echo "Searching for 'packageScope' usage to confirm new references..."
rg "packageScope" --type ts --type js -A 2 -B 2
packages/code-morph/src/morphers/tests/build-tasks-as-object/simple/output.ts (2)

11-11: Rename import to packageScope.

The import of the provider export scope has been updated correctly to packageScope. Ensure the path alias #src/providers/scopes.js resolves in your TS configuration.


38-38: Use packageScope for provider export.

The nodeGitIgnoreProvider.export call now correctly uses packageScope instead of projectScope. This aligns with the refactoring objective.

packages/react-generators/src/generators/core/react-error/react-error.generator.ts (2)

4-4: Import packageScope instead of projectScope.

The scope import from @baseplate-dev/core-generators has been updated to the new identifier.


29-29: Set configScope to packageScope.

The createConfigProviderTask now uses the renamed scope, ensuring consistency.

packages/code-morph/src/morphers/tests/deprecate-create-task-builder/simple/output.ts (2)

7-7: Swap import to packageScope.

The import from @baseplate-dev/core-generators now references packageScope as intended.


37-37: Export provider with packageScope.

The userSessionTypesProvider.export call correctly uses packageScope following the naming refactor.

packages/fastify-generators/src/generators/core/fastify-health-check/fastify-health-check.generator.ts (2)

4-4: Update import of packageScope.

Aligns the imported scope identifier with the updated naming convention.


32-32: Use packageScope for configScope.

The configuration task now correctly applies the packageScope option.

packages/fastify-generators/src/generators/core/service-context/service-context.generator.ts (2)

4-4: Adjust import to packageScope.

The provider export scope import has been updated to the new identifier.


61-61: Change configScope to packageScope.

The createConfigProviderTask configuration now consistently uses packageScope.

packages/fastify-generators/src/generators/core/request-service-context/request-service-context.generator.ts (1)

4-4: LGTM! Consistent refactoring applied correctly.

The import and usage of packageScope (formerly projectScope) have been updated consistently. The changes align with the exported scope from packages/core-generators/src/providers/scopes.ts.

Also applies to: 47-47

packages/fastify-generators/src/generators/core/fastify-scripts/fastify-scripts.generator.ts (1)

3-3: LGTM! Consistent refactoring applied correctly.

The import and usage of packageScope have been updated consistently throughout the file. The provider export now correctly uses the renamed scope.

Also applies to: 38-38

packages/fastify-generators/src/generators/core/fastify-server/fastify-server.generator.ts (1)

6-6: LGTM! Consistent refactoring applied correctly.

The import and usage of packageScope in the configuration provider task have been updated consistently. The scope reference is correct and aligns with the exported scope.

Also applies to: 68-68

packages/core-generators/src/renderers/typescript/imports/types.ts (1)

72-72: LGTM! Comment updated to align with terminology refactoring.

The comment update from "project relative path" to "output relative path" is consistent with the broader refactoring effort and improves clarity about the path's meaning.

packages/core-generators/src/generators/node/node-git-ignore/node-git-ignore.generator.ts (1)

8-8: LGTM! Consistent refactoring applied correctly.

The import and usage of packageScope have been updated consistently. The internal import path and configuration scope usage are both correct.

Also applies to: 21-21

packages/core-generators/src/generators/node/eslint/eslint.generator.ts (2)

10-10: LGTM! Import statement updated correctly.

The import statement has been updated from projectScope to packageScope to align with the naming refactor for better clarity.


47-47: LGTM! ConfigScope updated consistently.

The configScope parameter has been correctly updated to use packageScope instead of projectScope, maintaining consistency with the renamed import.

packages/fastify-generators/src/generators/prisma/prisma/prisma.generator.ts (2)

9-9: LGTM! Import updated for consistency.

The import statement correctly uses packageScope instead of projectScope to align with the naming refactor.


168-169: LGTM! Provider exports updated consistently.

Both the prismaSchemaProvider export and prismaOutputProvider export have been correctly updated to use packageScope, maintaining consistency with the renamed scope throughout the codebase.

packages/fastify-generators/src/generators/prisma/prisma-crud-service/prisma-crud-service.generator.ts (2)

1-1: LGTM! Import statement updated correctly.

The import has been updated to use packageScope instead of projectScope, consistent with the naming refactor across the codebase.


44-44: LGTM! Export scope updated consistently.

The .andExport() method call correctly uses packageScope instead of projectScope, maintaining the same export functionality with the renamed scope.

packages/core-generators/src/generators/node/prettier/prettier.generator.ts (2)

24-24: LGTM! Import updated for naming consistency.

The import statement has been correctly updated from projectScope to packageScope to align with the naming refactor.


128-128: LGTM! Provider export updated consistently.

The prettierProvider.export() call correctly uses packageScope instead of projectScope, maintaining consistent naming throughout the codebase.

packages/fastify-generators/src/generators/pothos/pothos-prisma-object/pothos-prisma-object.generator.ts (2)

3-3: LGTM! Import statement updated correctly.

The import has been updated to use packageScope instead of projectScope, maintaining consistency with the naming refactor across the codebase.


71-71: LGTM! Export scope parameter updated consistently.

The pothosTypeOutputProvider.export() call correctly uses packageScope as the first parameter instead of projectScope, maintaining the same export functionality with the renamed scope.

packages/react-generators/src/generators/core/react-components/react-components.generator.ts (2)

4-4: LGTM: Import statement correctly updated.

The import has been properly updated from projectScope to packageScope as part of the naming refactor.


80-80: LGTM: Export usage consistently updated.

The export call correctly uses the renamed packageScope variable, maintaining the same functionality while improving naming clarity.

packages/fastify-generators/src/generators/prisma/prisma-model/prisma-model.generator.ts (2)

1-1: LGTM: Import correctly updated for scope refactoring.

The import statement has been properly updated to use packageScope instead of projectScope.


50-50: LGTM: Export chaining updated consistently.

The chained export call correctly uses packageScope while maintaining the same export functionality with the descriptor name.

packages/react-generators/src/generators/auth/auth-identify/auth-identify.generator.ts (2)

5-5: LGTM: Import statement properly updated in multi-line import.

The import has been correctly updated from projectScope to packageScope within the destructured import block.


46-46: LGTM: Export call consistently updated.

The export call properly uses the renamed packageScope variable, maintaining the same export functionality.

packages/core-generators/src/generators/metadata/path-roots/path-roots.generator.ts (2)

11-11: LGTM: Local import correctly updated.

The import from the local scopes file has been properly updated to use packageScope instead of projectScope.


40-40: LGTM: Export call updated consistently.

The export call correctly uses the renamed packageScope variable, maintaining the same provider export functionality.

packages/fastify-generators/src/generators/core/service-file/service-file.generator.ts (2)

8-8: LGTM: Import correctly updated in multi-line import.

The import has been properly updated from projectScope to packageScope within the destructured import from the core-generators package.


104-104: LGTM: Conditional export updated consistently.

The export call correctly uses packageScope while maintaining the conditional logic that includes the descriptor.id when present.

packages/react-generators/src/generators/core/react-proxy/react-proxy.generator.ts (1)

1-1: LGTM! Consistent refactoring from projectScope to packageScope.

The changes align with the PR objective to clarify scope naming conventions.

Also applies to: 34-34

packages/react-generators/src/generators/core/react-not-found-handler/react-not-found-handler.generator.ts (1)

2-2: LGTM! Consistent refactoring from projectScope to packageScope.

The changes are part of the coordinated effort to clarify scope naming conventions across the codebase.

Also applies to: 46-46

packages/core-generators/src/renderers/typescript/actions/render-ts-template-group-action.ts (1)

7-7: LGTM! Consistent refactoring from project paths to output paths terminology.

The function renaming from normalizePathToProjectPath to normalizePathToOutputPath clarifies the path semantics as intended by the PR objective. The functionality remains unchanged.

Also applies to: 116-116

packages/core-generators/src/providers/scopes.ts (1)

3-6: ```shell
#!/bin/bash

Verify that no references to the old projectScope remain and that packageScope is in use.

echo "🔍 Searching all .ts, .tsx, .js, .jsx files for 'projectScope' references:"
rg -i "projectScope" -g '.ts' -g '.tsx' -g '.js' -g '.jsx' -A2 -B2 || echo "✅ No remaining 'projectScope' references found."

echo -e "\n🔍 Counting occurrences of 'packageScope' across code files:"
rg "packageScope" -g '.ts' -g '.tsx' -g '.js' -g '.jsx' -c || echo "⚠️ No 'packageScope' usages found."


</details>
<details>
<summary>packages/code-morph/src/morphers/tests/build-tasks-as-object/converted/output.ts (4)</summary>

`22-22`: **LGTM! Consistent import update.**

The import statement correctly uses the renamed `packageScope` constant.

---

`111-111`: **LGTM! Configuration scope updated correctly.**

The `configScope` parameter correctly uses `packageScope` instead of the old `projectScope`.

---

`120-120`: **LGTM! Generator scopes array updated.**

The scopes array correctly references `packageScope`.

---

`125-125`: **LGTM! Export scopes updated consistently.**

Both provider exports correctly use `packageScope` for their export scope.



Also applies to: 136-136

</details>
<details>
<summary>packages/react-generators/src/generators/apollo/react-apollo/react-apollo.generator.ts (2)</summary>

`152-152`: **LGTM! Configuration scope updated correctly.**

The `configScope` parameter correctly uses `packageScope`.

---

`263-263`: **LGTM! Export scope updated correctly.**

The export scope correctly uses `packageScope`.

</details>
<details>
<summary>packages/sync/src/output/errors.ts (1)</summary>

`20-22`: **LGTM! Path terminology improved for clarity.**

The parameter rename from `projectRelativePath` to `outputRelativePath` and corresponding error message update improve clarity about the path type being referenced.

</details>
<details>
<summary>packages/code-morph/src/morphers/tests/build-tasks-as-object/converted/input.ts (1)</summary>

`22-22`: **LGTM! All packageScope references updated consistently.**

All references to `packageScope` have been correctly updated throughout the file:
- Import statement
- Configuration scope parameter
- Generator scopes array  
- Provider export scopes

The changes are consistent and maintain the expected test input/output alignment.



Also applies to: 111-111, 120-120, 125-125, 136-136

</details>
<details>
<summary>packages/fastify-generators/src/generators/email/fastify-postmark/fastify-postmark.generator.ts (1)</summary>

`4-4`: **LGTM! Consistent scope refactor.**

The import and usage of `packageScope` (previously `projectScope`) are correctly updated and align with the broader refactor to clarify scope semantics.



Also applies to: 56-56

</details>
<details>
<summary>packages/code-morph/src/morphers/tests/deprecate-create-task-builder/simple/input.ts (1)</summary>

`7-7`: **LGTM! Test file correctly demonstrates the refactor.**

The import and usage changes from `projectScope` to `packageScope` are consistent and properly demonstrate the expected refactor pattern.



Also applies to: 36-36

</details>
<details>
<summary>packages/fastify-generators/src/generators/pothos/pothos-prisma/pothos-prisma.generator.ts (1)</summary>

`4-4`: **LGTM! Consistent scope terminology update.**

The refactor from `projectScope` to `packageScope` is correctly applied in both import and export usage.



Also applies to: 46-46

</details>
<details>
<summary>packages/fastify-generators/src/generators/pothos/pothos/pothos.generator.ts (1)</summary>

`8-8`: **LGTM! Scope refactor applied consistently.**

All occurrences of `projectScope` have been correctly updated to `packageScope` across import and usage sites.



Also applies to: 56-56, 102-102, 104-104

</details>
<details>
<summary>packages/core-generators/src/renderers/typescript/actions/render-ts-template-file-action.ts (1)</summary>

`9-9`: **LGTM! Path terminology refactor correctly applied.**

The function name change from `normalizePathToProjectPath` to `normalizePathToOutputPath` better clarifies the intent of normalizing paths for output file generation. Both import and usage are consistently updated.



Also applies to: 131-131

</details>
<details>
<summary>packages/sync/src/output/post-write-commands/filter-commands.ts (1)</summary>

`1-1`: **LGTM! Consistent function rename.**

The import and usage of `normalizePathToOutputPath` are correctly updated throughout the file, aligning with the broader refactor to clarify path semantics.



Also applies to: 33-33

</details>
<details>
<summary>packages/sync/src/actions/copy-file-action.ts (1)</summary>

`5-5`: **LGTM! Consistent function rename.**

The import and usage of `normalizePathToOutputPath` are properly updated, maintaining the same functionality while improving clarity.



Also applies to: 48-48

</details>
<details>
<summary>packages/core-generators/src/renderers/typescript/extractor/render-ts-import-providers.ts (1)</summary>

`115-116`: **LGTM! Consistent variable rename.**

The variable declaration and all usage sites are correctly updated from `projectScope` to `packageScope`, improving semantic clarity throughout the function.



Also applies to: 155-155, 196-196

</details>
<details>
<summary>.changeset/early-friends-punch.md (1)</summary>

`1-13`: **LGTM! Comprehensive changeset documentation.**

The changeset properly documents the scope of this refactor across 8 packages, with a clear description that aligns with the PR objectives.

</details>
<details>
<summary>packages/code-morph/src/morphers/tests/build-tasks-as-object/simple/input.ts (1)</summary>

`11-11`: It looks like ripgrep’s built-in types don’t include `tsx` in this environment. Let’s re-run the searches using filename globs instead:


```shell
#!/bin/bash
# Re-run searches using glob filters rather than --type flags

echo "Searching for any remaining 'projectScope' references:"
rg "projectScope" -g '*.ts' -g '*.tsx' -g '*.js' -g '*.jsx' || true

echo -e "\nSearching for any remaining 'normalizePathToProjectPath' references:"
rg "normalizePathToProjectPath" -g '*.ts' -g '*.tsx' -g '*.js' -g '*.jsx' || true

echo -e "\nSearching for any remaining 'project path' in comments/strings (case-insensitive):"
rg -i "project path" -g '*.ts' -g '*.tsx' -g '*.js' -g '*.jsx' || true
packages/react-generators/src/generators/core/react-router/react-router.generator.ts (1)

6-6: LGTM! Consistent scope naming refactor.

The changes properly update all references from projectScope to packageScope throughout the file - in the import statement, configuration scope, and provider exports. This maintains functionality while improving terminology clarity.

Also applies to: 42-42, 87-88

packages/core-generators/src/renderers/typescript/imports/normalize-module-specifier.test.ts (1)

6-6: LGTM! Test updates align with function rename.

All references to the renamed function getOutputRelativePathFromModuleSpecifier are properly updated - import statement, test suite name, and function calls. The test logic remains unchanged while following the new "output path" terminology.

Also applies to: 73-73, 77-77, 82-84

packages/fastify-generators/src/generators/core/fastify/fastify.generator.ts (1)

9-9: LGTM! Consistent scope refactor across generator exports.

The changes properly update the import and both provider exports (fastifyProvider and fastifyOutputProvider) to use packageScope instead of projectScope, maintaining consistency with the broader refactor.

Also applies to: 116-116, 119-119

.vscode/generator.json.code-snippets (1)

25-25: LGTM! Important snippet updates maintain developer tooling consistency.

The VS Code snippets are properly updated to use packageScope instead of projectScope in imports, exports, and configuration. This ensures developers using these snippets will automatically follow the new naming convention.

Also applies to: 45-45, 122-122

packages/sync/src/utils/canonical-path.ts (1)

4-5: LGTM! Clear terminology improvement from "project" to "output" paths.

The function rename from normalizePathToProjectPath to normalizePathToOutputPath and updated documentation comments improve clarity about path semantics. The implementation remains unchanged, maintaining functionality while enhancing readability.

Also applies to: 12-12, 16-16

packages/core-generators/src/generators/node/node/node.generator.ts (1)

22-22: LGTM: Consistent scope renaming throughout the file

The refactoring from projectScope to packageScope has been applied consistently across all usages - import, config provider task, generator scopes, and export calls. The changes align perfectly with the PR objective.

Also applies to: 125-125, 134-134, 138-138, 167-167

packages/code-morph/src/morphers/utils/normalize-module-specifier.ts (1)

9-28: LGTM: Clean and consistent terminology refactoring

The refactoring from "project relative path" to "output relative path" has been applied thoroughly throughout the file. Function names, parameter names, variable names, comments, and error messages have all been updated consistently. The underlying logic remains unchanged, which is exactly what's expected for this type of terminology improvement.

Also applies to: 31-68, 159-194

packages/core-generators/src/generators/node/typescript/typescript.generator.ts (1)

12-12: LGTM: Comprehensive and consistent refactoring

This file demonstrates excellent consistency in applying both aspects of the refactoring:

  1. Path terminology: Successfully updated from "project relative path" to "output relative path" across imports, interface definitions, variable names, and function calls
  2. Scope renaming: Consistently replaced projectScope with packageScope in config provider tasks and export calls

The interface TypescriptFileProvider method signatures have been appropriately updated to reflect the new terminology while maintaining the same functionality. All variable names and internal logic have been updated consistently.

Also applies to: 28-28, 33-33, 124-126, 134-134, 168-170, 227-227, 238-258, 279-279, 317-317, 343-358

packages/core-generators/src/renderers/typescript/imports/normalize-module-specifier.ts (1)

9-23: LGTM: Consistent function and variable renaming

The refactoring has been applied consistently throughout this file:

  • Function names updated from "project" to "output" terminology
  • Parameter names consistently changed across all functions
  • JSDoc comments updated to reflect the new semantics
  • Variable names updated while preserving the exact same logic

The changes ensure consistency with the broader codebase refactoring while maintaining all existing functionality. The getOutputRelativePathFromModuleSpecifier function now has a clearer name that better describes its purpose.

Also applies to: 26-63, 136-155, 170-201

@coderabbitai
Copy link

coderabbitai bot commented Jun 21, 2025

✅ Actions performed

Reviews paused.

@kingston kingston merged commit f5d7a6f into main Jun 21, 2025
9 checks passed
@kingston kingston deleted the kingston/eng-738-rename-projectscope-and-projectrelativepath branch June 21, 2025 16:20
@github-actions github-actions bot mentioned this pull request Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants