-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: Simplify template metadata system by consolidating template definitions in extractor.json #596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Simplify template metadata system by consolidating template definitions in extractor.json #596
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: f6d29ec The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Caution Review failedThe pull request is closed. WalkthroughThis change refactors the template metadata system by consolidating template definitions to be keyed by template names in Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant CLI
participant ProjectBuilderServer
participant Sync
participant FileSystem
User->>CLI: templates generate <directory> <app> [--skip-clean]
CLI->>ProjectBuilderServer: generateTemplateFilesForProject(directory, app, plugins, logger, options)
ProjectBuilderServer->>Sync: generateTemplateFiles(templateExtractors, appDir, generatorPackageMap, logger, options)
Sync->>FileSystem: Read extractor.json (keyed by template name)
Sync->>FileSystem: Write generated template files
Sync->>FileSystem: Write .templates-info.json
Sync->>CLI: Generation complete
Possibly related PRs
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Summary by CodeRabbit
New Features
Refactor
Bug Fixes
Chores
End-users will experience more consistent template management, easier manual template regeneration, and improved reliability in code generation workflows.