feat: Refactor storage plugin file category system to use registry-based pattern #606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lid session token
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 840c45f The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis update refactors the storage plugin's file category system, migrating from a centralized array to a modular, registry-based structure with individual category files and a type-safe registry. Numerous naming and API changes are made across the storage plugin and its React components, including renaming fields, updating GraphQL schemas, and restructuring adapters and service logic. The plugin's migration and configuration APIs are updated, and new utility modules and validation logic are introduced for file uploads, adapters, and categories. ESLint and TypeScript configurations are also updated, and new tests and utilities are added. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ReactComponent
participant GraphQLAPI
participant Service
participant FileCategoryRegistry
participant Adapter
User->>ReactComponent: Upload file (selects category)
ReactComponent->>GraphQLAPI: createPresignedUploadUrl(category: Enum, filename, size)
GraphQLAPI->>Service: createPresignedUploadUrl(input)
Service->>FileCategoryRegistry: getCategoryByNameOrThrow(category)
FileCategoryRegistry-->>Service: FileCategory object
Service->>Adapter: createPresignedUploadUrl(path, options)
Adapter-->>Service: PresignedUploadUrl
Service-->>GraphQLAPI: { url, method, fields, expiresAt, file }
GraphQLAPI-->>ReactComponent: Presigned upload URL and file info
ReactComponent->>User: Shows upload form/status
sequenceDiagram
participant User
participant ReactComponent
participant GraphQLAPI
participant Service
participant FileCategoryRegistry
participant Adapter
User->>ReactComponent: Request file download (select file)
ReactComponent->>GraphQLAPI: createPresignedDownloadUrl(category: Enum, fileId)
GraphQLAPI->>Service: createPresignedDownloadUrl(input)
Service->>FileCategoryRegistry: getCategoryByNameOrThrow(category)
FileCategoryRegistry-->>Service: FileCategory object
Service->>Adapter: createPresignedDownloadUrl(path)
Adapter-->>Service: PresignedDownloadUrl
Service-->>GraphQLAPI: Presigned download URL
GraphQLAPI-->>ReactComponent: Download URL
ReactComponent->>User: Initiates download
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 13
🔭 Outside diff range comments (2)
plugins/plugin-auth/src/auth/core/generators/auth-routes/templates/routes/auth_/register.tsx (1)
119-140: Enforce CSS class prefixing in auth plugin templatesPer our plugin component guidelines, all CSS classes in
.tsxfiles underplugins/plugin-authmust be prefixed withauth-(including Tailwind utility classes used inclassName). This applies even to generator template files, since they produce the plugin’s UI code. Please update the following template files:
- plugins/plugin-auth/src/auth/core/generators/auth-routes/templates/routes/auth_/route.tsx
- plugins/plugin-auth/src/auth/core/generators/auth-routes/templates/routes/auth_/register.tsx
- plugins/plugin-auth/src/auth/core/generators/auth-routes/templates/routes/auth_/login.tsx
For each
className, prefix every class token withauth-. For example:- className="flex flex-col gap-6" + className="auth-flex auth-flex-col auth-gap-6"Repeat this for all
div,Button, andLinkelements in these templates.plugins/plugin-storage/src/generators/react/upload-components/templates/src/components/file-input/file-input.tsx (1)
132-262: Missing storage- prefix on Tailwind classes.According to the coding guidelines, all CSS classes in plugin components must be prefixed with the plugin name to avoid style conflicts. This component uses many Tailwind classes without the required
storage-prefix.All Tailwind classes need to be prefixed with
storage-. For example:- <div className={cn('max-w-md', className)}> + <div className={cn('storage-max-w-md', className)}>- className="flex h-12 w-full max-w-md items-center justify-between rounded-md border bg-background px-3 py-2 shadow-sm" + className="storage-flex storage-h-12 storage-w-full storage-max-w-md storage-items-center storage-justify-between storage-rounded-md storage-border storage-bg-background storage-px-3 storage-py-2 storage-shadow-sm"This applies to all Tailwind classes throughout the component.
♻️ Duplicate comments (5)
plugins/plugin-auth/src/auth/core/generators/auth-email-password/auth-email-password.generator.ts (1)
5-5: Same extension concern applies hereSee previous comment – ensure
generated/index.jsexists (or is mapped) when this generator runs in dev mode.plugins/plugin-auth/src/auth/core/generators/auth-module/auth-module.generator.ts (1)
15-15: Verify.jsbarrel is present before executionRe-check dev-time execution path for
generated/index.jsas noted in earlier comment.plugins/plugin-auth/src/auth/core/generators/react-session/react-session.generator.ts (1)
5-5: Ensure generated barrel compiled to .jsSame runtime availability check applies.
plugins/plugin-auth/src/placeholder-auth/core/generators/placeholder-auth-module/auth-module.generator.ts (1)
4-4: Placeholder generator: confirm compiled barrel pathMake sure
placeholder-authgenerated barrel is emitted asindex.jsbefore this file executes.plugins/plugin-auth/src/auth/core/generators/auth-routes/templates/routes/auth_/login.tsx (1)
132-156: CSS class prefixing concern applies here too.Same CSS class prefixing issue as in the register template. The classes should be prefixed with
auth-according to plugin guidelines, unless template files are exempt from this requirement.
🧹 Nitpick comments (6)
plugins/plugin-auth/src/common/compiler/generator-creators.ts (1)
12-12: Prefer path-alias import over relative pathGreat call adding the
.jsextension, but our guidelines favor alias-based imports (@src/...) to avoid brittle../hops and ease future refactors.-import type { AuthRoleDefinition } from '../roles/index.js'; +import type { AuthRoleDefinition } from '@src/common/roles/index.js';packages/tools/tsconfig.vite.lib.json (1)
8-9: Double-checkmodule+moduleResolutioncombo is intentional
"module": "NodeNext"already implies Node-style resolution; explicitly adding"moduleResolution": "Node16"is redundant and occasionally causes confusing IntelliSense discrepancies when the base config also sets these options differently.If the base config already defines either value, consider omitting the duplicate here to avoid config drift.
packages/project-builder-lib/tsconfig.json (1)
6-6:noEmit: truemakesoutDir& build scripts misleading
WithnoEmitenabled,tscwill never write todist/, so keeping"outDir": "dist"suggests artefacts that never appear. Either:- "outDir": "dist", - "rootDir": "src", - "noEmit": true + "rootDir": "src", + "noEmit": trueor drop
noEmitif this package is supposed to publish compiled JS.packages/project-builder-web/src/routes/data/models/-hooks/use-model-form.ts (1)
31-42: Good separation of concerns: Hook now focused solely on editing.The refactor successfully simplifies the hook by removing creation logic, making it single-purpose. The updated JSDoc clearly reflects this change.
Consider defining a named interface for the return type to improve readability:
+interface UseModelFormResult { + form: UseFormReturn<ModelConfigInput>; + onSubmit: () => Promise<void>; + originalModel: ModelConfig; + defaultValues: ModelConfigInput; +} + export function useModelForm({ onSubmitSuccess, omit, modelKey, -}: UseModelFormOptions): { - form: UseFormReturn<ModelConfigInput>; - onSubmit: () => Promise<void>; - originalModel: ModelConfig; - defaultValues: ModelConfigInput; -} { +}: UseModelFormOptions): UseModelFormResult {plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/services/create-presigned-upload-url.ts (1)
34-41: Use validated contentType for consistency.Consider using the validated contentType from
fileCreateInput.mimeTypeinstead ofinput.contentTypeto ensure consistency with the validation logic.const result = await adapter.createPresignedUploadUrl({ path: file.storagePath, contentLengthRange: [ fileCategory.minFileSize ?? 0, fileCategory.maxFileSize, ], - contentType: input.contentType, + contentType: fileCreateInput.mimeType, });plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/utils/mime.ts (1)
10-21: Reconsider encoding fallback behavior.The fallback to 'utf-8' when an invalid charset is detected might not be appropriate for all content types. Consider returning
undefinedinstead to let the caller decide the appropriate encoding.// Node.js uses Buffer.isEncoding for valid encodings - return Buffer.isEncoding(charset) ? charset : 'utf-8'; + return Buffer.isEncoding(charset) ? charset : undefined;
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (5)
plugins/plugin-storage/src/generators/fastify/storage-module/generated/template-paths.tsis excluded by!**/generated/**,!**/generated/**plugins/plugin-storage/src/generators/fastify/storage-module/generated/template-renderers.tsis excluded by!**/generated/**,!**/generated/**plugins/plugin-storage/src/generators/fastify/storage-module/generated/ts-import-providers.tsis excluded by!**/generated/**,!**/generated/**plugins/plugin-storage/src/generators/fastify/storage-module/generated/typed-templates.tsis excluded by!**/generated/**,!**/generated/**pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (69)
.changeset/dull-words-fold.md(1 hunks).changeset/plenty-mails-refuse.md(1 hunks).changeset/short-vans-judge.md(1 hunks)packages/core-generators/src/generators/node/eslint/react-rules.ts(1 hunks)packages/core-generators/src/generators/node/eslint/templates/eslint.config.js(1 hunks)packages/project-builder-lib/tsconfig.json(1 hunks)packages/project-builder-web/src/routes/data/models/-components/new-model-dialog.tsx(3 hunks)packages/project-builder-web/src/routes/data/models/-hooks/use-edited-model-config.tsx(2 hunks)packages/project-builder-web/src/routes/data/models/-hooks/use-model-form.ts(3 hunks)packages/project-builder-web/src/routes/data/models/edit.$key/-components/fields/model-field-form.tsx(2 hunks)packages/project-builder-web/src/routes/data/models/edit.$key/graphql.tsx(2 hunks)packages/project-builder-web/src/routes/data/models/edit.$key/index.tsx(2 hunks)packages/project-builder-web/src/routes/data/models/edit.$key/service.tsx(2 hunks)packages/react-generators/src/generators/core/react-components/templates/src/components/circular-progress/circular-progress.tsx(2 hunks)packages/react-generators/src/generators/core/react-config/react-config.generator.ts(0 hunks)packages/tools/eslint-configs/react.js(1 hunks)packages/tools/eslint-configs/typescript.js(1 hunks)packages/tools/tsconfig.vite.lib.json(1 hunks)packages/ui-components/.storybook/preview.tsx(1 hunks)packages/ui-components/src/components/calendar/calendar.tsx(1 hunks)packages/ui-components/src/components/combobox/combobox.test.tsx(1 hunks)packages/utils/src/json/index.ts(1 hunks)packages/utils/src/json/json-deep-clone.ts(1 hunks)packages/utils/src/json/json-deep-clone.unit.test.ts(1 hunks)plugins/plugin-auth/src/auth/core/generators/auth-apollo/auth-apollo.generator.ts(1 hunks)plugins/plugin-auth/src/auth/core/generators/auth-apollo/index.ts(1 hunks)plugins/plugin-auth/src/auth/core/generators/auth-apollo/templates/session-error-link.ts(1 hunks)plugins/plugin-auth/src/auth/core/generators/auth-email-password/auth-email-password.generator.ts(1 hunks)plugins/plugin-auth/src/auth/core/generators/auth-module/auth-module.generator.ts(1 hunks)plugins/plugin-auth/src/auth/core/generators/auth-routes/auth-routes.generator.ts(1 hunks)plugins/plugin-auth/src/auth/core/generators/auth-routes/templates/routes/auth_/login.tsx(1 hunks)plugins/plugin-auth/src/auth/core/generators/auth-routes/templates/routes/auth_/register.tsx(1 hunks)plugins/plugin-auth/src/auth/core/generators/index.ts(1 hunks)plugins/plugin-auth/src/auth/core/generators/react-session/react-session.generator.ts(1 hunks)plugins/plugin-auth/src/auth/core/node.ts(2 hunks)plugins/plugin-auth/src/auth0/generators/react/react-auth0/react-auth0.generator.ts(1 hunks)plugins/plugin-auth/src/common/compiler/generator-creators.ts(1 hunks)plugins/plugin-auth/src/placeholder-auth/core/generators/placeholder-auth-module/auth-module.generator.ts(1 hunks)plugins/plugin-storage/package.json(1 hunks)plugins/plugin-storage/src/generators/fastify/prisma-file-transformer/prisma-file-transformer.generator.ts(1 hunks)plugins/plugin-storage/src/generators/fastify/storage-module/extractor.json(7 hunks)plugins/plugin-storage/src/generators/fastify/storage-module/storage-module.generator.ts(7 hunks)plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/adapters/index.ts(0 hunks)plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/adapters/s3.ts(3 hunks)plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/adapters/types.ts(0 hunks)plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/adapters/url.ts(1 hunks)plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/config/categories.config.ts(1 hunks)plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/constants/file-categories.ts(0 hunks)plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/schema/file-category.enum.ts(1 hunks)plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/schema/file-input.input-type.ts(1 hunks)plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/schema/presigned.mutations.ts(2 hunks)plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/schema/public-url.field.ts(1 hunks)plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/services/create-presigned-download-url.ts(3 hunks)plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/services/create-presigned-upload-url.ts(1 hunks)plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/services/download-file.ts(3 hunks)plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/services/upload-file.ts(1 hunks)plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/services/validate-file-input.ts(1 hunks)plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/services/validate-upload-input.ts(0 hunks)plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/types/adapter.ts(1 hunks)plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/types/file-category.ts(1 hunks)plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/utils/create-file-category.ts(1 hunks)plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/utils/mime.ts(1 hunks)plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/utils/mime.unit.test.ts(0 hunks)plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/utils/upload.ts(0 hunks)plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/utils/validate-file-upload-options.ts(1 hunks)plugins/plugin-storage/src/generators/react/upload-components/templates/src/components/file-input/file-input.tsx(7 hunks)plugins/plugin-storage/src/generators/react/upload-components/templates/src/components/file-input/upload.gql(1 hunks)plugins/plugin-storage/src/storage/core/schema/models.ts(2 hunks)plugins/plugin-storage/src/storage/transformers/components/file-transformer-form.tsx(1 hunks)
💤 Files with no reviewable changes (7)
- packages/react-generators/src/generators/core/react-config/react-config.generator.ts
- plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/utils/upload.ts
- plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/utils/mime.unit.test.ts
- plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/adapters/index.ts
- plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/services/validate-upload-input.ts
- plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/adapters/types.ts
- plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/constants/file-categories.ts
🧰 Additional context used
📓 Path-based instructions (14)
**/*.{ts,tsx}
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- CLAUDE.md
**/*
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- CLAUDE.md
**/*.tsx
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- CLAUDE.md
plugins/*/**/*.tsx
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- CLAUDE.md
{packages,plugins}/**/*.{ts,tsx}
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- .cursor/rules/code-style.mdc
plugins/plugin-*/**/*.tsx
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- plugins/CLAUDE.md
**/*.test.{ts,tsx}
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- .cursor/rules/tests.mdc
.changeset/*.md
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- CLAUDE.md
**/index.{ts,tsx}
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- CLAUDE.md
**/*.{unit,int}.test.ts
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- CLAUDE.md
**/*.test.ts
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- CLAUDE.md
{packages,plugins}/**/*.unit.test.ts
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- .cursor/rules/code-style.mdc
{packages,plugins}/**/*.{unit,int}.test.ts
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- .cursor/rules/code-style.mdc
**/*.unit.test.{ts,tsx}
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- .cursor/rules/tests.mdc
🧠 Learnings (51)
📓 Common learnings
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to plugins/*/**/*.tsx : In plugins, prefix all Tailwind classes with the plugin name (e.g., `auth-`, `storage-`)
plugins/plugin-storage/src/storage/transformers/components/file-transformer-form.tsx (14)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Node 16 module resolution - include file extensions in imports (`.js`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : If a particular interface or type is not exported, change the file so it is exported
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Include absolute paths in import statements via tsconfig paths (`@src/` is the alias for `src/`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Always use `.js` extensions in imports, even for TypeScript files
Learnt from: kingston
PR: halfdomelabs/baseplate#521
File: packages/react-generators/src/generators/admin/admin-crud-edit/admin-crud-edit.generator.ts:90-94
Timestamp: 2025-05-05T06:36:50.687Z
Learning: In this codebase, import paths can include `.ts` extensions, and the `resolveModuleSpecifier` function will handle them appropriately. There's no need to strip file extensions before passing paths to functions like `TsCodeUtils.importFragment`.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Extract repeated components into distinct functions or components where applicable
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Prefer functional programming patterns
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use camelCase for variables and functions
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use PascalCase for types and classes
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to plugins/*/**/*.tsx : In plugins, prefix all Tailwind classes with the plugin name (e.g., `auth-`, `storage-`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use TypeScript with strict type checking enabled
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: plugins/CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:58.487Z
Learning: Applies to plugins/plugin-*/**/*.tsx : All CSS classes used in `className` attributes within plugin components MUST be prefixed with the plugin name to avoid style conflicts.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : TypeScript with strict type checking
packages/ui-components/src/components/combobox/combobox.test.tsx (16)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{unit,int}.test.ts : Always import vitest globals explicitly (describe, it, expect)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.test.ts : Import test functions from 'vitest' (no globals)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.unit.test.ts : Unit tests use `.unit.test.ts` suffix
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.test.ts : Always import vitest globals explicitly (describe, it, expect)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.tsx : Use ShadCN-based components from `@baseplate-dev/ui-components` instead of creating custom ones
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/tests.mdc:0-0
Timestamp: 2025-06-30T11:52:28.745Z
Learning: Applies to **/*.unit.test.{ts,tsx} : Unit tests are colocated with source files using `.unit.test.ts` suffix
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.test.ts : Focus on testing public methods and behaviors, not implementation details
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.test.ts : Leverage TypeScript for type-safe mocking in tests
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/tests.mdc:0-0
Timestamp: 2025-06-30T11:52:28.745Z
Learning: Applies to **/*.int.test.{ts,tsx} : Integration tests use `.int.test.ts` suffix
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: We use vitest for unit testing
Learnt from: kingston
PR: halfdomelabs/baseplate#510
File: packages/project-builder-server/src/sync/conflict-file-monitor.test.ts:19-24
Timestamp: 2025-04-23T06:44:30.952Z
Learning: When testing file operations in this codebase, the pattern is to use Vitest automocks for 'node:fs' and 'node:fs/promises' (without explicit implementation replacement) while populating a virtual filesystem with vol.fromJSON() from memfs. File operations in tests are performed directly via vol.promises methods.
Learnt from: kingston
PR: halfdomelabs/baseplate#510
File: packages/project-builder-server/src/sync/conflict-file-monitor.test.ts:19-24
Timestamp: 2025-04-23T06:44:30.952Z
Learning: In this codebase, when testing file operations, Vitest's automocks for 'node:fs' and 'node:fs/promises' are used in conjunction with memfs, but without replacing the mock implementation explicitly in each test file. The virtual filesystem is populated using vol.fromJSON or similar methods, which works seamlessly with the automocks.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/tests.mdc:0-0
Timestamp: 2025-06-30T11:52:28.745Z
Learning: Applies to **/*.test.{ts,tsx} : For file system operations in tests, use memfs and mock 'node:fs' and 'node:fs/promises' with vi.mock
Learnt from: kingston
PR: halfdomelabs/baseplate#510
File: packages/project-builder-server/src/sync/conflict-file-monitor.test.ts:19-24
Timestamp: 2025-04-23T06:44:30.952Z
Learning: In the project-builder-server test suite, Vitest automocks for 'node:fs' and 'node:fs/promises' are already configured to use memfs without needing explicit implementation replacement in each test file.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to src/tests/**/*.{ts,tsx} : Test helpers are located in `src/tests/` directory
plugins/plugin-auth/src/auth0/generators/react/react-auth0/react-auth0.generator.ts (12)
Learnt from: kingston
PR: halfdomelabs/baseplate#428
File: packages/project-builder-server/src/sync/index.ts:5-5
Timestamp: 2025-01-23T09:12:46.178Z
Learning: Avoid importing directly from 'dist' directories. Instead, expose functionality through the package's public API and import from the main package entry point.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Extract repeated components into distinct functions or components where applicable
Learnt from: kingston
PR: halfdomelabs/baseplate#571
File: packages/core-generators/src/renderers/extractor/plugins/typed-templates-file.ts:102-106
Timestamp: 2025-06-11T18:31:22.247Z
Learning: For `templateExtractorBarrelExportPlugin.addGeneratedBarrelExport`, the generated barrel exports are written into `generated/index.ts`, therefore the `moduleSpecifier` must be specified relative to that file (e.g., `./typed-templates.js`), not the project root.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Include absolute paths in import statements via tsconfig paths (`@src/` is the alias for `src/`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{unit,int}.test.ts : Always import vitest globals explicitly (describe, it, expect)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to plugins/*/**/*.tsx : In plugins, prefix all Tailwind classes with the plugin name (e.g., `auth-`, `storage-`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Always include return types on top-level functions including React components (`React.ReactElement`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : If a particular interface or type is not exported, change the file so it is exported
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/index.{ts,tsx} : Prefer barrel exports e.g. `export * from './foo.js'` instead of individual named exports
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Prefer functional programming patterns
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use camelCase for variables and functions
.changeset/short-vans-judge.md (6)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
Learnt from: kingston
PR: halfdomelabs/baseplate#521
File: packages/react-generators/src/generators/admin/admin-components/admin-components.generator.ts:55-61
Timestamp: 2025-05-05T06:35:13.300Z
Learning: In generators, paths should be merged with forward slashes (/) only since JavaScript generated files use POSIX style separators. The system handles conversion to Windows style separators at later stages when writing out files.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/* : Use kebab-case for file names
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.tsx : Use ShadCN-based components from `@baseplate-dev/ui-components` instead of creating custom ones
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use camelCase for variables and functions
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use PascalCase for types and classes
plugins/plugin-auth/src/auth/core/generators/auth-module/auth-module.generator.ts (11)
Learnt from: kingston
PR: halfdomelabs/baseplate#571
File: packages/core-generators/src/renderers/extractor/plugins/typed-templates-file.ts:102-106
Timestamp: 2025-06-11T18:31:22.247Z
Learning: For `templateExtractorBarrelExportPlugin.addGeneratedBarrelExport`, the generated barrel exports are written into `generated/index.ts`, therefore the `moduleSpecifier` must be specified relative to that file (e.g., `./typed-templates.js`), not the project root.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{unit,int}.test.ts : Always import vitest globals explicitly (describe, it, expect)
Learnt from: kingston
PR: halfdomelabs/baseplate#428
File: packages/project-builder-server/src/sync/index.ts:5-5
Timestamp: 2025-01-23T09:12:46.178Z
Learning: Avoid importing directly from 'dist' directories. Instead, expose functionality through the package's public API and import from the main package entry point.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Node 16 module resolution - include file extensions in imports (`.js`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Include absolute paths in import statements via tsconfig paths (`@src/` is the alias for `src/`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : If a particular interface or type is not exported, change the file so it is exported
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.test.ts : Always import vitest globals explicitly (describe, it, expect)
Learnt from: kingston
PR: halfdomelabs/baseplate#505
File: packages/create-project/tsconfig.json:6-6
Timestamp: 2025-04-21T06:32:22.476Z
Learning: Since TypeScript 4.1, baseUrl is not required for paths mapping in tsconfig.json. Removing baseUrl and using explicit relative paths with "./" prefix (e.g., changing "@src/*": ["src/*"] to "@src/*": ["./src/*"]) prevents bare path imports from node_modules while maintaining path alias functionality.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/index.{ts,tsx} : Prefer barrel exports e.g. `export * from './foo.js'` instead of individual named exports
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Extract repeated components into distinct functions or components where applicable
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
plugins/plugin-auth/src/auth/core/generators/react-session/react-session.generator.ts (11)
Learnt from: kingston
PR: halfdomelabs/baseplate#571
File: packages/core-generators/src/renderers/extractor/plugins/typed-templates-file.ts:102-106
Timestamp: 2025-06-11T18:31:22.247Z
Learning: For `templateExtractorBarrelExportPlugin.addGeneratedBarrelExport`, the generated barrel exports are written into `generated/index.ts`, therefore the `moduleSpecifier` must be specified relative to that file (e.g., `./typed-templates.js`), not the project root.
Learnt from: kingston
PR: halfdomelabs/baseplate#428
File: packages/project-builder-server/src/sync/index.ts:5-5
Timestamp: 2025-01-23T09:12:46.178Z
Learning: Avoid importing directly from 'dist' directories. Instead, expose functionality through the package's public API and import from the main package entry point.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{unit,int}.test.ts : Always import vitest globals explicitly (describe, it, expect)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Include absolute paths in import statements via tsconfig paths (`@src/` is the alias for `src/`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Extract repeated components into distinct functions or components where applicable
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Node 16 module resolution - include file extensions in imports (`.js`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : If a particular interface or type is not exported, change the file so it is exported
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/index.{ts,tsx} : Prefer barrel exports e.g. `export * from './foo.js'` instead of individual named exports
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
Learnt from: kingston
PR: halfdomelabs/baseplate#592
File: plugins/plugin-auth/src/auth0/generators/react/auth0-hooks/templates/src/hooks/use-required-user-id.ts:1-2
Timestamp: 2025-07-07T18:24:17.522Z
Learning: Files under templates/** directories can use `// @ts-nocheck` because they are templates meant for code generation, not direct type checking.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.tsx : Use ShadCN-based components from `@baseplate-dev/ui-components` instead of creating custom ones
packages/ui-components/src/components/calendar/calendar.tsx (8)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.tsx : Use ShadCN-based components from `@baseplate-dev/ui-components` instead of creating custom ones
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
Learnt from: kingston
PR: halfdomelabs/baseplate#428
File: packages/project-builder-server/src/sync/index.ts:5-5
Timestamp: 2025-01-23T09:12:46.178Z
Learning: Avoid importing directly from 'dist' directories. Instead, expose functionality through the package's public API and import from the main package entry point.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Include absolute paths in import statements via tsconfig paths (`@src/` is the alias for `src/`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : If a particular interface or type is not exported, change the file so it is exported
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Node 16 module resolution - include file extensions in imports (`.js`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/index.{ts,tsx} : Prefer barrel exports e.g. `export * from './foo.js'` instead of individual named exports
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: plugins/CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:58.487Z
Learning: Applies to plugins/plugin-*/**/*.tsx : When using utility functions like `cn()`, all CSS classes passed to `cn()` in plugin components MUST be prefixed with the plugin name.
plugins/plugin-auth/src/auth/core/generators/auth-email-password/auth-email-password.generator.ts (6)
Learnt from: kingston
PR: halfdomelabs/baseplate#571
File: packages/core-generators/src/renderers/extractor/plugins/typed-templates-file.ts:102-106
Timestamp: 2025-06-11T18:31:22.247Z
Learning: For `templateExtractorBarrelExportPlugin.addGeneratedBarrelExport`, the generated barrel exports are written into `generated/index.ts`, therefore the `moduleSpecifier` must be specified relative to that file (e.g., `./typed-templates.js`), not the project root.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{unit,int}.test.ts : Always import vitest globals explicitly (describe, it, expect)
Learnt from: kingston
PR: halfdomelabs/baseplate#428
File: packages/project-builder-server/src/sync/index.ts:5-5
Timestamp: 2025-01-23T09:12:46.178Z
Learning: Avoid importing directly from 'dist' directories. Instead, expose functionality through the package's public API and import from the main package entry point.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Include absolute paths in import statements via tsconfig paths (`@src/` is the alias for `src/`)
Learnt from: kingston
PR: halfdomelabs/baseplate#592
File: plugins/plugin-auth/src/auth0/generators/react/auth0-hooks/templates/src/hooks/use-required-user-id.ts:1-2
Timestamp: 2025-07-07T18:24:17.522Z
Learning: Files under templates/** directories can use `// @ts-nocheck` because they are templates meant for code generation, not direct type checking.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
plugins/plugin-auth/src/auth/core/generators/auth-apollo/index.ts (9)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : If a particular interface or type is not exported, change the file so it is exported
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/index.{ts,tsx} : Prefer barrel exports e.g. `export * from './foo.js'` instead of individual named exports
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Extract repeated components into distinct functions or components where applicable
Learnt from: kingston
PR: halfdomelabs/baseplate#428
File: packages/project-builder-server/src/sync/index.ts:5-5
Timestamp: 2025-01-23T09:12:46.178Z
Learning: Avoid importing directly from 'dist' directories. Instead, expose functionality through the package's public API and import from the main package entry point.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{unit,int}.test.ts : Always import vitest globals explicitly (describe, it, expect)
Learnt from: kingston
PR: halfdomelabs/baseplate#571
File: packages/core-generators/src/renderers/extractor/plugins/typed-templates-file.ts:102-106
Timestamp: 2025-06-11T18:31:22.247Z
Learning: For `templateExtractorBarrelExportPlugin.addGeneratedBarrelExport`, the generated barrel exports are written into `generated/index.ts`, therefore the `moduleSpecifier` must be specified relative to that file (e.g., `./typed-templates.js`), not the project root.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Include absolute paths in import statements via tsconfig paths (`@src/` is the alias for `src/`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Node 16 module resolution - include file extensions in imports (`.js`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.test.ts : Import test functions from 'vitest' (no globals)
plugins/plugin-storage/package.json (3)
Learnt from: kingston
PR: halfdomelabs/baseplate#539
File: scripts/check-changesets.ts:70-79
Timestamp: 2025-05-08T12:56:11.723Z
Learning: In the check-changesets.ts script for monorepo validation, `npm pack ${pkg.name}@latest` is intentionally used to pack the most recently published version (not local changes) for comparison purposes to determine if changes require new changesets.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.tsx : Use ShadCN-based components from `@baseplate-dev/ui-components` instead of creating custom ones
packages/project-builder-lib/tsconfig.json (13)
Learnt from: kingston
PR: halfdomelabs/baseplate#505
File: packages/create-project/tsconfig.json:6-6
Timestamp: 2025-04-21T06:32:22.476Z
Learning: Since TypeScript 4.1, baseUrl is not required for paths mapping in tsconfig.json. Removing baseUrl and using explicit relative paths with "./" prefix (e.g., changing "@src/*": ["src/*"] to "@src/*": ["./src/*"]) prevents bare path imports from node_modules while maintaining path alias functionality.
Learnt from: kingston
PR: halfdomelabs/baseplate#505
File: packages/create-project/tsconfig.json:6-6
Timestamp: 2025-04-21T06:32:22.476Z
Learning: Since TypeScript 4.1, baseUrl is not required for paths mapping when using explicit relative paths (with "./"). Removing baseUrl from tsconfig.json while updating paths to use relative paths (e.g., changing "@src/*": ["src/*"] to "@src/*": ["./src/*"]) prevents bare path imports from node_modules while maintaining path alias functionality.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Node 16 module resolution - include file extensions in imports (`.js`)
Learnt from: kingston
PR: halfdomelabs/baseplate#562
File: plugins/plugin-auth/package.json:32-36
Timestamp: 2025-06-03T09:11:29.651Z
Learning: With TypeScript project references, TypeScript compilation is watched from the root level using "watch:tsc:root" script, so individual packages no longer need to include their "tsc:watch" scripts in their local "watch" commands. The local "tsc:watch" scripts are renamed from "watch:tsc" but are not meant to be run as part of the package's watch command since TypeScript watching is handled centrally at the workspace root.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : TypeScript with strict type checking
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Include absolute paths in import statements via tsconfig paths (`@src/` is the alias for `src/`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use TypeScript with strict type checking enabled
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : If a particular interface or type is not exported, change the file so it is exported
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
Learnt from: kingston
PR: halfdomelabs/baseplate#592
File: plugins/plugin-auth/src/auth0/generators/react/auth0-hooks/templates/src/hooks/use-required-user-id.ts:1-2
Timestamp: 2025-07-07T18:24:17.522Z
Learning: Files under templates/** directories can use `// @ts-nocheck` because they are templates meant for code generation, not direct type checking.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/tests.mdc:0-0
Timestamp: 2025-06-30T11:52:28.745Z
Learning: Applies to src/__mocks__/**/*.{ts,tsx} : Manual mocks are in `src/__mocks__/` directory
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to src/__mocks__/**/*.{ts,tsx} : Manual mocks are in `src/__mocks__/` directory
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/tests.mdc:0-0
Timestamp: 2025-06-30T11:52:28.745Z
Learning: Applies to **/*.unit.test.{ts,tsx} : Unit tests are colocated with source files using `.unit.test.ts` suffix
plugins/plugin-auth/src/placeholder-auth/core/generators/placeholder-auth-module/auth-module.generator.ts (6)
Learnt from: kingston
PR: halfdomelabs/baseplate#571
File: packages/core-generators/src/renderers/extractor/plugins/typed-templates-file.ts:102-106
Timestamp: 2025-06-11T18:31:22.247Z
Learning: For `templateExtractorBarrelExportPlugin.addGeneratedBarrelExport`, the generated barrel exports are written into `generated/index.ts`, therefore the `moduleSpecifier` must be specified relative to that file (e.g., `./typed-templates.js`), not the project root.
Learnt from: kingston
PR: halfdomelabs/baseplate#428
File: packages/project-builder-server/src/sync/index.ts:5-5
Timestamp: 2025-01-23T09:12:46.178Z
Learning: Avoid importing directly from 'dist' directories. Instead, expose functionality through the package's public API and import from the main package entry point.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{unit,int}.test.ts : Always import vitest globals explicitly (describe, it, expect)
Learnt from: kingston
PR: halfdomelabs/baseplate#505
File: packages/create-project/tsconfig.json:6-6
Timestamp: 2025-04-21T06:32:22.476Z
Learning: Since TypeScript 4.1, baseUrl is not required for paths mapping in tsconfig.json. Removing baseUrl and using explicit relative paths with "./" prefix (e.g., changing "@src/*": ["src/*"] to "@src/*": ["./src/*"]) prevents bare path imports from node_modules while maintaining path alias functionality.
Learnt from: kingston
PR: halfdomelabs/baseplate#592
File: plugins/plugin-auth/src/auth0/generators/react/auth0-hooks/templates/src/hooks/use-required-user-id.ts:1-2
Timestamp: 2025-07-07T18:24:17.522Z
Learning: Files under templates/** directories can use `// @ts-nocheck` because they are templates meant for code generation, not direct type checking.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
packages/core-generators/src/generators/node/eslint/templates/eslint.config.js (1)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use TypeScript with strict type checking enabled
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/services/download-file.ts (1)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : If a particular interface or type is not exported, change the file so it is exported
plugins/plugin-auth/src/auth/core/generators/auth-routes/templates/routes/auth_/register.tsx (3)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Extract repeated components into distinct functions or components where applicable
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Prefer functional programming patterns
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.tsx : Use ShadCN-based components from `@baseplate-dev/ui-components` instead of creating custom ones
plugins/plugin-auth/src/common/compiler/generator-creators.ts (10)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Include absolute paths in import statements via tsconfig paths (`@src/` is the alias for `src/`)
Learnt from: kingston
PR: halfdomelabs/baseplate#571
File: packages/core-generators/src/renderers/extractor/plugins/typed-templates-file.ts:102-106
Timestamp: 2025-06-11T18:31:22.247Z
Learning: For `templateExtractorBarrelExportPlugin.addGeneratedBarrelExport`, the generated barrel exports are written into `generated/index.ts`, therefore the `moduleSpecifier` must be specified relative to that file (e.g., `./typed-templates.js`), not the project root.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Node 16 module resolution - include file extensions in imports (`.js`)
Learnt from: kingston
PR: halfdomelabs/baseplate#505
File: packages/create-project/tsconfig.json:6-6
Timestamp: 2025-04-21T06:32:22.476Z
Learning: Since TypeScript 4.1, baseUrl is not required for paths mapping in tsconfig.json. Removing baseUrl and using explicit relative paths with "./" prefix (e.g., changing "@src/*": ["src/*"] to "@src/*": ["./src/*"]) prevents bare path imports from node_modules while maintaining path alias functionality.
Learnt from: kingston
PR: halfdomelabs/baseplate#505
File: packages/create-project/tsconfig.json:6-6
Timestamp: 2025-04-21T06:32:22.476Z
Learning: Since TypeScript 4.1, baseUrl is not required for paths mapping when using explicit relative paths (with "./"). Removing baseUrl from tsconfig.json while updating paths to use relative paths (e.g., changing "@src/*": ["src/*"] to "@src/*": ["./src/*"]) prevents bare path imports from node_modules while maintaining path alias functionality.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : If a particular interface or type is not exported, change the file so it is exported
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{unit,int}.test.ts : Always import vitest globals explicitly (describe, it, expect)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Extract repeated components into distinct functions or components where applicable
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to plugins/*/**/*.tsx : In plugins, prefix all Tailwind classes with the plugin name (e.g., `auth-`, `storage-`)
plugins/plugin-auth/src/auth/core/generators/auth-routes/templates/routes/auth_/login.tsx (3)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Extract repeated components into distinct functions or components where applicable
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Prefer functional programming patterns
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.tsx : Use ShadCN-based components from `@baseplate-dev/ui-components` instead of creating custom ones
packages/ui-components/.storybook/preview.tsx (10)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Node 16 module resolution - include file extensions in imports (`.js`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Always use `.js` extensions in imports, even for TypeScript files
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.tsx : Use ShadCN-based components from `@baseplate-dev/ui-components` instead of creating custom ones
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : If a particular interface or type is not exported, change the file so it is exported
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Include absolute paths in import statements via tsconfig paths (`@src/` is the alias for `src/`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{unit,int}.test.ts : Always import vitest globals explicitly (describe, it, expect)
Learnt from: kingston
PR: halfdomelabs/baseplate#521
File: packages/react-generators/src/generators/admin/admin-crud-edit/admin-crud-edit.generator.ts:90-94
Timestamp: 2025-05-05T06:36:50.687Z
Learning: In this codebase, import paths can include `.ts` extensions, and the `resolveModuleSpecifier` function will handle them appropriately. There's no need to strip file extensions before passing paths to functions like `TsCodeUtils.importFragment`.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : TypeScript with strict type checking
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.test.ts : Always import vitest globals explicitly (describe, it, expect)
plugins/plugin-auth/src/auth/core/node.ts (7)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Node 16 module resolution - include file extensions in imports (`.js`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Include absolute paths in import statements via tsconfig paths (`@src/` is the alias for `src/`)
Learnt from: kingston
PR: halfdomelabs/baseplate#428
File: packages/project-builder-server/src/sync/index.ts:5-5
Timestamp: 2025-01-23T09:12:46.178Z
Learning: Avoid importing directly from 'dist' directories. Instead, expose functionality through the package's public API and import from the main package entry point.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{unit,int}.test.ts : Always import vitest globals explicitly (describe, it, expect)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to plugins/*/**/*.tsx : In plugins, prefix all Tailwind classes with the plugin name (e.g., `auth-`, `storage-`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
Learnt from: kingston
PR: halfdomelabs/baseplate#571
File: packages/core-generators/src/renderers/extractor/plugins/typed-templates-file.ts:102-106
Timestamp: 2025-06-11T18:31:22.247Z
Learning: For `templateExtractorBarrelExportPlugin.addGeneratedBarrelExport`, the generated barrel exports are written into `generated/index.ts`, therefore the `moduleSpecifier` must be specified relative to that file (e.g., `./typed-templates.js`), not the project root.
plugins/plugin-auth/src/auth/core/generators/auth-routes/auth-routes.generator.ts (12)
Learnt from: kingston
PR: halfdomelabs/baseplate#571
File: packages/core-generators/src/renderers/extractor/plugins/typed-templates-file.ts:102-106
Timestamp: 2025-06-11T18:31:22.247Z
Learning: For `templateExtractorBarrelExportPlugin.addGeneratedBarrelExport`, the generated barrel exports are written into `generated/index.ts`, therefore the `moduleSpecifier` must be specified relative to that file (e.g., `./typed-templates.js`), not the project root.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Include absolute paths in import statements via tsconfig paths (`@src/` is the alias for `src/`)
Learnt from: kingston
PR: halfdomelabs/baseplate#428
File: packages/project-builder-server/src/sync/index.ts:5-5
Timestamp: 2025-01-23T09:12:46.178Z
Learning: Avoid importing directly from 'dist' directories. Instead, expose functionality through the package's public API and import from the main package entry point.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{unit,int}.test.ts : Always import vitest globals explicitly (describe, it, expect)
Learnt from: kingston
PR: halfdomelabs/baseplate#505
File: packages/create-project/tsconfig.json:6-6
Timestamp: 2025-04-21T06:32:22.476Z
Learning: Since TypeScript 4.1, baseUrl is not required for paths mapping in tsconfig.json. Removing baseUrl and using explicit relative paths with "./" prefix (e.g., changing "@src/*": ["src/*"] to "@src/*": ["./src/*"]) prevents bare path imports from node_modules while maintaining path alias functionality.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Node 16 module resolution - include file extensions in imports (`.js`)
Learnt from: kingston
PR: halfdomelabs/baseplate#505
File: packages/create-project/tsconfig.json:6-6
Timestamp: 2025-04-21T06:32:22.476Z
Learning: Since TypeScript 4.1, baseUrl is not required for paths mapping when using explicit relative paths (with "./"). Removing baseUrl from tsconfig.json while updating paths to use relative paths (e.g., changing "@src/*": ["src/*"] to "@src/*": ["./src/*"]) prevents bare path imports from node_modules while maintaining path alias functionality.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : If a particular interface or type is not exported, change the file so it is exported
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Extract repeated components into distinct functions or components where applicable
Learnt from: kingston
PR: halfdomelabs/baseplate#592
File: plugins/plugin-auth/src/auth0/generators/react/auth0-hooks/templates/src/hooks/use-required-user-id.ts:1-2
Timestamp: 2025-07-07T18:24:17.522Z
Learning: Files under templates/** directories can use `// @ts-nocheck` because they are templates meant for code generation, not direct type checking.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
Learnt from: kingston
PR: halfdomelabs/baseplate#521
File: packages/react-generators/src/generators/admin/admin-components/admin-components.generator.ts:55-61
Timestamp: 2025-05-05T06:35:13.300Z
Learning: In generators, paths should be merged with forward slashes (/) only since JavaScript generated files use POSIX style separators. The system handles conversion to Windows style separators at later stages when writing out files.
packages/project-builder-web/src/routes/data/models/edit.$key/index.tsx (2)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use camelCase for variables and functions
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
packages/tools/eslint-configs/typescript.js (10)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : TypeScript with strict type checking
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use TypeScript with strict type checking enabled
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use PascalCase for types and classes
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use camelCase for variables and functions
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Use camelCase for variables/functions, PascalCase for types/classes
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : If a particular interface or type is not exported, change the file so it is exported
Learnt from: kingston
PR: halfdomelabs/baseplate#505
File: packages/create-project/tsconfig.json:6-6
Timestamp: 2025-04-21T06:32:22.476Z
Learning: Since TypeScript 4.1, baseUrl is not required for paths mapping in tsconfig.json. Removing baseUrl and using explicit relative paths with "./" prefix (e.g., changing "@src/*": ["src/*"] to "@src/*": ["./src/*"]) prevents bare path imports from node_modules while maintaining path alias functionality.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Always use `.js` extensions in imports, even for TypeScript files
Learnt from: kingston
PR: halfdomelabs/baseplate#592
File: plugins/plugin-auth/src/auth0/generators/react/auth0-hooks/templates/src/hooks/use-required-user-id.ts:1-2
Timestamp: 2025-07-07T18:24:17.522Z
Learning: Files under templates/** directories can use `// @ts-nocheck` because they are templates meant for code generation, not direct type checking.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Node 16 module resolution - include file extensions in imports (`.js`)
plugins/plugin-auth/src/auth/core/generators/index.ts (12)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : If a particular interface or type is not exported, change the file so it is exported
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/index.{ts,tsx} : Prefer barrel exports e.g. `export * from './foo.js'` instead of individual named exports
Learnt from: kingston
PR: halfdomelabs/baseplate#571
File: packages/core-generators/src/renderers/extractor/plugins/typed-templates-file.ts:102-106
Timestamp: 2025-06-11T18:31:22.247Z
Learning: For `templateExtractorBarrelExportPlugin.addGeneratedBarrelExport`, the generated barrel exports are written into `generated/index.ts`, therefore the `moduleSpecifier` must be specified relative to that file (e.g., `./typed-templates.js`), not the project root.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Node 16 module resolution - include file extensions in imports (`.js`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{unit,int}.test.ts : Always import vitest globals explicitly (describe, it, expect)
Learnt from: kingston
PR: halfdomelabs/baseplate#428
File: packages/project-builder-server/src/sync/index.ts:5-5
Timestamp: 2025-01-23T09:12:46.178Z
Learning: Avoid importing directly from 'dist' directories. Instead, expose functionality through the package's public API and import from the main package entry point.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Extract repeated components into distinct functions or components where applicable
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Include absolute paths in import statements via tsconfig paths (`@src/` is the alias for `src/`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to plugins/*/**/*.tsx : In plugins, prefix all Tailwind classes with the plugin name (e.g., `auth-`, `storage-`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.test.ts : Always import vitest globals explicitly (describe, it, expect)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.test.ts : Import test functions from 'vitest' (no globals)
packages/utils/src/json/index.ts (15)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : If a particular interface or type is not exported, change the file so it is exported
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/index.{ts,tsx} : Prefer barrel exports e.g. `export * from './foo.js'` instead of individual named exports
Learnt from: kingston
PR: halfdomelabs/baseplate#428
File: packages/project-builder-server/src/sync/index.ts:5-5
Timestamp: 2025-01-23T09:12:46.178Z
Learning: Avoid importing directly from 'dist' directories. Instead, expose functionality through the package's public API and import from the main package entry point.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Node 16 module resolution - include file extensions in imports (`.js`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{unit,int}.test.ts : Always import vitest globals explicitly (describe, it, expect)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Include absolute paths in import statements via tsconfig paths (`@src/` is the alias for `src/`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Extract repeated components into distinct functions or components where applicable
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.test.ts : Always import vitest globals explicitly (describe, it, expect)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Sort imports by group: external libs first, then local imports
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Prefer functional programming patterns
Learnt from: kingston
PR: halfdomelabs/baseplate#539
File: scripts/check-changesets.ts:10-13
Timestamp: 2025-05-08T12:56:59.222Z
Learning: Node.js 22.0.0 and later versions include both `glob` and `globSync` functionality in the core `node:fs` module, making `import { promises as fs, globSync } from 'node:fs';` valid syntax.
Learnt from: kingston
PR: halfdomelabs/baseplate#539
File: scripts/check-changesets.ts:10-13
Timestamp: 2025-05-08T12:56:59.222Z
Learning: Node.js 20.12.0 and above include `globSync` in the core `node:fs` module, so `import { promises as fs, globSync } from 'node:fs';` is valid syntax in projects using these Node.js versions.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.test.ts : Import test functions from 'vitest' (no globals)
Learnt from: kingston
PR: halfdomelabs/baseplate#511
File: packages/project-builder-server/src/service/builder-service.ts:19-20
Timestamp: 2025-04-23T16:41:00.321Z
Learning: The `execa` package exports `parseCommandString` as part of its public API in the version used by the project.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
packages/tools/tsconfig.vite.lib.json (16)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Node 16 module resolution - include file extensions in imports (`.js`)
Learnt from: kingston
PR: halfdomelabs/baseplate#505
File: packages/create-project/tsconfig.json:6-6
Timestamp: 2025-04-21T06:32:22.476Z
Learning: Since TypeScript 4.1, baseUrl is not required for paths mapping in tsconfig.json. Removing baseUrl and using explicit relative paths with "./" prefix (e.g., changing "@src/*": ["src/*"] to "@src/*": ["./src/*"]) prevents bare path imports from node_modules while maintaining path alias functionality.
Learnt from: kingston
PR: halfdomelabs/baseplate#505
File: packages/create-project/tsconfig.json:6-6
Timestamp: 2025-04-21T06:32:22.476Z
Learning: Since TypeScript 4.1, baseUrl is not required for paths mapping when using explicit relative paths (with "./"). Removing baseUrl from tsconfig.json while updating paths to use relative paths (e.g., changing "@src/*": ["src/*"] to "@src/*": ["./src/*"]) prevents bare path imports from node_modules while maintaining path alias functionality.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : TypeScript with strict type checking
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use TypeScript with strict type checking enabled
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{unit,int}.test.ts : Always import vitest globals explicitly (describe, it, expect)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Include absolute paths in import statements via tsconfig paths (`@src/` is the alias for `src/`)
Learnt from: kingston
PR: halfdomelabs/baseplate#562
File: plugins/plugin-auth/package.json:32-36
Timestamp: 2025-06-03T09:11:29.651Z
Learning: With TypeScript project references, TypeScript compilation is watched from the root level using "watch:tsc:root" script, so individual packages no longer need to include their "tsc:watch" scripts in their local "watch" commands. The local "tsc:watch" scripts are renamed from "watch:tsc" but are not meant to be run as part of the package's watch command since TypeScript watching is handled centrally at the workspace root.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.test.ts : Always import vitest globals explicitly (describe, it, expect)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.test.ts : Import test functions from 'vitest' (no globals)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Always use `.js` extensions in imports, even for TypeScript files
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Always include return types on top-level functions including React components (`React.ReactElement`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Sort imports by group: external libs first, then local imports
Learnt from: kingston
PR: halfdomelabs/baseplate#598
File: packages/fastify-generators/src/generators/yoga/yoga-plugin/templates/src/plugins/graphql/index.ts:18-18
Timestamp: 2025-07-10T06:49:07.714Z
Learning: In React projects using Vite, keep the .env file naming convention as .env.development, .env.production, etc. even when internal application environment values use shorter abbreviations like 'dev', 'stage', 'prod'. This follows Vite's mode conventions.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.tsx : Use ShadCN-based components from `@baseplate-dev/ui-components` instead of creating custom ones
plugins/plugin-storage/src/generators/fastify/prisma-file-transformer/prisma-file-transformer.generator.ts (1)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use camelCase for variables and functions
packages/core-generators/src/generators/node/eslint/react-rules.ts (12)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use camelCase for variables and functions
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use PascalCase for types and classes
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Use camelCase for variables/functions, PascalCase for types/classes
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: plugins/CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:58.487Z
Learning: Applies to plugins/plugin-*/**/*.tsx : When using utility functions like `cn()`, all CSS classes passed to `cn()` in plugin components MUST be prefixed with the plugin name.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.unit.test.ts : Unit tests use `.unit.test.ts` suffix
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/* : Use kebab-case for file names
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to plugins/*/**/*.tsx : In plugins, prefix all Tailwind classes with the plugin name (e.g., `auth-`, `storage-`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: plugins/CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:58.487Z
Learning: Applies to plugins/plugin-*/**/*.tsx : All CSS classes used in `className` attributes within plugin components MUST be prefixed with the plugin name to avoid style conflicts.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : TypeScript with strict type checking
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Prefer functional programming patterns
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use TypeScript with strict type checking enabled
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Always use `.js` extensions in imports, even for TypeScript files
packages/tools/eslint-configs/react.js (15)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use camelCase for variables and functions
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use PascalCase for types and classes
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to plugins/*/**/*.tsx : In plugins, prefix all Tailwind classes with the plugin name (e.g., `auth-`, `storage-`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.unit.test.ts : Unit tests use `.unit.test.ts` suffix
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: plugins/CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:58.487Z
Learning: Applies to plugins/plugin-*/**/*.tsx : When using utility functions like `cn()`, all CSS classes passed to `cn()` in plugin components MUST be prefixed with the plugin name.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Use camelCase for variables/functions, PascalCase for types/classes
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: plugins/CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:58.487Z
Learning: Applies to plugins/plugin-*/**/*.tsx : All CSS classes used in `className` attributes within plugin components MUST be prefixed with the plugin name to avoid style conflicts.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : If a particular interface or type is not exported, change the file so it is exported
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Node 16 module resolution - include file extensions in imports (`.js`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Include absolute paths in import statements via tsconfig paths (`@src/` is the alias for `src/`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/* : Use kebab-case for file names
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : TypeScript with strict type checking
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use TypeScript with strict type checking enabled
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Prefer functional programming patterns
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/tests.mdc:0-0
Timestamp: 2025-06-30T11:52:28.745Z
Learning: Applies to **/*.int.test.{ts,tsx} : Integration tests use `.int.test.ts` suffix
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/schema/public-url.field.ts (3)
Learnt from: kingston
PR: halfdomelabs/baseplate#505
File: packages/create-project/tsconfig.json:6-6
Timestamp: 2025-04-21T06:32:22.476Z
Learning: Since TypeScript 4.1, baseUrl is not required for paths mapping in tsconfig.json. Removing baseUrl and using explicit relative paths with "./" prefix (e.g., changing "@src/*": ["src/*"] to "@src/*": ["./src/*"]) prevents bare path imports from node_modules while maintaining path alias functionality.
Learnt from: kingston
PR: halfdomelabs/baseplate#505
File: packages/create-project/tsconfig.json:6-6
Timestamp: 2025-04-21T06:32:22.476Z
Learning: Since TypeScript 4.1, baseUrl is not required for paths mapping when using explicit relative paths (with "./"). Removing baseUrl from tsconfig.json while updating paths to use relative paths (e.g., changing "@src/*": ["src/*"] to "@src/*": ["./src/*"]) prevents bare path imports from node_modules while maintaining path alias functionality.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : If a particular interface or type is not exported, change the file so it is exported
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/schema/file-category.enum.ts (5)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : If a particular interface or type is not exported, change the file so it is exported
Learnt from: kingston
PR: halfdomelabs/baseplate#592
File: plugins/plugin-auth/src/auth0/generators/react/auth0-hooks/templates/src/hooks/use-required-user-id.ts:1-2
Timestamp: 2025-07-07T18:24:17.522Z
Learning: Files under templates/** directories can use `// @ts-nocheck` because they are templates meant for code generation, not direct type checking.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : TypeScript with strict type checking
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use TypeScript with strict type checking enabled
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Node 16 module resolution - include file extensions in imports (`.js`)
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/utils/create-file-category.ts (2)
Learnt from: kingston
PR: halfdomelabs/baseplate#571
File: packages/core-generators/src/renderers/extractor/plugins/typed-templates-file.ts:102-106
Timestamp: 2025-06-11T18:31:22.247Z
Learning: For `templateExtractorBarrelExportPlugin.addGeneratedBarrelExport`, the generated barrel exports are written into `generated/index.ts`, therefore the `moduleSpecifier` must be specified relative to that file (e.g., `./typed-templates.js`), not the project root.
Learnt from: kingston
PR: halfdomelabs/baseplate#592
File: plugins/plugin-auth/src/auth0/generators/react/auth0-hooks/templates/src/hooks/use-required-user-id.ts:1-2
Timestamp: 2025-07-07T18:24:17.522Z
Learning: Files under templates/** directories can use `// @ts-nocheck` because they are templates meant for code generation, not direct type checking.
packages/react-generators/src/generators/core/react-components/templates/src/components/circular-progress/circular-progress.tsx (2)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.tsx : Use ShadCN-based components from `@baseplate-dev/ui-components` instead of creating custom ones
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
packages/utils/src/json/json-deep-clone.unit.test.ts (15)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.test.ts : Include tests for error conditions and edge cases
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{unit,int}.test.ts : Always import vitest globals explicitly (describe, it, expect)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.test.ts : Leverage TypeScript for type-safe mocking in tests
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.test.ts : Each test should verify one specific behavior
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.test.ts : Each test should be independent and not rely on others
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.test.ts : Focus on testing public methods and behaviors, not implementation details
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.unit.test.ts : Unit tests use `.unit.test.ts` suffix
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{unit,int}.test.ts : Unit tests use `.unit.test.ts` suffix, integration tests use `.int.test.ts`
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.test.ts : Import test functions from 'vitest' (no globals)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Colocate tests with implementation files, e.g. for `./utils.ts`, add the test to `./utils.unit.test.ts`
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.test.ts : Always import vitest globals explicitly (describe, it, expect)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: We use vitest for unit testing
Learnt from: kingston
PR: halfdomelabs/baseplate#510
File: packages/project-builder-server/src/sync/conflict-file-monitor.test.ts:19-24
Timestamp: 2025-04-23T06:44:30.952Z
Learning: When testing file operations in this codebase, the pattern is to use Vitest automocks for 'node:fs' and 'node:fs/promises' (without explicit implementation replacement) while populating a virtual filesystem with vol.fromJSON() from memfs. File operations in tests are performed directly via vol.promises methods.
Learnt from: kingston
PR: halfdomelabs/baseplate#510
File: packages/project-builder-server/src/sync/conflict-file-monitor.test.ts:19-24
Timestamp: 2025-04-23T06:44:30.952Z
Learning: In this codebase, when testing file operations, Vitest's automocks for 'node:fs' and 'node:fs/promises' are used in conjunction with memfs, but without replacing the mock implementation explicitly in each test file. The virtual filesystem is populated using vol.fromJSON or similar methods, which works seamlessly with the automocks.
Learnt from: kingston
PR: halfdomelabs/baseplate#510
File: packages/project-builder-server/src/sync/conflict-file-monitor.test.ts:19-24
Timestamp: 2025-04-23T06:44:30.952Z
Learning: In the project-builder-server test suite, Vitest automocks for 'node:fs' and 'node:fs/promises' are already configured to use memfs without needing explicit implementation replacement in each test file.
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/schema/file-input.input-type.ts (1)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : If a particular interface or type is not exported, change the file so it is exported
packages/project-builder-web/src/routes/data/models/edit.$key/-components/fields/model-field-form.tsx (1)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Extract repeated components into distinct functions or components where applicable
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/services/create-presigned-download-url.ts (4)
Learnt from: kingston
PR: halfdomelabs/baseplate#505
File: packages/create-project/tsconfig.json:6-6
Timestamp: 2025-04-21T06:32:22.476Z
Learning: Since TypeScript 4.1, baseUrl is not required for paths mapping in tsconfig.json. Removing baseUrl and using explicit relative paths with "./" prefix (e.g., changing "@src/*": ["src/*"] to "@src/*": ["./src/*"]) prevents bare path imports from node_modules while maintaining path alias functionality.
Learnt from: kingston
PR: halfdomelabs/baseplate#428
File: packages/project-builder-server/src/sync/index.ts:5-5
Timestamp: 2025-01-23T09:12:46.178Z
Learning: Avoid importing directly from 'dist' directories. Instead, expose functionality through the package's public API and import from the main package entry point.
Learnt from: kingston
PR: halfdomelabs/baseplate#505
File: packages/create-project/tsconfig.json:6-6
Timestamp: 2025-04-21T06:32:22.476Z
Learning: Since TypeScript 4.1, baseUrl is not required for paths mapping when using explicit relative paths (with "./"). Removing baseUrl from tsconfig.json while updating paths to use relative paths (e.g., changing "@src/*": ["src/*"] to "@src/*": ["./src/*"]) prevents bare path imports from node_modules while maintaining path alias functionality.
Learnt from: kingston
PR: halfdomelabs/baseplate#539
File: scripts/check-changesets.ts:10-13
Timestamp: 2025-05-08T12:56:59.222Z
Learning: Node.js 20.12.0 and above include `globSync` in the core `node:fs` module, so `import { promises as fs, globSync } from 'node:fs';` is valid syntax in projects using these Node.js versions.
packages/project-builder-web/src/routes/data/models/-hooks/use-edited-model-config.tsx (4)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Prefer functional programming patterns
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Extract repeated components into distinct functions or components where applicable
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.tsx : Use ShadCN-based components from `@baseplate-dev/ui-components` instead of creating custom ones
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/adapters/url.ts (4)
Learnt from: kingston
PR: halfdomelabs/baseplate#505
File: packages/create-project/tsconfig.json:6-6
Timestamp: 2025-04-21T06:32:22.476Z
Learning: Since TypeScript 4.1, baseUrl is not required for paths mapping in tsconfig.json. Removing baseUrl and using explicit relative paths with "./" prefix (e.g., changing "@src/*": ["src/*"] to "@src/*": ["./src/*"]) prevents bare path imports from node_modules while maintaining path alias functionality.
Learnt from: kingston
PR: halfdomelabs/baseplate#505
File: packages/create-project/tsconfig.json:6-6
Timestamp: 2025-04-21T06:32:22.476Z
Learning: Since TypeScript 4.1, baseUrl is not required for paths mapping when using explicit relative paths (with "./"). Removing baseUrl from tsconfig.json while updating paths to use relative paths (e.g., changing "@src/*": ["src/*"] to "@src/*": ["./src/*"]) prevents bare path imports from node_modules while maintaining path alias functionality.
Learnt from: kingston
PR: halfdomelabs/baseplate#510
File: packages/project-builder-server/src/sync/conflict-file-monitor.test.ts:19-24
Timestamp: 2025-04-23T06:44:30.952Z
Learning: When testing file operations in this codebase, the pattern is to use Vitest automocks for 'node:fs' and 'node:fs/promises' (without explicit implementation replacement) while populating a virtual filesystem with vol.fromJSON() from memfs. File operations in tests are performed directly via vol.promises methods.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/tests.mdc:0-0
Timestamp: 2025-06-30T11:52:28.745Z
Learning: Applies to **/*.test.{ts,tsx} : For file system operations in tests, use memfs and mock 'node:fs' and 'node:fs/promises' with vi.mock
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/types/file-category.ts (2)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : If a particular interface or type is not exported, change the file so it is exported
Learnt from: kingston
PR: halfdomelabs/baseplate#592
File: plugins/plugin-auth/src/auth0/generators/react/auth0-hooks/templates/src/hooks/use-required-user-id.ts:1-2
Timestamp: 2025-07-07T18:24:17.522Z
Learning: Files under templates/** directories can use `// @ts-nocheck` because they are templates meant for code generation, not direct type checking.
plugins/plugin-auth/src/auth/core/generators/auth-apollo/auth-apollo.generator.ts (1)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
packages/project-builder-web/src/routes/data/models/-hooks/use-model-form.ts (3)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Prefer functional programming patterns
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.tsx : Use ShadCN-based components from `@baseplate-dev/ui-components` instead of creating custom ones
.changeset/dull-words-fold.md (1)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to .changeset/*.md : If you are adding a new feature or changing an existing feature, add a new Changeset in the `.changeset/` directory
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/config/categories.config.ts (10)
Learnt from: kingston
PR: halfdomelabs/baseplate#592
File: plugins/plugin-auth/src/auth0/generators/react/auth0-hooks/templates/src/hooks/use-required-user-id.ts:1-2
Timestamp: 2025-07-07T18:24:17.522Z
Learning: Files under templates/** directories can use `// @ts-nocheck` because they are templates meant for code generation, not direct type checking.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : If a particular interface or type is not exported, change the file so it is exported
Learnt from: kingston
PR: halfdomelabs/baseplate#571
File: packages/core-generators/src/renderers/extractor/plugins/typed-templates-file.ts:102-106
Timestamp: 2025-06-11T18:31:22.247Z
Learning: For `templateExtractorBarrelExportPlugin.addGeneratedBarrelExport`, the generated barrel exports are written into `generated/index.ts`, therefore the `moduleSpecifier` must be specified relative to that file (e.g., `./typed-templates.js`), not the project root.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Node 16 module resolution - include file extensions in imports (`.js`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Extract repeated components into distinct functions or components where applicable
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Prefer functional programming patterns
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use TypeScript with strict type checking enabled
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : TypeScript with strict type checking
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use PascalCase for types and classes
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{unit,int}.test.ts : Always import vitest globals explicitly (describe, it, expect)
packages/project-builder-web/src/routes/data/models/-components/new-model-dialog.tsx (3)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Extract repeated components into distinct functions or components where applicable
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.tsx : Use ShadCN-based components from `@baseplate-dev/ui-components` instead of creating custom ones
plugins/plugin-storage/src/generators/react/upload-components/templates/src/components/file-input/file-input.tsx (8)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : If a particular interface or type is not exported, change the file so it is exported
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use camelCase for variables and functions
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to plugins/*/**/*.tsx : In plugins, prefix all Tailwind classes with the plugin name (e.g., `auth-`, `storage-`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use PascalCase for types and classes
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Extract repeated components into distinct functions or components where applicable
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.tsx : Use ShadCN-based components from `@baseplate-dev/ui-components` instead of creating custom ones
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: plugins/CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:58.487Z
Learning: Applies to plugins/plugin-*/**/*.tsx : All CSS classes used in `className` attributes within plugin components MUST be prefixed with the plugin name to avoid style conflicts.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Use camelCase for variables/functions, PascalCase for types/classes
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/utils/mime.ts (1)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Node 16 module resolution - include file extensions in imports (`.js`)
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/utils/validate-file-upload-options.ts (2)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Node 16 module resolution - include file extensions in imports (`.js`)
Learnt from: kingston
PR: halfdomelabs/baseplate#592
File: plugins/plugin-auth/src/auth0/generators/react/auth0-hooks/templates/src/hooks/use-required-user-id.ts:1-2
Timestamp: 2025-07-07T18:24:17.522Z
Learning: Files under templates/** directories can use `// @ts-nocheck` because they are templates meant for code generation, not direct type checking.
plugins/plugin-storage/src/generators/fastify/storage-module/storage-module.generator.ts (14)
Learnt from: kingston
PR: halfdomelabs/baseplate#571
File: packages/core-generators/src/renderers/extractor/plugins/typed-templates-file.ts:102-106
Timestamp: 2025-06-11T18:31:22.247Z
Learning: For `templateExtractorBarrelExportPlugin.addGeneratedBarrelExport`, the generated barrel exports are written into `generated/index.ts`, therefore the `moduleSpecifier` must be specified relative to that file (e.g., `./typed-templates.js`), not the project root.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
Learnt from: kingston
PR: halfdomelabs/baseplate#521
File: plugins/baseplate-plugin-storage/src/generators/react/upload-components/upload-components.generator.ts:108-112
Timestamp: 2025-05-05T06:37:43.106Z
Learning: The template extractor in the baseplate codebase can automatically infer and determine the necessary import map providers for certain templates, making explicit specification of importMapProviders unnecessary in those cases.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Extract repeated components into distinct functions or components where applicable
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{unit,int}.test.ts : Always import vitest globals explicitly (describe, it, expect)
Learnt from: kingston
PR: halfdomelabs/baseplate#521
File: packages/react-generators/src/generators/admin/admin-crud-edit/admin-crud-edit.generator.ts:90-94
Timestamp: 2025-05-05T06:36:50.687Z
Learning: In this codebase, import paths can include `.ts` extensions, and the `resolveModuleSpecifier` function will handle them appropriately. There's no need to strip file extensions before passing paths to functions like `TsCodeUtils.importFragment`.
Learnt from: kingston
PR: halfdomelabs/baseplate#428
File: packages/project-builder-server/src/sync/index.ts:5-5
Timestamp: 2025-01-23T09:12:46.178Z
Learning: Avoid importing directly from 'dist' directories. Instead, expose functionality through the package's public API and import from the main package entry point.
Learnt from: kingston
PR: halfdomelabs/baseplate#521
File: packages/react-generators/src/generators/admin/admin-crud-list/admin-crud-list.generator.ts:163-166
Timestamp: 2025-05-05T06:37:51.001Z
Learning: For certain templates in the codebase, the `importMapProviders` property is not explicitly required as the template extractor will automatically determine and infer the necessary import map providers.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Prefer functional programming patterns
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Node 16 module resolution - include file extensions in imports (`.js`)
Learnt from: kingston
PR: halfdomelabs/baseplate#510
File: packages/project-builder-server/src/sync/conflict-file-monitor.test.ts:19-24
Timestamp: 2025-04-23T06:44:30.952Z
Learning: In the project-builder-server test suite, Vitest automocks for 'node:fs' and 'node:fs/promises' are already configured to use memfs without needing explicit implementation replacement in each test file.
Learnt from: kingston
PR: halfdomelabs/baseplate#510
File: packages/project-builder-server/src/sync/conflict-file-monitor.test.ts:19-24
Timestamp: 2025-04-23T06:44:30.952Z
Learning: When testing file operations in this codebase, the pattern is to use Vitest automocks for 'node:fs' and 'node:fs/promises' (without explicit implementation replacement) while populating a virtual filesystem with vol.fromJSON() from memfs. File operations in tests are performed directly via vol.promises methods.
Learnt from: kingston
PR: halfdomelabs/baseplate#592
File: plugins/plugin-auth/src/auth0/generators/react/auth0-hooks/templates/src/hooks/use-required-user-id.ts:1-2
Timestamp: 2025-07-07T18:24:17.522Z
Learning: Files under templates/** directories can use `// @ts-nocheck` because they are templates meant for code generation, not direct type checking.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Include absolute paths in import statements via tsconfig paths (`@src/` is the alias for `src/`)
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/types/adapter.ts (1)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : If a particular interface or type is not exported, change the file so it is exported
plugins/plugin-storage/src/generators/fastify/storage-module/extractor.json (22)
Learnt from: kingston
PR: halfdomelabs/baseplate#571
File: packages/core-generators/src/renderers/extractor/plugins/typed-templates-file.ts:102-106
Timestamp: 2025-06-11T18:31:22.247Z
Learning: For `templateExtractorBarrelExportPlugin.addGeneratedBarrelExport`, the generated barrel exports are written into `generated/index.ts`, therefore the `moduleSpecifier` must be specified relative to that file (e.g., `./typed-templates.js`), not the project root.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Extract repeated components into distinct functions or components where applicable
Learnt from: kingston
PR: halfdomelabs/baseplate#592
File: plugins/plugin-auth/src/auth0/generators/react/auth0-hooks/templates/src/hooks/use-required-user-id.ts:1-2
Timestamp: 2025-07-07T18:24:17.522Z
Learning: Files under templates/** directories can use `// @ts-nocheck` because they are templates meant for code generation, not direct type checking.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use camelCase for variables and functions
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Prefer functional programming patterns
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Node 16 module resolution - include file extensions in imports (`.js`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use PascalCase for types and classes
Learnt from: kingston
PR: halfdomelabs/baseplate#521
File: packages/react-generators/src/generators/admin/admin-crud-list/admin-crud-list.generator.ts:163-166
Timestamp: 2025-05-05T06:37:51.001Z
Learning: For certain templates in the codebase, the `importMapProviders` property is not explicitly required as the template extractor will automatically determine and infer the necessary import map providers.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to plugins/*/**/*.tsx : In plugins, prefix all Tailwind classes with the plugin name (e.g., `auth-`, `storage-`)
Learnt from: kingston
PR: halfdomelabs/baseplate#505
File: packages/create-project/tsconfig.json:6-6
Timestamp: 2025-04-21T06:32:22.476Z
Learning: Since TypeScript 4.1, baseUrl is not required for paths mapping in tsconfig.json. Removing baseUrl and using explicit relative paths with "./" prefix (e.g., changing "@src/*": ["src/*"] to "@src/*": ["./src/*"]) prevents bare path imports from node_modules while maintaining path alias functionality.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : If a particular interface or type is not exported, change the file so it is exported
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Include absolute paths in import statements via tsconfig paths (`@src/` is the alias for `src/`)
Learnt from: kingston
PR: halfdomelabs/baseplate#505
File: packages/create-project/tsconfig.json:6-6
Timestamp: 2025-04-21T06:32:22.476Z
Learning: Since TypeScript 4.1, baseUrl is not required for paths mapping when using explicit relative paths (with "./"). Removing baseUrl from tsconfig.json while updating paths to use relative paths (e.g., changing "@src/*": ["src/*"] to "@src/*": ["./src/*"]) prevents bare path imports from node_modules while maintaining path alias functionality.
Learnt from: kingston
PR: halfdomelabs/baseplate#562
File: plugins/plugin-auth/package.json:32-36
Timestamp: 2025-06-03T09:11:29.651Z
Learning: With TypeScript project references, TypeScript compilation is watched from the root level using "watch:tsc:root" script, so individual packages no longer need to include their "tsc:watch" scripts in their local "watch" commands. The local "tsc:watch" scripts are renamed from "watch:tsc" but are not meant to be run as part of the package's watch command since TypeScript watching is handled centrally at the workspace root.
Learnt from: kingston
PR: halfdomelabs/baseplate#521
File: plugins/baseplate-plugin-storage/src/generators/react/upload-components/upload-components.generator.ts:108-112
Timestamp: 2025-05-05T06:37:43.106Z
Learning: The template extractor in the baseplate codebase can automatically infer and determine the necessary import map providers for certain templates, making explicit specification of importMapProviders unnecessary in those cases.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.unit.test.ts : Unit tests use `.unit.test.ts` suffix
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{unit,int}.test.ts : Unit tests use `.unit.test.ts` suffix, integration tests use `.int.test.ts`
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{unit,int}.test.ts : Always import vitest globals explicitly (describe, it, expect)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/tests.mdc:0-0
Timestamp: 2025-06-30T11:52:28.745Z
Learning: Applies to **/*.unit.test.{ts,tsx} : Unit tests are colocated with source files using `.unit.test.ts` suffix
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/tests.mdc:0-0
Timestamp: 2025-06-30T11:52:28.745Z
Learning: Applies to **/*.test.{ts,tsx} : For file system operations in tests, use memfs and mock 'node:fs' and 'node:fs/promises' with vi.mock
Learnt from: kingston
PR: halfdomelabs/baseplate#521
File: packages/react-generators/src/generators/admin/admin-crud-edit/admin-crud-edit.generator.ts:90-94
Timestamp: 2025-05-05T06:36:50.687Z
Learning: In this codebase, import paths can include `.ts` extensions, and the `resolveModuleSpecifier` function will handle them appropriately. There's no need to strip file extensions before passing paths to functions like `TsCodeUtils.importFragment`.
🧬 Code Graph Analysis (21)
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/services/download-file.ts (1)
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/config/categories.config.ts (1)
getCategoryByNameOrThrow(17-23)
packages/project-builder-web/src/routes/data/models/edit.$key/service.tsx (1)
packages/project-builder-web/src/routes/data/models/-hooks/use-model-form.ts (1)
useModelForm(34-204)
plugins/plugin-auth/src/auth/core/node.ts (1)
plugins/plugin-auth/src/auth/core/generators/auth-apollo/auth-apollo.generator.ts (1)
authApolloGenerator(14-59)
packages/project-builder-web/src/routes/data/models/edit.$key/index.tsx (1)
packages/project-builder-web/src/routes/data/models/-hooks/use-model-form.ts (1)
useModelForm(34-204)
packages/project-builder-web/src/routes/data/models/edit.$key/graphql.tsx (1)
packages/project-builder-web/src/routes/data/models/-hooks/use-model-form.ts (1)
useModelForm(34-204)
plugins/plugin-storage/src/generators/fastify/prisma-file-transformer/prisma-file-transformer.generator.ts (1)
packages/utils/src/string/quot.ts (1)
quot(6-8)
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/schema/presigned.mutations.ts (1)
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/schema/file-category.enum.ts (1)
fileCategoryEnumType(7-9)
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/schema/public-url.field.ts (1)
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/config/adapters.config.ts (2)
STORAGE_ADAPTERS(3-3)StorageAdapterKey(5-5)
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/schema/file-category.enum.ts (1)
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/config/categories.config.ts (1)
FILE_CATEGORIES(6-6)
packages/utils/src/json/json-deep-clone.unit.test.ts (1)
packages/utils/src/json/json-deep-clone.ts (1)
jsonDeepClone(9-52)
packages/project-builder-web/src/routes/data/models/edit.$key/-components/fields/model-field-form.tsx (1)
packages/project-builder-web/src/routes/data/models/-hooks/use-edited-model-config.tsx (1)
useEditedModelConfig(71-84)
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/services/create-presigned-download-url.ts (1)
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/config/categories.config.ts (1)
getCategoryByNameOrThrow(17-23)
packages/project-builder-web/src/routes/data/models/-hooks/use-edited-model-config.tsx (2)
packages/project-builder-lib/src/schema/models/index.ts (2)
ModelConfig(316-316)ModelConfigInput(318-318)packages/utils/src/json/json-deep-clone.ts (1)
jsonDeepClone(9-52)
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/adapters/url.ts (1)
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/types/adapter.ts (1)
StorageAdapter(51-167)
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/types/file-category.ts (1)
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/config/adapters.config.ts (1)
StorageAdapterKey(5-5)
packages/project-builder-web/src/routes/data/models/-hooks/use-model-form.ts (6)
packages/project-builder-lib/src/schema/models/index.ts (3)
ModelConfigInput(318-318)ModelConfig(316-316)createModelBaseSchema(275-307)packages/project-builder-lib/src/web/hooks/use-project-definition.ts (1)
useProjectDefinition(80-88)packages/project-builder-lib/src/schema/models/types.ts (1)
modelEntityType(3-3)packages/project-builder-lib/src/definition/model/model-utils.ts (1)
ModelUtils(89-99)packages/project-builder-lib/src/web/hooks/use-definition-schema.ts (1)
useDefinitionSchema(7-15)packages/project-builder-web/src/hooks/use-definition-schema.ts (1)
useDefinitionSchema(9-17)
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/config/categories.config.ts (1)
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/types/file-category.ts (1)
FileCategory(12-54)
packages/project-builder-web/src/routes/data/models/-components/new-model-dialog.tsx (5)
packages/project-builder-lib/src/schema/models/index.ts (2)
ModelConfigInput(318-318)createModelBaseSchema(275-307)packages/project-builder-lib/src/schema/models/types.ts (2)
modelScalarFieldEntityType(5-10)modelEntityType(3-3)packages/ui-components/src/hooks/index.ts (1)
useControlledState(2-2)packages/project-builder-lib/src/web/hooks/use-project-definition.ts (1)
useProjectDefinition(80-88)packages/project-builder-lib/src/definition/feature/feature-utils.ts (1)
FeatureUtils(109-121)
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/services/upload-file.ts (1)
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/utils/validate-file-upload-options.ts (2)
FileUploadOptions(55-55)validateFileUploadOptions(125-188)
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/services/create-presigned-upload-url.ts (2)
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/utils/validate-file-upload-options.ts (2)
FileUploadOptions(55-55)validateFileUploadOptions(125-188)packages/fastify-generators/src/generators/core/error-handler-service/templates/src/utils/http-errors.ts (1)
BadRequestError(14-22)
plugins/plugin-storage/src/generators/fastify/storage-module/storage-module.generator.ts (10)
packages/fastify-generators/src/writers/pothos/options.ts (1)
createPothosTypeReference(24-37)packages/sync/src/generators/generators.ts (1)
createGeneratorTask(196-204)packages/fastify-generators/src/generators/core/app-module/app-module.generator.ts (1)
appModuleProvider(43-44)packages/fastify-generators/src/generators/pothos/pothos/pothos.generator.ts (1)
pothosSchemaProvider(66-67)packages/fastify-generators/src/generators/pothos/_providers/pothos-type-output.ts (1)
pothosTypeOutputProvider(18-19)packages/core-generators/src/renderers/typescript/utils/ts-code-utils.ts (3)
template(444-465)TsCodeUtils(85-580)tsTemplate(583-583)packages/core-generators/src/renderers/typescript/fragments/creators.ts (1)
tsCodeFragment(73-83)packages/core-generators/src/renderers/typescript/imports/builder.ts (1)
tsTypeImportBuilder(89-96)packages/core-generators/src/renderers/typescript/fragments/types.ts (1)
TsCodeFragment(55-72)packages/utils/src/string/quot.ts (1)
quot(6-8)
🪛 Biome (1.9.4)
packages/tools/tsconfig.vite.lib.json
[error] 7-7: JSON standard does not allow comments.
(parse)
[error] 8-8: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 8-8: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 8-8: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 8-8: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 9-9: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 9-9: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
[error] 9-9: End of file expected
Use an array for a sequence of values: [1, 2]
(parse)
🪛 ESLint
plugins/plugin-auth/src/auth/core/generators/auth-apollo/templates/session-error-link.ts
[error] 1-1: Do not use "@ts-nocheck" because it alters compilation errors.
(@typescript-eslint/ban-ts-comment)
[error] 4-4: 'sessionErrorLink' is assigned a value but never used. Allowed unused vars must match /^_/u.
(unused-imports/no-unused-vars)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Test E2E
- GitHub Check: Socket Security: Pull Request Alerts
🔇 Additional comments (95)
plugins/plugin-auth/src/auth0/generators/react/react-auth0/react-auth0.generator.ts (1)
26-26: Import now includes.jsextension – fully ESM-compliant
Adding the explicitindex.jssatisfies the “include file extensions” rule for Node 16 module resolution and keeps tooling happy. 👍packages/core-generators/src/generators/node/eslint/react-rules.ts (1)
53-62: LGTM! Proper filename casing exceptions for routing and Tanstack files.The rule configuration correctly adds ignore patterns for special filename prefixes while maintaining kebab-case enforcement for regular files. The regex patterns are properly escaped using
String.raw..changeset/short-vans-judge.md (1)
1-7: LGTM! Changeset properly documents the configuration changes.The patch-level versioning is appropriate for ESLint rule adjustments, and the description accurately reflects the addition of filename casing exceptions.
packages/tools/eslint-configs/typescript.js (1)
223-225: LGTM! Disabling problematic text-encoding-identifier-case rule.The rule is correctly disabled with proper justification referencing the WHATWG specification and the linked GitHub issue about unexpected autofix behavior.
packages/core-generators/src/generators/node/eslint/templates/eslint.config.js (1)
174-176: LGTM! Consistent rule configuration across templates.The rule disable is correctly applied in the template with the same rationale as other ESLint configurations, ensuring consistency for generated projects.
packages/tools/eslint-configs/react.js (1)
66-66: LGTM! Consistent filename casing exceptions for Tanstack files.The ignore pattern for
$prefixed files is correctly added alongside the existing-prefix pattern. The regex properly matches Tanstack camelCase files while maintaining kebab-case enforcement for regular files.Also applies to: 73-76
plugins/plugin-storage/package.json (1)
55-57: es-toolkit is required at runtime by plugin-storage—keep it in dependenciesThe generator code in
plugins/plugin-storageimports fromes-toolkit, which runs when the plugin is executed (e.g. via the CLI). Moving it to devDependencies would break consumers, since devDependencies aren’t installed for end-users.• plugins/plugin-storage/src/generators/fastify/storage-module/storage-module.generator.ts:27
import { constantCase } from 'es-toolkit';Likely an incorrect or invalid review comment.
plugins/plugin-auth/src/auth/core/generators/auth-routes/auth-routes.generator.ts (1)
5-5: Runtime check for generated/index.js in dev/watch mode
- No imports from
./generatedwithout a.jssuffix were found under
plugins/plugin-auth/src/auth/core/generators.- Please confirm that, during local development (e.g. via
tsxorts-node),
requests forgenerated/index.jscorrectly resolve to the TypeScript source
(either by transpiling ahead of execution or via your loader’s.js→.tsmapping),
to avoid a 404 at runtime.plugins/plugin-auth/src/auth/core/generators/auth-apollo/index.ts (1)
1-1: LGTM: Correct barrel export implementation.The barrel export follows the coding guidelines perfectly, using the required
.jsextension for TypeScript imports and the preferredexport *pattern for index files.plugins/plugin-auth/src/auth/core/generators/index.ts (1)
1-1: LGTM: Consistent integration of new generator.The new auth-apollo export follows the established pattern and correctly uses the
.jsextension as required by the coding guidelines.plugins/plugin-auth/src/auth/core/generators/auth-routes/templates/routes/auth_/register.tsx (1)
62-62: Good UX improvement with form validation.Adding
reValidateMode: 'onBlur'improves user experience by reducing validation noise while typing and providing feedback when users move between fields.plugins/plugin-auth/src/auth/core/generators/auth-routes/templates/routes/auth_/login.tsx (1)
63-63: Consistent UX improvement across auth forms.Adding
reValidateMode: 'onBlur'here maintains consistency with the register form and provides the same UX benefits.plugins/plugin-auth/src/auth/core/node.ts (3)
22-22: Correct import with proper file extension.The import statement correctly uses the
.jsextension as required by the Node 16 module resolution guidelines.
69-69: Proper integration of Apollo generator.The
authApolloGeneratoris correctly added tosharedWebGenerators, ensuring it's available for both web and admin app compilation. Based on the generator implementation, this adds valuable session-aware error handling to Apollo clients.
1-95: Flag potential inconsistency with PR objectives.This file and all other files in this review are related to the auth plugin, but the PR objectives indicate this is about "Refactor storage plugin file category system to use registry-based pattern". Please verify if the PR summary is accurate or if these auth plugin changes are part of a larger refactor.
Likely an incorrect or invalid review comment.
plugins/plugin-auth/src/auth/core/generators/auth-apollo/templates/session-error-link.ts (1)
1-1: Remove @ts-nocheck and add proper TypeScript imports.The
@ts-nocheckdirective violates the coding guidelines requiring strict TypeScript checking. This template file is missing essential imports that would cause compilation errors when the code is extracted.Apply this diff to add proper typing and imports:
-// @ts-nocheck - -// SESSION_ERROR_LINK:START +import { onError } from '@apollo/client/link/error'; +import type { ServerError } from '@apollo/client/link/http'; + +// SESSION_ERROR_LINK:STARTNote: The
userSessionClientwill need to be available in the context where this template is used.⛔ Skipped due to learnings
Learnt from: kingston PR: halfdomelabs/baseplate#592 File: plugins/plugin-auth/src/auth0/generators/react/auth0-hooks/templates/src/hooks/use-required-user-id.ts:1-2 Timestamp: 2025-07-07T18:24:17.522Z Learning: Files under templates/** directories can use `// @ts-nocheck` because they are templates meant for code generation, not direct type checking.Learnt from: CR PR: halfdomelabs/baseplate#0 File: CLAUDE.md:0-0 Timestamp: 2025-06-30T11:51:48.395Z Learning: Applies to **/*.{ts,tsx} : TypeScript with strict type checkingLearnt from: CR PR: halfdomelabs/baseplate#0 File: CLAUDE.md:0-0 Timestamp: 2025-06-30T11:51:48.395Z Learning: Applies to **/*.{ts,tsx} : If a particular interface or type is not exported, change the file so it is exportedLearnt from: CR PR: halfdomelabs/baseplate#0 File: CLAUDE.md:0-0 Timestamp: 2025-06-30T11:51:48.395Z Learning: Applies to **/*.test.ts : Include tests for error conditions and edge casesLearnt from: CR PR: halfdomelabs/baseplate#0 File: .cursor/rules/code-style.mdc:0-0 Timestamp: 2025-06-30T11:52:11.055Z Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use TypeScript with strict type checking enabledLearnt from: CR PR: halfdomelabs/baseplate#0 File: CLAUDE.md:0-0 Timestamp: 2025-06-30T11:51:48.395Z Learning: Applies to **/*.{ts,tsx} : Specify explicit return types on all functionsLearnt from: CR PR: halfdomelabs/baseplate#0 File: CLAUDE.md:0-0 Timestamp: 2025-06-30T11:51:48.395Z Learning: Applies to **/*.{ts,tsx} : Always use `.js` extensions in imports, even for TypeScript filesLearnt from: CR PR: halfdomelabs/baseplate#0 File: .cursor/rules/code-style.mdc:0-0 Timestamp: 2025-06-30T11:52:11.055Z Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Extract repeated components into distinct functions or components where applicableLearnt from: CR PR: halfdomelabs/baseplate#0 File: CLAUDE.md:0-0 Timestamp: 2025-06-30T11:51:48.395Z Learning: Applies to **/*.{ts,tsx} : Use console.info/warn/error instead of console.logLearnt from: CR PR: halfdomelabs/baseplate#0 File: CLAUDE.md:0-0 Timestamp: 2025-06-30T11:51:48.395Z Learning: Applies to **/*.{ts,tsx} : Node 16 module resolution - include file extensions in imports (`.js`)Learnt from: CR PR: halfdomelabs/baseplate#0 File: .cursor/rules/code-style.mdc:0-0 Timestamp: 2025-06-30T11:52:11.055Z Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Prefer functional programming patternsplugins/plugin-auth/src/auth/core/generators/auth-apollo/auth-apollo.generator.ts (2)
1-11: LGTM - Import organization follows guidelines.The imports are properly organized with external libraries first, then local imports with
.jsextensions as required by the coding guidelines.
14-59: Generator registration and template path verifiedBoth checks passed successfully:
authApolloGeneratoris imported and registered inplugins/plugin-auth/src/auth/core/node.ts.- The template file exists at
plugins/plugin-auth/src/auth/core/generators/auth-apollo/templates/session-error-link.ts.No further action required.
packages/project-builder-web/src/routes/data/models/edit.$key/service.tsx (2)
38-38: Consistent with the refactoring pattern.The change from
defaultValuestooriginalModelaligns with the broader refactor mentioned in the AI summary, where the context provider now receives the complete original model instead of processed form values.
48-48: Prop update correctly reflects the variable rename.The prop name change from
initialModeltooriginalModelis consistent with the destructuring change and maintains the same data flow..changeset/plenty-mails-refuse.md (1)
1-6: Changeset correctly documents the new utility function.The changeset properly categorizes this as a patch change and provides a clear description of the new JSON deep clone functionality.
packages/project-builder-web/src/routes/data/models/edit.$key/graphql.tsx (2)
22-22: Consistent with the established refactoring pattern.The destructuring change mirrors the pattern used in other route files, maintaining consistency across the model editing interface.
33-33: Prop update maintains consistency with variable renaming.The prop name change correctly reflects the destructuring update and ensures consistent data flow to the context provider.
packages/project-builder-web/src/routes/data/models/edit.$key/index.tsx (2)
37-37: Completes the consistent refactoring across all route files.This change maintains the same pattern applied to service.tsx and graphql.tsx, ensuring uniform behavior across all model editing routes.
52-52: Final prop update completes the refactoring pattern.The prop name change correctly aligns with the destructuring update and ensures all model editing routes use the same interface with the context provider.
packages/utils/src/json/index.ts (1)
1-1: LGTM! Barrel export follows established patterns.The new export correctly uses the
.jsextension and follows the barrel export pattern preferred for index files.packages/project-builder-web/src/routes/data/models/edit.$key/-components/fields/model-field-form.tsx (1)
51-56: Good optimization: More granular data selection reduces re-renders.Breaking down the model selector into specific field selectors (
primaryKeyFieldRefsanduniqueConstraints) improves performance by preventing unnecessary re-renders when unrelated model fields change.packages/utils/src/json/json-deep-clone.unit.test.ts (1)
1-188: Excellent test coverage with proper structure and organization.The test suite comprehensively covers all supported types, edge cases, and error conditions. Tests properly verify both value equality and reference inequality for cloned objects, ensuring deep cloning behavior is correct.
packages/project-builder-web/src/routes/data/models/-hooks/use-edited-model-config.tsx (1)
25-69: Clean refactor: Simplified dependencies and improved immutability handling.The changes effectively simplify the component by:
- Removing external dependencies on
ModelUtilsanduseProjectDefinition- Using the passed
originalModeldirectly instead of fetching- Properly handling React Hook Form's mutable data with
jsonDeepCloneto prevent state mutation issuesThe explanatory comment on line 58 is helpful for future maintainers.
packages/project-builder-web/src/routes/data/models/-components/new-model-dialog.tsx (3)
89-142: Well-implemented form submission logic!The submission handler properly validates uniqueness, manages features, and maintains sorted model lists. Good error handling and navigation flow.
41-41: Add explicit return type to functionAccording to the coding guidelines, all functions must have explicit return types.
Apply this diff:
-function createNewModel(): ModelConfigInput { +function createNewModel(): ModelConfigInput {Wait, I see it already has the return type. Let me re-check... Yes, the function already has the correct return type
ModelConfigInput.
1-1: Add.jsextensions to project-builder-lib imports; verify othersWe should update the two imports from
@baseplate-dev/project-builder-libto point at their exported.jsentrypoints. For the remaining dependencies (@hookform/resolvers,@tanstack/react-router,es-toolkit), please confirm their package exports support.jsextensions before applying the same change.• File:
packages/project-builder-web/src/routes/data/models/-components/new-model-dialog.tsx
Lines: 1–14Apply this diff:
-import type { ModelConfigInput } from '@baseplate-dev/project-builder-lib'; +import type { ModelConfigInput } from '@baseplate-dev/project-builder-lib/index.js'; -import { - createModelBaseSchema, - FeatureUtils, - modelEntityType, - modelScalarFieldEntityType, -} from '@baseplate-dev/project-builder-lib'; +import { + createModelBaseSchema, + FeatureUtils, + modelEntityType, + modelScalarFieldEntityType, +} from '@baseplate-dev/project-builder-lib/index.js'; -import { - useBlockBeforeContinue, - useDefinitionSchema, - useProjectDefinition, -} from '@baseplate-dev/project-builder-lib/web'; +import { + useBlockBeforeContinue, + useDefinitionSchema, + useProjectDefinition, +} from '@baseplate-dev/project-builder-lib/web/index.js';Next steps:
- ✅ Confirm that
@baseplate-dev/project-builder-libexports./dist/index.jsand./dist/web/index.js(already verified).- 🔍 Manually inspect or script-verify the
main/exportsfields of the other packages to ensure their entrypoints end in.js(e.g.@hookform/resolvers/zod/index.js,@tanstack/react-router/index.js,es-toolkit/index.js).packages/ui-components/src/components/combobox/combobox.test.tsx (1)
4-4: LGTM! Import consistency improvement.The change from default to named import for
userEventaligns with modern ES6 module practices and improves import explicitness.packages/ui-components/src/components/calendar/calendar.tsx (1)
12-12: LGTM! Follows module resolution guidelines.Adding the
.jsextension aligns with the coding guidelines for Node 16 module resolution and TypeScript best practices.packages/react-generators/src/generators/core/react-components/templates/src/components/circular-progress/circular-progress.tsx (2)
11-11: LGTM! Interface enhancement follows existing patterns.Adding the 'xs' size option extends the component's flexibility while maintaining consistency with existing size options.
30-33: LGTM! Size configuration is logically consistent.The 'xs' size configuration with
size-8container andtext-xsfollows the logical progression of existing size options and provides appropriate scaling for smaller progress indicators.plugins/plugin-storage/src/storage/transformers/components/file-transformer-form.tsx (1)
10-10: LGTM! Import path follows module resolution guidelines.Adding the
.jsextension to the import path aligns with the coding guidelines for explicit file extensions in TypeScript imports.packages/ui-components/.storybook/preview.tsx (1)
13-13: LGTM! Import path follows module resolution guidelines.Adding the
.jsextension to the import path aligns with the coding guidelines for explicit file extensions and Node 16 module resolution requirements.plugins/plugin-storage/src/generators/react/upload-components/templates/src/components/file-input/upload.gql (1)
3-4: LGTM! Field renaming aligns with storage plugin refactoring.The renaming from
nametofilenameandhostedUrltopublicUrlis consistent with the broader refactoring to improve naming clarity and standardization across the storage plugin.plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/schema/file-category.enum.ts (1)
7-9: LGTM! Proper enum type definition using builder pattern.The implementation correctly creates a GraphQL enum type by mapping FILE_CATEGORIES values to their names, enforcing type safety for file categories in the schema.
plugins/plugin-storage/src/generators/fastify/prisma-file-transformer/prisma-file-transformer.generator.ts (1)
67-74: LGTM! Consistent function renaming aligns with validation service refactoring.The rename from
validateFileUploadInputtovalidateFileInputmaintains the same functionality while improving naming clarity as part of the broader storage module refactoring.plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/schema/file-input.input-type.ts (1)
5-6: LGTM! Improved naming and added helpful description.The rename from
FileUploadInputtoFileInputprovides better clarity, and the added description enhances schema documentation for API consumers.plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/schema/public-url.field.ts (2)
5-7: LGTM! Import reorganization follows new config structure.The updated imports correctly reference the new adapter configuration location, improving code organization.
9-22: LGTM! Comprehensive renaming improves API clarity.The systematic renaming from
hostedUrltopublicUrl,pathtostoragePath, andgetHostedUrltogetPublicUrlenhances naming consistency and clarity across the storage adapter API while maintaining the same functionality and error handling.plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/schema/presigned.mutations.ts (1)
7-7: LGTM! Enum type and field naming improvements enhance type safety.The changes properly introduce the
fileCategoryEnumTypefor the category field and align field names with the new conventions (filename, size). These improvements provide better type safety and consistency across the storage module.Also applies to: 23-26
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/services/download-file.ts (1)
9-11: Well-structured refactor with improved error handling and authorization.The changes correctly implement the new category registry pattern and enhance the authorization flow:
- Using
getCategoryByNameOrThroweliminates redundant error handling- System role bypass provides appropriate service account access
- The new
authorize?.presignedReadpattern aligns with the separated permission modelstoragePathproperty usage matches the updated schemaAlso applies to: 12-17, 29-34, 46-46
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/services/create-presigned-download-url.ts (1)
7-8: Good implementation of the new category registry pattern.The changes correctly adopt the new configuration-based imports and category lookup mechanism, with proper usage of
storagePath.Also applies to: 26-26, 48-48
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/utils/create-file-category.ts (3)
6-10: Helpful utilities for file size calculations.The
FileSizehelper provides excellent readability improvements over raw byte calculations.
25-29: Robust validation for category naming convention.The CONSTANT_CASE validation ensures consistent naming across all file categories, which is crucial for the registry-based pattern.
22-36: Add explicit return type per coding guidelines.The function logic and validation are solid. However, per the coding guidelines, all functions should have explicit return types.
-export function createFileCategory<TName extends string>( - config: FileCategory<TName>, -): FileCategory<TName> { +export function createFileCategory<TName extends string>( + config: FileCategory<TName>, +): FileCategory<TName> {Wait, the return type is already specified. Let me re-read... Yes, the return type
: FileCategory<TName>is already there. This is correct.plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/services/upload-file.ts (2)
5-7: Clean refactor with improved parameter separation.The function signature improvement with separate
contentsandoptionsparameters provides better API clarity. The JSDoc documentation is helpful.Also applies to: 9-15, 16-24
28-28: uploadFile is guaranteed by the StorageAdapter interface
TheStorageAdapterdefinition inplugins/plugin-storage/src/generators/fastify/storage-module/templates/module/types/adapter.tsdeclaresuploadFile(...)as a required method (no?suffix). You can safely calladapter.uploadFile(...)without an existence check.plugins/plugin-storage/src/generators/react/upload-components/templates/src/components/file-input/file-input.tsx (6)
3-3: LGTM: Type safety improvement with FileCategory import.The import of
FileCategorytype enhances type safety for the category prop.
21-25: LGTM: Property renaming aligns with broader refactor.The renaming of
nametofilenameandhostedUrltopublicUrlis consistent with the storage plugin refactor.
34-34: LGTM: Enhanced type safety with FileCategory type.Using the imported
FileCategorytype instead ofstringprovides better type safety and validation.
66-73: LGTM: GraphQL mutation parameters updated correctly.The mutation parameters are correctly updated to match the new schema:
fileName→filenamefileSize→size- Content type fallback updated to 'application/octet-stream'
89-92: LGTM: Response handling updated for new property names.The file handling correctly uses the new property names
filenameandpublicUrl.
208-208: LGTM: CircularProgress size updated correctly.The size change from
"sm"to"xs"is consistent with the CircularProgress component updates.plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/config/categories.config.ts (4)
6-6: LGTM: Clean registry pattern implementation.The readonly array export with template variable integration is well-designed for the registry-based approach.
9-9: LGTM: Type-safe category name extraction.The type alias correctly extracts category names from the registry for type safety.
12-14: LGTM: Clean optional lookup function.The
getCategoryByNamefunction provides a clean optional lookup with proper return typing.
17-23: LGTM: Good error handling in mandatory lookup.The
getCategoryByNameOrThrowfunction provides appropriate error handling for mandatory lookups with descriptive error messages.plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/adapters/url.ts (6)
3-6: LGTM: Appropriate imports for enhanced functionality.The addition of Readable stream type and axios import supports the new streaming download capability.
11-13: LGTM: Updated documentation reflects actual usage.The comment correctly describes the adapter's purpose and limitations.
15-16: LGTM: Explicit rejection of unsupported upload operation.Clear error message indicating the adapter doesn't support file uploads.
17-23: LGTM: Proper streaming download implementation.The axios-based streaming download implementation is correct and follows best practices for handling external URLs.
24-31: LGTM: Clear rejection of unsupported operations.Both
fileExistsandgetFileMetadataappropriately reject with descriptive error messages.
32-33: LGTM: Correct implementation of URL-based methods.Both
getPublicUrlandcreatePresignedDownloadUrlcorrectly return the path as the URL, which is appropriate for this adapter type.plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/types/file-category.ts (7)
3-6: LGTM: Appropriate imports for interface dependencies.The imports correctly bring in ServiceContext, File model, and StorageAdapterKey types needed for the interface.
12-14: LGTM: Well-designed generic interface with clear constraints.The generic type parameter with string constraint and readonly name property provides good type safety.
16-23: LGTM: Clear path prefix configuration.The optional pathPrefix with detailed documentation explains the behavior clearly.
25-32: LGTM: Comprehensive file size constraints.Both maximum and optional minimum file size constraints provide good flexibility for validation.
34-35: LGTM: Type-safe adapter specification.Using StorageAdapterKey ensures only valid adapters can be specified.
37-48: LGTM: Well-designed authorization pattern.The separation of upload and presigned read authorization functions provides fine-grained access control with clear documentation about default behavior.
50-54: LGTM: Clear relation specification.The referencedByRelation property correctly constrains to valid model relation keys.
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/services/validate-file-input.ts (9)
3-10: LGTM: Appropriate imports for validation service.The imports correctly bring in required types for DataPipeOutput, ServiceContext, error handling, and file category.
12-14: LGTM: Clean interface definition.The FileUploadInput interface is simple and focused, containing only the required id field.
24-33: LGTM: Efficient early return for unchanged IDs.The optimization to skip validation when the file ID hasn't changed is a good performance improvement.
35-42: LGTM: Clear file existence validation.The database lookup and error handling for non-existent files is appropriate with a descriptive error message.
44-52: LGTM: Proper authorization checks.The authorization logic correctly handles both system users and file uploaders with clear security boundaries and descriptive error messages.
54-59: LGTM: Good reference status validation.Preventing reuse of already referenced files is a good business rule with clear error messaging.
61-66: LGTM: Category validation ensures type safety.The category matching validation prevents misuse of files and provides clear error messaging about expected vs actual categories.
68-74: LGTM: Upload completion verification via adapter.Using the storage adapter to verify file metadata ensures the file was actually uploaded successfully, which is a good safety check.
76-89: LGTM: Well-designed return with post-operations.The DataPipeOutput return pattern with post-operation updates to mark the file as referenced and update size is well-designed for the data pipeline pattern.
.changeset/dull-words-fold.md (1)
1-34: LGTM! Comprehensive changeset documentation.The changeset properly follows the standard format and provides excellent documentation of the architectural changes, including breaking changes and migration guidance.
plugins/plugin-storage/src/storage/core/schema/models.ts (2)
9-73: LGTM! Well-organized schema improvements.The field reorganization with logical grouping and semantic renamings (e.g.,
name→filename) significantly improves clarity. The addition of optional fields likeencodingand status tracking fields enhances the model's capabilities.
108-111: GraphQL field exposure is consistent.The GraphQL object type correctly exposes
filenameinstead of the oldnamefield, maintaining consistency with the schema changes.plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/utils/mime.ts (1)
37-61: Enhanced validation logic looks good.The improved validation with stricter MIME type checking, better error messages, and extension validation enhances robustness.
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/types/adapter.ts (1)
1-167: Excellent adapter interface design.This comprehensive
StorageAdapterinterface provides a solid foundation with:
- Well-documented methods with JSDoc and usage examples
- Proper use of optional methods for adapter-specific features
- Comprehensive type definitions for all operations
- Good error handling guidance
The interface design promotes consistency across adapter implementations while allowing flexibility for different storage backends.
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/utils/validate-file-upload-options.ts (1)
22-22: Fix inconsistent variable naming.The constant name uses inconsistent casing. It should follow the UPPER_SNAKE_CASE convention for constants.
-const MAX_filename_LENGTH = 128; +const MAX_FILENAME_LENGTH = 128;⛔ Skipped due to learnings
Learnt from: CR PR: halfdomelabs/baseplate#0 File: .cursor/rules/code-style.mdc:0-0 Timestamp: 2025-06-30T11:52:11.055Z Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use camelCase for variables and functionsLearnt from: CR PR: halfdomelabs/baseplate#0 File: CLAUDE.md:0-0 Timestamp: 2025-06-30T11:51:48.395Z Learning: Applies to **/*.{ts,tsx} : Use camelCase for variables/functions, PascalCase for types/classesLearnt from: CR PR: halfdomelabs/baseplate#0 File: CLAUDE.md:0-0 Timestamp: 2025-06-30T11:51:48.395Z Learning: Applies to **/*.test.ts : Use descriptive test names that explain what is being testedLearnt from: CR PR: halfdomelabs/baseplate#0 File: .cursor/rules/code-style.mdc:0-0 Timestamp: 2025-06-30T11:52:11.055Z Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use PascalCase for types and classesplugins/plugin-storage/src/generators/fastify/storage-module/storage-module.generator.ts (1)
277-293: LGTM! Well-structured file category creation.The implementation correctly uses the new
createFileCategorypattern with proper name transformation and conditional authorization setup.plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/adapters/s3.ts (3)
46-77: Excellent enhancement to presigned upload URL generation.The implementation includes important improvements:
- Flexible options with sensible defaults
- Prevention of overwrites with 'If-None-Match' header
- Proper expiration time handling
109-144: Well-designed batch deletion with detailed results.The implementation properly handles partial failures and provides detailed feedback about which operations succeeded or failed, which is much better than the all-or-nothing approach.
146-190: Robust implementation of file existence and metadata retrieval.Both methods properly handle the 404 case and provide consistent error handling. The metadata normalization in
getFileMetadataensures consistent output regardless of S3's response format.plugins/plugin-storage/src/generators/fastify/storage-module/extractor.json (1)
1-290: Skip review - configuration looks correct.
Comment on lines
4
to
15
| const sessionErrorLink = onError(({ networkError }) => { | ||
| const serverError = networkError as ServerError | undefined; | ||
| if ( | ||
| typeof serverError === 'object' && | ||
| serverError.statusCode === 401 && | ||
| typeof serverError.result === 'object' && | ||
| serverError.result.code === 'invalid-session' | ||
| ) { | ||
| userSessionClient.signOut(); | ||
| } | ||
| return; | ||
| }); |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Add explicit return type for the error link.
According to the coding guidelines, all functions require explicit return types. The error link should specify its return type for better type safety.
Apply this diff to add the return type:
-const sessionErrorLink = onError(({ networkError }) => {
+const sessionErrorLink = onError(({ networkError }): void => {
const serverError = networkError as ServerError | undefined;
if (
typeof serverError === 'object' &&
serverError.statusCode === 401 &&
typeof serverError.result === 'object' &&
serverError.result.code === 'invalid-session'
) {
userSessionClient.signOut();
}
return;
});📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| const sessionErrorLink = onError(({ networkError }) => { | |
| const serverError = networkError as ServerError | undefined; | |
| if ( | |
| typeof serverError === 'object' && | |
| serverError.statusCode === 401 && | |
| typeof serverError.result === 'object' && | |
| serverError.result.code === 'invalid-session' | |
| ) { | |
| userSessionClient.signOut(); | |
| } | |
| return; | |
| }); | |
| const sessionErrorLink = onError(({ networkError }): void => { | |
| const serverError = networkError as ServerError | undefined; | |
| if ( | |
| typeof serverError === 'object' && | |
| serverError.statusCode === 401 && | |
| typeof serverError.result === 'object' && | |
| serverError.result.code === 'invalid-session' | |
| ) { | |
| userSessionClient.signOut(); | |
| } | |
| return; | |
| }); |
🧰 Tools
🪛 ESLint
[error] 4-4: 'sessionErrorLink' is assigned a value but never used. Allowed unused vars must match /^_/u.
(unused-imports/no-unused-vars)
🤖 Prompt for AI Agents
In
plugins/plugin-auth/src/auth/core/generators/auth-apollo/templates/session-error-link.ts
between lines 4 and 15, the sessionErrorLink function lacks an explicit return
type. To fix this, add the appropriate return type annotation to the
sessionErrorLink constant declaration to ensure type safety and comply with
coding guidelines.
Comment on lines
38
to
54
| build: async (builder) => { | ||
| const linkTemplate = await builder.readTemplate( | ||
| 'session-error-link.ts', | ||
| ); | ||
| const sessionErrorLink = TsCodeUtils.extractTemplateSnippet( | ||
| linkTemplate, | ||
| 'SESSION_ERROR_LINK', | ||
| ); | ||
|
|
||
| reactApolloConfig.apolloLinks.add({ | ||
| name: 'sessionErrorLink', | ||
| bodyFragment: tsCodeFragment(sessionErrorLink, [ | ||
| tsImportBuilder(['onError']).from('@apollo/client/link/error'), | ||
| ]), | ||
| priority: 'error', | ||
| }); | ||
| }, |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Add explicit return type for the async build function.
The build function is not a one-liner arrow function and should have an explicit return type according to the coding guidelines.
Apply this diff to add the return type:
- build: async (builder) => {
+ build: async (builder): Promise<void> => {🤖 Prompt for AI Agents
In
plugins/plugin-auth/src/auth/core/generators/auth-apollo/auth-apollo.generator.ts
between lines 38 and 54, the async build function lacks an explicit return type.
To fix this, add an explicit return type annotation to the build function
signature, specifying the appropriate Promise return type based on what the
function returns or resolves to, following the project's coding guidelines.
Comment on lines
24
to
32
| run({ reactApolloConfig, reactSession }) { | ||
| reactApolloConfig.createApolloClientArguments.add({ | ||
| name: 'userSessionClient', | ||
| type: reactSession.UserSessionClient.typeFragment(), | ||
| reactRenderBody: tsCodeFragment( | ||
| 'const { client: userSessionClient } = useUserSessionClient();', | ||
| reactSession.useUserSessionClient.declaration(), | ||
| ), | ||
| }); |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Add explicit return type for the run function.
According to the coding guidelines, all functions (excluding one-liner arrow functions) require explicit return types. The run function spans multiple lines and should specify its return type.
Apply this diff to add the return type:
- run({ reactApolloConfig, reactSession }) {
+ run({ reactApolloConfig, reactSession }): {
+ providers: { authApollo: {} };
+ build: (builder: any) => Promise<void>;
+ } {📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| run({ reactApolloConfig, reactSession }) { | |
| reactApolloConfig.createApolloClientArguments.add({ | |
| name: 'userSessionClient', | |
| type: reactSession.UserSessionClient.typeFragment(), | |
| reactRenderBody: tsCodeFragment( | |
| 'const { client: userSessionClient } = useUserSessionClient();', | |
| reactSession.useUserSessionClient.declaration(), | |
| ), | |
| }); | |
| run({ reactApolloConfig, reactSession }): { | |
| providers: { authApollo: {} }; | |
| build: (builder: any) => Promise<void>; | |
| } { | |
| reactApolloConfig.createApolloClientArguments.add({ | |
| name: 'userSessionClient', | |
| type: reactSession.UserSessionClient.typeFragment(), | |
| reactRenderBody: tsCodeFragment( | |
| 'const { client: userSessionClient } = useUserSessionClient();', | |
| reactSession.useUserSessionClient.declaration(), | |
| ), | |
| }); |
🤖 Prompt for AI Agents
In
plugins/plugin-auth/src/auth/core/generators/auth-apollo/auth-apollo.generator.ts
around lines 24 to 32, the run function lacks an explicit return type as
required by coding guidelines. Add the appropriate explicit return type to the
run function signature to comply with the standards. Determine the correct
return type based on the function's implementation or context and specify it
explicitly before the function body.
Collaborator
Author
There was a problem hiding this comment.
No need for explicit return types here as it's inferred. Arrow functions in this case do not need explicit return types. No need to check for it general though since there's an ESLint rule for that.
There was a problem hiding this comment.
@kingston, understood! You're absolutely right that the return type can be inferred here and ESLint rules should handle the enforcement of explicit return types where actually needed. I appreciate the clarification on when explicit return types are necessary versus when type inference is sufficient.
✏️ Learnings added
Learnt from: kingston
PR: halfdomelabs/baseplate#606
File: plugins/plugin-auth/src/auth/core/generators/auth-apollo/auth-apollo.generator.ts:24-32
Timestamp: 2025-07-12T19:56:08.518Z
Learning: For generator functions and configuration object methods like those in createGeneratorTask, inferred return types are acceptable when the structure is clear from the implementation. ESLint rules handle enforcement of explicit return types where truly needed, so manual review for this is not necessary.
Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.
🧠 Learnings used
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Extract repeated components into distinct functions or components where applicable
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : All functions (excluding one-liner arrow functions) require explicit return types
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Specify explicit return types on all functions
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Always include return types on top-level functions including React components (`React.ReactElement`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : TypeScript with strict type checking
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Prefer functional programming patterns
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Prefer using nullish coalescing operator (`??`) instead of logical or (`||`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Prefer functional programming patterns
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use camelCase for variables and functions
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Use camelCase for variables/functions, PascalCase for types/classes
Comment on lines
+9
to
+52
| export function jsonDeepClone<T>(value: T): T { | ||
| if ( | ||
| value === undefined || | ||
| value === null || | ||
| typeof value === 'boolean' || | ||
| typeof value === 'string' | ||
| ) { | ||
| return value; | ||
| } | ||
|
|
||
| if (typeof value === 'number') { | ||
| return value; | ||
| } | ||
|
|
||
| if (typeof value === 'object') { | ||
| if (value instanceof Date || value instanceof RegExp) { | ||
| throw new TypeError( | ||
| `Cannot clone value of unsupported type: ${value.constructor.name}`, | ||
| ); | ||
| } | ||
|
|
||
| if (Array.isArray(value)) { | ||
| // Clone array elements | ||
| const copy: unknown[] = []; | ||
| for (const [i, element] of value.entries()) { | ||
| copy[i] = jsonDeepClone(element); | ||
| } | ||
| return copy as T; | ||
| } | ||
|
|
||
| // Clone plain object properties | ||
| const copy: Record<string, unknown> = {}; | ||
| for (const key in value) { | ||
| if (Object.prototype.hasOwnProperty.call(value, key)) { | ||
| const prop = (value as Record<string, unknown>)[key]; | ||
| copy[key] = jsonDeepClone(prop); | ||
| } | ||
| } | ||
| return copy as T; | ||
| } | ||
|
|
||
| // Reject functions, symbols, BigInt, etc. | ||
| throw new Error(`Cannot clone value of unsupported type: ${typeof value}`); | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Address circular references and consider special number values.
The implementation is solid for JSON-serializable data, but there are two potential issues:
-
Circular references: The function will cause a stack overflow if the input contains circular references. Consider adding a
WeakSetto track visited objects. -
Special number values: While
NaNandInfinityare handled implicitly, they serialize tonullin JSON. Consider explicit handling if this behavior is unexpected.
Here's an improved implementation that handles circular references:
+/**
+ * Recursively deep clones JSON-compatible values.
+ * Throws if the value is not JSON-serializable.
+ *
+ * @param value - The value to clone
+ * @param visited - Internal parameter to track circular references
+ * @returns A deep-cloned copy of the value
+ * @throws Error if a non-JSON value is encountered or circular reference detected
+ */
-export function jsonDeepClone<T>(value: T): T {
+export function jsonDeepClone<T>(value: T, visited = new WeakSet()): T {
if (
value === undefined ||
value === null ||
typeof value === 'boolean' ||
typeof value === 'string'
) {
return value;
}
if (typeof value === 'number') {
+ if (!Number.isFinite(value)) {
+ throw new Error(`Cannot clone non-finite number: ${value}`);
+ }
return value;
}
if (typeof value === 'object') {
+ if (visited.has(value)) {
+ throw new Error('Cannot clone value with circular reference');
+ }
+ visited.add(value);
+
if (value instanceof Date || value instanceof RegExp) {
throw new TypeError(
`Cannot clone value of unsupported type: ${value.constructor.name}`,
);
}
if (Array.isArray(value)) {
// Clone array elements
const copy: unknown[] = [];
for (const [i, element] of value.entries()) {
- copy[i] = jsonDeepClone(element);
+ copy[i] = jsonDeepClone(element, visited);
}
return copy as T;
}
// Clone plain object properties
const copy: Record<string, unknown> = {};
for (const key in value) {
if (Object.prototype.hasOwnProperty.call(value, key)) {
const prop = (value as Record<string, unknown>)[key];
- copy[key] = jsonDeepClone(prop);
+ copy[key] = jsonDeepClone(prop, visited);
}
}
return copy as T;
}
// Reject functions, symbols, BigInt, etc.
throw new Error(`Cannot clone value of unsupported type: ${typeof value}`);
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| export function jsonDeepClone<T>(value: T): T { | |
| if ( | |
| value === undefined || | |
| value === null || | |
| typeof value === 'boolean' || | |
| typeof value === 'string' | |
| ) { | |
| return value; | |
| } | |
| if (typeof value === 'number') { | |
| return value; | |
| } | |
| if (typeof value === 'object') { | |
| if (value instanceof Date || value instanceof RegExp) { | |
| throw new TypeError( | |
| `Cannot clone value of unsupported type: ${value.constructor.name}`, | |
| ); | |
| } | |
| if (Array.isArray(value)) { | |
| // Clone array elements | |
| const copy: unknown[] = []; | |
| for (const [i, element] of value.entries()) { | |
| copy[i] = jsonDeepClone(element); | |
| } | |
| return copy as T; | |
| } | |
| // Clone plain object properties | |
| const copy: Record<string, unknown> = {}; | |
| for (const key in value) { | |
| if (Object.prototype.hasOwnProperty.call(value, key)) { | |
| const prop = (value as Record<string, unknown>)[key]; | |
| copy[key] = jsonDeepClone(prop); | |
| } | |
| } | |
| return copy as T; | |
| } | |
| // Reject functions, symbols, BigInt, etc. | |
| throw new Error(`Cannot clone value of unsupported type: ${typeof value}`); | |
| } | |
| /** | |
| * Recursively deep clones JSON-compatible values. | |
| * Throws if the value is not JSON-serializable. | |
| * | |
| * @param value - The value to clone | |
| * @param visited - Internal parameter to track circular references | |
| * @returns A deep-cloned copy of the value | |
| * @throws Error if a non-JSON value is encountered or circular reference detected | |
| */ | |
| export function jsonDeepClone<T>(value: T, visited = new WeakSet()): T { | |
| if ( | |
| value === undefined || | |
| value === null || | |
| typeof value === 'boolean' || | |
| typeof value === 'string' | |
| ) { | |
| return value; | |
| } | |
| if (typeof value === 'number') { | |
| if (!Number.isFinite(value)) { | |
| throw new Error(`Cannot clone non-finite number: ${value}`); | |
| } | |
| return value; | |
| } | |
| if (typeof value === 'object') { | |
| if (visited.has(value)) { | |
| throw new Error('Cannot clone value with circular reference'); | |
| } | |
| visited.add(value); | |
| if (value instanceof Date || value instanceof RegExp) { | |
| throw new TypeError( | |
| `Cannot clone value of unsupported type: ${value.constructor.name}`, | |
| ); | |
| } | |
| if (Array.isArray(value)) { | |
| // Clone array elements | |
| const copy: unknown[] = []; | |
| for (const [i, element] of value.entries()) { | |
| copy[i] = jsonDeepClone(element, visited); | |
| } | |
| return copy as T; | |
| } | |
| // Clone plain object properties | |
| const copy: Record<string, unknown> = {}; | |
| for (const key in value) { | |
| if (Object.prototype.hasOwnProperty.call(value, key)) { | |
| const prop = (value as Record<string, unknown>)[key]; | |
| copy[key] = jsonDeepClone(prop, visited); | |
| } | |
| } | |
| return copy as T; | |
| } | |
| // Reject functions, symbols, BigInt, etc. | |
| throw new Error(`Cannot clone value of unsupported type: ${typeof value}`); | |
| } |
🤖 Prompt for AI Agents
In packages/utils/src/json/json-deep-clone.ts between lines 9 and 52, the
current jsonDeepClone function does not handle circular references, which can
cause a stack overflow, and it does not explicitly handle special number values
like NaN and Infinity that JSON converts to null. To fix this, modify the
function to accept a WeakSet parameter to track visited objects and throw an
error if a circular reference is detected. Also, add explicit checks for NaN and
Infinity to handle them appropriately instead of relying on JSON serialization
behavior.
...src/generators/fastify/storage-module/templates/module/utils/validate-file-upload-options.ts
Outdated
Show resolved
Hide resolved
...src/generators/fastify/storage-module/templates/module/utils/validate-file-upload-options.ts
Outdated
Show resolved
Hide resolved
...src/generators/fastify/storage-module/templates/module/utils/validate-file-upload-options.ts
Outdated
Show resolved
Hide resolved
...src/generators/fastify/storage-module/templates/module/utils/validate-file-upload-options.ts
Outdated
Show resolved
Hide resolved
...src/generators/fastify/storage-module/templates/module/utils/validate-file-upload-options.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 3
🔭 Outside diff range comments (2)
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/utils/mime.ts (1)
1-1: Remove @ts-nocheck and fix any resulting TypeScript errors.The
@ts-nocheckcomment disables TypeScript checking entirely, which conflicts with the coding guidelines that require "TypeScript with strict type checking enabled" for plugin files.Remove this directive and address any TypeScript errors that surface:
-// @ts-nocheckplugins/plugin-storage/src/storage/transformers/web.ts (1)
21-25: Add explicit return type to functionPer the coding guidelines, all top-level functions require explicit return types.
-function findNonTransformedFileRelations( - definition: ProjectDefinition, - modelConfig: ModelConfigInput, - pluginId: string, -): string[] { +function findNonTransformedFileRelations( + definition: ProjectDefinition, + modelConfig: ModelConfigInput, + pluginId: string, +): string[] {
🧹 Nitpick comments (5)
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/utils/mime.ts (1)
37-47: Enhance MIME type validation with more specific error handling.Consider improving the validation to provide more helpful error messages and handle edge cases better.
if (!mimeType || typeof mimeType !== 'string') { - throw new Error( - `Invalid mime type: ${mimeType}. Must be a valid MIME type string.`, - ); + throw new InvalidMimeTypeError( + `Invalid mime type: ${mimeType}. Must be a valid MIME type string.`, + [], + ); } if (!(mimeType in mime.extensions)) { - throw new Error( - `Unsupported mime type: ${mimeType}. Please use a supported file type.`, - ); + throw new InvalidMimeTypeError( + `Unsupported mime type: ${mimeType}. Please use a supported file type.`, + [], + ); }packages/project-builder-lib/src/plugins/migrations/run-migrations.ts (1)
31-34: Verify migration implementations handle the project definition parameter safely.The addition of the
draftparameter enables migrations to access the entire project definition. While this provides powerful capabilities for cross-plugin migrations, ensure that migration implementations carefully handle this parameter to avoid unintended modifications to unrelated parts of the project.Consider documenting best practices for migration authors on how to safely interact with the project definition parameter.
plugins/plugin-storage/src/storage/transformers/web.ts (1)
90-97: Consider making default category values configurableThe hardcoded defaults (20MB file size, 'user' role) might not suit all use cases. Consider:
- Making these configurable through plugin settings
- Or deriving them from the storage plugin configuration
Would you like me to suggest an approach for making these defaults configurable?
plugins/plugin-storage/src/storage/core/generators/file-categories/file-categories.generator.ts (2)
107-107: Address TODO comment for validation and MIME types.The TODO indicates that validation should be implemented and allowed MIME types should be added to the file category configuration.
Would you like me to help implement the validation logic and add MIME type support to the file category creation, or open a new issue to track this task?
104-122: Consider extracting authorization logic for better readability.While the implementation is correct, extracting the authorization object construction into a helper function would improve readability and maintainability.
+ const authorizationConfig = category.authorize.uploadRoles.length > 0 + ? tsTemplate`{ + upload: ({ auth }) => auth.hasSomeRole(${TsCodeUtils.mergeFragmentsAsArrayPresorted( + category.authorize.uploadRoles.map(quot).sort(), + )}) + }` + : undefined; + fileCategoryFragments.set( category.name, tsTemplate` export const ${getFileCategoryExportName(category.name)} = ${storageModuleImports.createFileCategory.fragment()}(${TsCodeUtils.mergeFragmentsAsObject( { // TODO [2025-07-13]: Remove once validation kicks in and add allowed Mime Types name: quot(constantCase(category.name)), maxFileSize: tsTemplate`${storageModuleImports.FileSize.fragment()}.MB(${category.maxFileSizeMb.toString()})`, - authorize: - category.authorize.uploadRoles.length > 0 - ? tsTemplate`{ - upload: ({ auth }) => auth.hasSomeRole(${TsCodeUtils.mergeFragmentsAsArrayPresorted( - category.authorize.uploadRoles.map(quot).sort(), - )}) - }` - : undefined, + authorize: authorizationConfig, adapter: quot(category.adapter), referencedByRelation: quot(category.referencedByRelation), }, )})`, );
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (22)
packages/project-builder-lib/src/plugins/migrations/run-migrations.ts(1 hunks)packages/project-builder-lib/src/plugins/spec/config-spec.ts(1 hunks)packages/project-builder-web/src/routes/data/models/-components/new-model-dialog.tsx(3 hunks)packages/tools/tsconfig.vite.lib.json(1 hunks)plugins/plugin-storage/src/generators/fastify/prisma-file-transformer/prisma-file-transformer.generator.ts(2 hunks)plugins/plugin-storage/src/generators/fastify/storage-module/extractor.json(7 hunks)plugins/plugin-storage/src/generators/fastify/storage-module/storage-module.generator.ts(6 hunks)plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/utils/mime.ts(1 hunks)plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/utils/validate-file-upload-options.ts(1 hunks)plugins/plugin-storage/src/storage/admin-crud/admin-crud-input-form.tsx(2 hunks)plugins/plugin-storage/src/storage/admin-crud/node.ts(3 hunks)plugins/plugin-storage/src/storage/core/components/category-editor-form.tsx(0 hunks)plugins/plugin-storage/src/storage/core/components/storage-config.tsx(0 hunks)plugins/plugin-storage/src/storage/core/generators/file-categories/file-categories.generator.ts(1 hunks)plugins/plugin-storage/src/storage/core/node.ts(2 hunks)plugins/plugin-storage/src/storage/core/schema/migrations.ts(2 hunks)plugins/plugin-storage/src/storage/core/schema/plugin-definition.ts(0 hunks)plugins/plugin-storage/src/storage/transformers/common.ts(1 hunks)plugins/plugin-storage/src/storage/transformers/components/file-transformer-form.tsx(3 hunks)plugins/plugin-storage/src/storage/transformers/node.ts(3 hunks)plugins/plugin-storage/src/storage/transformers/schema/file-transformer.schema.ts(3 hunks)plugins/plugin-storage/src/storage/transformers/web.ts(4 hunks)
💤 Files with no reviewable changes (3)
- plugins/plugin-storage/src/storage/core/components/storage-config.tsx
- plugins/plugin-storage/src/storage/core/schema/plugin-definition.ts
- plugins/plugin-storage/src/storage/core/components/category-editor-form.tsx
✅ Files skipped from review due to trivial changes (1)
- plugins/plugin-storage/src/storage/transformers/common.ts
🚧 Files skipped from review as they are similar to previous changes (4)
- packages/tools/tsconfig.vite.lib.json
- plugins/plugin-storage/src/generators/fastify/prisma-file-transformer/prisma-file-transformer.generator.ts
- packages/project-builder-web/src/routes/data/models/-components/new-model-dialog.tsx
- plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/utils/validate-file-upload-options.ts
🧰 Additional context used
📓 Path-based instructions (6)
**/*.{ts,tsx}
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- CLAUDE.md
**/*
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- CLAUDE.md
{packages,plugins}/**/*.{ts,tsx}
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- .cursor/rules/code-style.mdc
**/*.tsx
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- CLAUDE.md
plugins/*/**/*.tsx
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- CLAUDE.md
plugins/plugin-*/**/*.tsx
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- plugins/CLAUDE.md
🧠 Learnings (13)
packages/project-builder-lib/src/plugins/spec/config-spec.ts (6)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Prefer functional programming patterns
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use camelCase for variables and functions
Learnt from: kingston
PR: halfdomelabs/baseplate#571
File: packages/core-generators/src/renderers/extractor/plugins/typed-templates-file.ts:102-106
Timestamp: 2025-06-11T18:31:22.247Z
Learning: For `templateExtractorBarrelExportPlugin.addGeneratedBarrelExport`, the generated barrel exports are written into `generated/index.ts`, therefore the `moduleSpecifier` must be specified relative to that file (e.g., `./typed-templates.js`), not the project root.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : All functions (excluding one-liner arrow functions) require explicit return types
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use PascalCase for types and classes
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Extract repeated components into distinct functions or components where applicable
plugins/plugin-storage/src/storage/admin-crud/admin-crud-input-form.tsx (8)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : If a particular interface or type is not exported, change the file so it is exported
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to plugins/*/**/*.tsx : In plugins, prefix all Tailwind classes with the plugin name (e.g., `auth-`, `storage-`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use PascalCase for types and classes
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Prefer functional programming patterns
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use camelCase for variables and functions
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Node 16 module resolution - include file extensions in imports (`.js`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : TypeScript with strict type checking
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
plugins/plugin-storage/src/storage/core/node.ts (10)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Extract repeated components into distinct functions or components where applicable
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to plugins/*/**/*.tsx : In plugins, prefix all Tailwind classes with the plugin name (e.g., `auth-`, `storage-`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Prefer functional programming patterns
Learnt from: kingston
PR: halfdomelabs/baseplate#571
File: packages/core-generators/src/renderers/extractor/plugins/typed-templates-file.ts:102-106
Timestamp: 2025-06-11T18:31:22.247Z
Learning: For `templateExtractorBarrelExportPlugin.addGeneratedBarrelExport`, the generated barrel exports are written into `generated/index.ts`, therefore the `moduleSpecifier` must be specified relative to that file (e.g., `./typed-templates.js`), not the project root.
Learnt from: kingston
PR: halfdomelabs/baseplate#428
File: packages/project-builder-server/src/sync/index.ts:5-5
Timestamp: 2025-01-23T09:12:46.178Z
Learning: Avoid importing directly from 'dist' directories. Instead, expose functionality through the package's public API and import from the main package entry point.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Sort imports by group: external libs first, then local imports
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.tsx : Use ShadCN-based components from `@baseplate-dev/ui-components` instead of creating custom ones
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use PascalCase for types and classes
Learnt from: kingston
PR: halfdomelabs/baseplate#521
File: plugins/baseplate-plugin-storage/src/generators/react/upload-components/upload-components.generator.ts:108-112
Timestamp: 2025-05-05T06:37:43.106Z
Learning: The template extractor in the baseplate codebase can automatically infer and determine the necessary import map providers for certain templates, making explicit specification of importMapProviders unnecessary in those cases.
plugins/plugin-storage/src/storage/transformers/components/file-transformer-form.tsx (8)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Extract repeated components into distinct functions or components where applicable
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to plugins/*/**/*.tsx : In plugins, prefix all Tailwind classes with the plugin name (e.g., `auth-`, `storage-`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use PascalCase for types and classes
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : If a particular interface or type is not exported, change the file so it is exported
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.tsx : Use ShadCN-based components from `@baseplate-dev/ui-components` instead of creating custom ones
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use camelCase for variables and functions
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Prefer functional programming patterns
plugins/plugin-storage/src/storage/transformers/schema/file-transformer.schema.ts (1)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
plugins/plugin-storage/src/storage/admin-crud/node.ts (5)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Prefer functional programming patterns
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Extract repeated components into distinct functions or components where applicable
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to plugins/*/**/*.tsx : In plugins, prefix all Tailwind classes with the plugin name (e.g., `auth-`, `storage-`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.tsx : Use ShadCN-based components from `@baseplate-dev/ui-components` instead of creating custom ones
plugins/plugin-storage/src/storage/core/schema/migrations.ts (6)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use PascalCase for types and classes
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to plugins/*/**/*.tsx : In plugins, prefix all Tailwind classes with the plugin name (e.g., `auth-`, `storage-`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use camelCase for variables and functions
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Prefer functional programming patterns
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Extract repeated components into distinct functions or components where applicable
plugins/plugin-storage/src/storage/transformers/node.ts (8)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Extract repeated components into distinct functions or components where applicable
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Prefer functional programming patterns
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to plugins/*/**/*.tsx : In plugins, prefix all Tailwind classes with the plugin name (e.g., `auth-`, `storage-`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use camelCase for variables and functions
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Node 16 module resolution - include file extensions in imports (`.js`)
Learnt from: kingston
PR: halfdomelabs/baseplate#505
File: packages/create-project/tsconfig.json:6-6
Timestamp: 2025-04-21T06:32:22.476Z
Learning: Since TypeScript 4.1, baseUrl is not required for paths mapping in tsconfig.json. Removing baseUrl and using explicit relative paths with "./" prefix (e.g., changing "@src/*": ["src/*"] to "@src/*": ["./src/*"]) prevents bare path imports from node_modules while maintaining path alias functionality.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
Learnt from: kingston
PR: halfdomelabs/baseplate#571
File: packages/core-generators/src/renderers/extractor/plugins/typed-templates-file.ts:102-106
Timestamp: 2025-06-11T18:31:22.247Z
Learning: For `templateExtractorBarrelExportPlugin.addGeneratedBarrelExport`, the generated barrel exports are written into `generated/index.ts`, therefore the `moduleSpecifier` must be specified relative to that file (e.g., `./typed-templates.js`), not the project root.
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/utils/mime.ts (5)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.unit.test.ts : Unit tests use `.unit.test.ts` suffix
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use PascalCase for types and classes
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use camelCase for variables and functions
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: plugins/CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:58.487Z
Learning: Applies to plugins/plugin-*/**/*.tsx : All CSS classes used in `className` attributes within plugin components MUST be prefixed with the plugin name to avoid style conflicts.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to plugins/*/**/*.tsx : In plugins, prefix all Tailwind classes with the plugin name (e.g., `auth-`, `storage-`)
plugins/plugin-storage/src/storage/core/generators/file-categories/file-categories.generator.ts (5)
Learnt from: kingston
PR: halfdomelabs/baseplate#571
File: packages/core-generators/src/renderers/extractor/plugins/typed-templates-file.ts:102-106
Timestamp: 2025-06-11T18:31:22.247Z
Learning: For `templateExtractorBarrelExportPlugin.addGeneratedBarrelExport`, the generated barrel exports are written into `generated/index.ts`, therefore the `moduleSpecifier` must be specified relative to that file (e.g., `./typed-templates.js`), not the project root.
Learnt from: kingston
PR: halfdomelabs/baseplate#521
File: packages/react-generators/src/generators/admin/admin-crud-edit/admin-crud-edit.generator.ts:90-94
Timestamp: 2025-05-05T06:36:50.687Z
Learning: In this codebase, import paths can include `.ts` extensions, and the `resolveModuleSpecifier` function will handle them appropriately. There's no need to strip file extensions before passing paths to functions like `TsCodeUtils.importFragment`.
Learnt from: kingston
PR: halfdomelabs/baseplate#592
File: plugins/plugin-auth/src/auth0/generators/react/auth0-hooks/templates/src/hooks/use-required-user-id.ts:1-2
Timestamp: 2025-07-07T18:24:17.522Z
Learning: Files under templates/** directories can use `// @ts-nocheck` because they are templates meant for code generation, not direct type checking.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Extract repeated components into distinct functions or components where applicable
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
plugins/plugin-storage/src/generators/fastify/storage-module/storage-module.generator.ts (14)
Learnt from: kingston
PR: halfdomelabs/baseplate#571
File: packages/core-generators/src/renderers/extractor/plugins/typed-templates-file.ts:102-106
Timestamp: 2025-06-11T18:31:22.247Z
Learning: For `templateExtractorBarrelExportPlugin.addGeneratedBarrelExport`, the generated barrel exports are written into `generated/index.ts`, therefore the `moduleSpecifier` must be specified relative to that file (e.g., `./typed-templates.js`), not the project root.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Extract repeated components into distinct functions or components where applicable
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Prefer functional programming patterns
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{unit,int}.test.ts : Always import vitest globals explicitly (describe, it, expect)
Learnt from: kingston
PR: halfdomelabs/baseplate#539
File: scripts/check-changesets.ts:10-13
Timestamp: 2025-05-08T12:56:59.222Z
Learning: Node.js 20.12.0 and above include `globSync` in the core `node:fs` module, so `import { promises as fs, globSync } from 'node:fs';` is valid syntax in projects using these Node.js versions.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use camelCase for variables and functions
Learnt from: kingston
PR: halfdomelabs/baseplate#428
File: packages/project-builder-server/src/sync/index.ts:5-5
Timestamp: 2025-01-23T09:12:46.178Z
Learning: Avoid importing directly from 'dist' directories. Instead, expose functionality through the package's public API and import from the main package entry point.
Learnt from: kingston
PR: halfdomelabs/baseplate#539
File: scripts/check-changesets.ts:10-13
Timestamp: 2025-05-08T12:56:59.222Z
Learning: Node.js 22.0.0 and later versions include both `glob` and `globSync` functionality in the core `node:fs` module, making `import { promises as fs, globSync } from 'node:fs';` valid syntax.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use PascalCase for types and classes
Learnt from: kingston
PR: halfdomelabs/baseplate#592
File: plugins/plugin-auth/src/auth0/generators/react/auth0-hooks/templates/src/hooks/use-required-user-id.ts:1-2
Timestamp: 2025-07-07T18:24:17.522Z
Learning: Files under templates/** directories can use `// @ts-nocheck` because they are templates meant for code generation, not direct type checking.
Learnt from: kingston
PR: halfdomelabs/baseplate#521
File: packages/react-generators/src/generators/admin/admin-crud-edit/admin-crud-edit.generator.ts:90-94
Timestamp: 2025-05-05T06:36:50.687Z
Learning: In this codebase, import paths can include `.ts` extensions, and the `resolveModuleSpecifier` function will handle them appropriately. There's no need to strip file extensions before passing paths to functions like `TsCodeUtils.importFragment`.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Include absolute paths in import statements via tsconfig paths (`@src/` is the alias for `src/`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Node 16 module resolution - include file extensions in imports (`.js`)
plugins/plugin-storage/src/storage/transformers/web.ts (12)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use PascalCase for types and classes
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use camelCase for variables and functions
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : If a particular interface or type is not exported, change the file so it is exported
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Prefer functional programming patterns
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to plugins/*/**/*.tsx : In plugins, prefix all Tailwind classes with the plugin name (e.g., `auth-`, `storage-`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Use camelCase for variables/functions, PascalCase for types/classes
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Extract repeated components into distinct functions or components where applicable
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use TypeScript with strict type checking enabled
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Node 16 module resolution - include file extensions in imports (`.js`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : TypeScript with strict type checking
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.unit.test.ts : Unit tests use `.unit.test.ts` suffix
plugins/plugin-storage/src/generators/fastify/storage-module/extractor.json (22)
Learnt from: kingston
PR: halfdomelabs/baseplate#571
File: packages/core-generators/src/renderers/extractor/plugins/typed-templates-file.ts:102-106
Timestamp: 2025-06-11T18:31:22.247Z
Learning: For `templateExtractorBarrelExportPlugin.addGeneratedBarrelExport`, the generated barrel exports are written into `generated/index.ts`, therefore the `moduleSpecifier` must be specified relative to that file (e.g., `./typed-templates.js`), not the project root.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Extract repeated components into distinct functions or components where applicable
Learnt from: kingston
PR: halfdomelabs/baseplate#521
File: packages/react-generators/src/generators/admin/admin-crud-list/admin-crud-list.generator.ts:163-166
Timestamp: 2025-05-05T06:37:51.001Z
Learning: For certain templates in the codebase, the `importMapProviders` property is not explicitly required as the template extractor will automatically determine and infer the necessary import map providers.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : If a particular interface or type is not exported, change the file so it is exported
Learnt from: kingston
PR: halfdomelabs/baseplate#592
File: plugins/plugin-auth/src/auth0/generators/react/auth0-hooks/templates/src/hooks/use-required-user-id.ts:1-2
Timestamp: 2025-07-07T18:24:17.522Z
Learning: Files under templates/** directories can use `// @ts-nocheck` because they are templates meant for code generation, not direct type checking.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use camelCase for variables and functions
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Prefer functional programming patterns
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Node 16 module resolution - include file extensions in imports (`.js`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use PascalCase for types and classes
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to plugins/*/**/*.tsx : In plugins, prefix all Tailwind classes with the plugin name (e.g., `auth-`, `storage-`)
Learnt from: kingston
PR: halfdomelabs/baseplate#505
File: packages/create-project/tsconfig.json:6-6
Timestamp: 2025-04-21T06:32:22.476Z
Learning: Since TypeScript 4.1, baseUrl is not required for paths mapping in tsconfig.json. Removing baseUrl and using explicit relative paths with "./" prefix (e.g., changing "@src/*": ["src/*"] to "@src/*": ["./src/*"]) prevents bare path imports from node_modules while maintaining path alias functionality.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Include absolute paths in import statements via tsconfig paths (`@src/` is the alias for `src/`)
Learnt from: kingston
PR: halfdomelabs/baseplate#505
File: packages/create-project/tsconfig.json:6-6
Timestamp: 2025-04-21T06:32:22.476Z
Learning: Since TypeScript 4.1, baseUrl is not required for paths mapping when using explicit relative paths (with "./"). Removing baseUrl from tsconfig.json while updating paths to use relative paths (e.g., changing "@src/*": ["src/*"] to "@src/*": ["./src/*"]) prevents bare path imports from node_modules while maintaining path alias functionality.
Learnt from: kingston
PR: halfdomelabs/baseplate#562
File: plugins/plugin-auth/package.json:32-36
Timestamp: 2025-06-03T09:11:29.651Z
Learning: With TypeScript project references, TypeScript compilation is watched from the root level using "watch:tsc:root" script, so individual packages no longer need to include their "tsc:watch" scripts in their local "watch" commands. The local "tsc:watch" scripts are renamed from "watch:tsc" but are not meant to be run as part of the package's watch command since TypeScript watching is handled centrally at the workspace root.
Learnt from: kingston
PR: halfdomelabs/baseplate#521
File: plugins/baseplate-plugin-storage/src/generators/react/upload-components/upload-components.generator.ts:108-112
Timestamp: 2025-05-05T06:37:43.106Z
Learning: The template extractor in the baseplate codebase can automatically infer and determine the necessary import map providers for certain templates, making explicit specification of importMapProviders unnecessary in those cases.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.unit.test.ts : Unit tests use `.unit.test.ts` suffix
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{unit,int}.test.ts : Always import vitest globals explicitly (describe, it, expect)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{unit,int}.test.ts : Unit tests use `.unit.test.ts` suffix, integration tests use `.int.test.ts`
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/tests.mdc:0-0
Timestamp: 2025-06-30T11:52:28.745Z
Learning: Applies to **/*.unit.test.{ts,tsx} : Unit tests are colocated with source files using `.unit.test.ts` suffix
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/tests.mdc:0-0
Timestamp: 2025-06-30T11:52:28.745Z
Learning: Applies to **/*.test.{ts,tsx} : For file system operations in tests, use memfs and mock 'node:fs' and 'node:fs/promises' with vi.mock
Learnt from: kingston
PR: halfdomelabs/baseplate#521
File: packages/react-generators/src/generators/admin/admin-crud-edit/admin-crud-edit.generator.ts:90-94
Timestamp: 2025-05-05T06:36:50.687Z
Learning: In this codebase, import paths can include `.ts` extensions, and the `resolveModuleSpecifier` function will handle them appropriately. There's no need to strip file extensions before passing paths to functions like `TsCodeUtils.importFragment`.
🧬 Code Graph Analysis (7)
plugins/plugin-storage/src/storage/admin-crud/admin-crud-input-form.tsx (1)
plugins/plugin-storage/src/storage/transformers/schema/file-transformer.schema.ts (1)
FileTransformerDefinition(55-57)
plugins/plugin-storage/src/storage/transformers/components/file-transformer-form.tsx (3)
plugins/plugin-storage/src/storage/transformers/schema/file-transformer.schema.ts (1)
FileTransformerDefinition(55-57)packages/project-builder-lib/src/web/hooks/use-project-definition.ts (1)
useProjectDefinition(80-88)packages/project-builder-lib/src/plugins/spec/auth-config-spec.ts (1)
authConfigSpec(26-29)
plugins/plugin-storage/src/storage/transformers/schema/file-transformer.schema.ts (4)
packages/utils/src/validators/case-validators.ts (1)
CASE_VALIDATORS(23-48)packages/project-builder-lib/src/schema/auth/index.ts (1)
authRoleEntityType(3-3)plugins/plugin-storage/src/storage/core/schema/plugin-definition.ts (1)
storageAdapterEntityType(12-14)packages/project-builder-lib/src/schema/creator/infer-types.ts (1)
InferInput(7-9)
plugins/plugin-storage/src/storage/admin-crud/node.ts (3)
packages/project-builder-lib/src/compiler/admin-crud-input-spec.ts (1)
AdminCrudInputCompiler(12-25)plugins/plugin-storage/src/storage/admin-crud/types.ts (1)
AdminCrudFileInputConfig(21-23)plugins/plugin-storage/src/storage/transformers/schema/file-transformer.schema.ts (1)
FileTransformerDefinition(55-57)
plugins/plugin-storage/src/storage/core/schema/migrations.ts (1)
packages/project-builder-lib/src/schema/models/types.ts (1)
modelTransformerEntityType(27-30)
plugins/plugin-storage/src/storage/transformers/node.ts (1)
plugins/plugin-storage/src/storage/transformers/schema/file-transformer.schema.ts (1)
FileTransformerDefinition(55-57)
plugins/plugin-storage/src/storage/transformers/web.ts (4)
plugins/plugin-storage/src/storage/transformers/schema/file-transformer.schema.ts (1)
FileTransformerDefinition(55-57)packages/project-builder-lib/src/definition/plugins/plugin-utils.ts (1)
PluginUtils(75-80)plugins/plugin-storage/src/storage/core/schema/plugin-definition.ts (1)
StoragePluginDefinition(47-49)packages/project-builder-lib/src/schema/models/types.ts (1)
modelTransformerEntityType(27-30)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Socket Security: Pull Request Alerts
🔇 Additional comments (26)
plugins/plugin-storage/src/generators/fastify/storage-module/templates/module/utils/mime.ts (5)
6-8: LGTM: Content type parsing is correctly implemented.The function properly extracts the MIME type from content-type headers by splitting on semicolon and trimming whitespace, which correctly handles cases like
"text/html; charset=UTF-8".
10-21: LGTM: Robust encoding extraction with proper validation.The implementation correctly:
- Uses regex to extract charset parameter from content-type headers
- Validates the charset against Node.js supported encodings using
Buffer.isEncoding- Provides a sensible fallback to 'utf-8' for unsupported charsets
23-31: LGTM: Error class is now correctly named.The error class name and the
this.nameproperty are now consistent, resolving the previous naming mismatch issue. The class properly extends Error and includes useful context viaexpectedFileExtensions.
52-54: LGTM: File extension validation is appropriately strict.The validation correctly ensures files have extensions, which is essential for proper MIME type matching and file handling.
57-60: LGTM: Comprehensive error messaging for extension mismatches.The error provides clear, actionable feedback by listing all valid extensions for the given MIME type, making it easy for developers to understand what went wrong.
plugins/plugin-storage/src/storage/admin-crud/admin-crud-input-form.tsx (1)
7-7: Type migration looks good!The update from
FileTransformerConfigtoFileTransformerDefinitioncorrectly aligns with the new transformer schema structure.Also applies to: 17-17
packages/project-builder-lib/src/plugins/spec/config-spec.ts (1)
10-19: Well-documented API change with appropriate TODO.The JSDoc clearly explains the new migration API and parameters. The TODO appropriately highlights the need for a safer mutation pattern in the future.
plugins/plugin-storage/src/storage/core/node.ts (1)
50-96: Excellent refactor to dynamic file category generation!This change significantly improves the architecture by:
- Eliminating duplicate configuration between categories and transformers
- Dynamically deriving categories from transformer definitions
- Properly grouping by feature for better organization
- Including validation for missing relations
The implementation correctly handles the extraction and transformation of data.
plugins/plugin-storage/src/storage/transformers/components/file-transformer-form.tsx (2)
4-14: Well-structured form setup with proper type safety.The imports are correctly organized and the form control typing aligns with the new
FileTransformerDefinitionschema. The dynamic retrieval of auth roles and storage adapters provides good user experience.Also applies to: 27-31, 48-62
74-121: Excellent UI implementation for file category configuration!The form section is well-organized with:
- Clear visual hierarchy and grouping
- Helpful descriptions and placeholders
- Proper Tailwind class prefixing with
storage:- Responsive grid layout
- Correct use of ShadCN UI components
plugins/plugin-storage/src/storage/transformers/schema/file-transformer.schema.ts (1)
25-40: Well-structured category schema with proper validationThe category object properly encapsulates all file category metadata with appropriate validation:
- CONSTANT_CASE for category names ensures consistency
- Entity references with RESTRICT delete policy prevent orphaned data
- Authorization roles are properly typed
plugins/plugin-storage/src/storage/admin-crud/node.ts (2)
17-52: Clean refactor removing plugin configuration dependencyThe simplified approach of accessing category directly from the transformer definition is cleaner and aligns well with the registry-based pattern. The type assertion and error handling remain robust.
14-14: Add explicit return type to functionPer the coding guidelines, all functions (excluding one-liner arrow functions) require explicit return types.
-function buildFileTransformerCompiler(): AdminCrudInputCompiler<AdminCrudFileInputConfig> { +function buildFileTransformerCompiler(): AdminCrudInputCompiler<AdminCrudFileInputConfig> {⛔ Skipped due to learnings
Learnt from: CR PR: halfdomelabs/baseplate#0 File: CLAUDE.md:0-0 Timestamp: 2025-06-30T11:51:48.395Z Learning: Applies to **/*.{ts,tsx} : Specify explicit return types on all functionsLearnt from: CR PR: halfdomelabs/baseplate#0 File: .cursor/rules/code-style.mdc:0-0 Timestamp: 2025-06-30T11:52:11.055Z Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : All functions (excluding one-liner arrow functions) require explicit return typesLearnt from: CR PR: halfdomelabs/baseplate#0 File: CLAUDE.md:0-0 Timestamp: 2025-06-30T11:51:48.395Z Learning: Applies to **/*.{ts,tsx} : Always include return types on top-level functions including React components (`React.ReactElement`)Learnt from: CR PR: halfdomelabs/baseplate#0 File: CLAUDE.md:0-0 Timestamp: 2025-06-30T11:51:48.395Z Learning: Applies to **/*.{ts,tsx} : TypeScript with strict type checkingLearnt from: CR PR: halfdomelabs/baseplate#0 File: .cursor/rules/code-style.mdc:0-0 Timestamp: 2025-06-30T11:52:11.055Z Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Prefer functional programming patternsLearnt from: CR PR: halfdomelabs/baseplate#0 File: CLAUDE.md:0-0 Timestamp: 2025-06-30T11:51:48.395Z Learning: Applies to **/*.{ts,tsx} : If a particular interface or type is not exported, change the file so it is exportedLearnt from: CR PR: halfdomelabs/baseplate#0 File: .cursor/rules/code-style.mdc:0-0 Timestamp: 2025-06-30T11:52:11.055Z Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Extract repeated components into distinct functions or components where applicableLearnt from: CR PR: halfdomelabs/baseplate#0 File: .cursor/rules/code-style.mdc:0-0 Timestamp: 2025-06-30T11:52:11.055Z Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use TypeScript with strict type checking enabledLearnt from: kingston PR: halfdomelabs/baseplate#592 File: plugins/plugin-auth/src/auth0/generators/react/auth0-hooks/templates/src/hooks/use-required-user-id.ts:1-2 Timestamp: 2025-07-07T18:24:17.522Z Learning: Files under templates/** directories can use `// @ts-nocheck` because they are templates meant for code generation, not direct type checking.Learnt from: CR PR: halfdomelabs/baseplate#0 File: .cursor/rules/code-style.mdc:0-0 Timestamp: 2025-06-30T11:52:11.055Z Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use camelCase for variables and functionsplugins/plugin-storage/src/storage/transformers/node.ts (2)
15-33: Excellent simplification with proper feature isolationThe direct destructuring of category and addition of featureId properly isolates file transformers by feature, supporting the modular architecture.
12-12: Add explicit return type to functionPer the coding guidelines, all functions require explicit return types.
-function buildFileTransformerCompiler(): ModelTransformerCompiler<FileTransformerDefinition> { +function buildFileTransformerCompiler(): ModelTransformerCompiler<FileTransformerDefinition> {⛔ Skipped due to learnings
Learnt from: CR PR: halfdomelabs/baseplate#0 File: CLAUDE.md:0-0 Timestamp: 2025-06-30T11:51:48.395Z Learning: Applies to **/*.{ts,tsx} : Specify explicit return types on all functionsLearnt from: CR PR: halfdomelabs/baseplate#0 File: .cursor/rules/code-style.mdc:0-0 Timestamp: 2025-06-30T11:52:11.055Z Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : All functions (excluding one-liner arrow functions) require explicit return typesLearnt from: CR PR: halfdomelabs/baseplate#0 File: CLAUDE.md:0-0 Timestamp: 2025-06-30T11:51:48.395Z Learning: Applies to **/*.{ts,tsx} : Always include return types on top-level functions including React components (`React.ReactElement`)Learnt from: CR PR: halfdomelabs/baseplate#0 File: CLAUDE.md:0-0 Timestamp: 2025-06-30T11:51:48.395Z Learning: Applies to **/*.{ts,tsx} : TypeScript with strict type checkingLearnt from: CR PR: halfdomelabs/baseplate#0 File: CLAUDE.md:0-0 Timestamp: 2025-06-30T11:51:48.395Z Learning: Applies to **/*.{ts,tsx} : If a particular interface or type is not exported, change the file so it is exportedLearnt from: CR PR: halfdomelabs/baseplate#0 File: .cursor/rules/code-style.mdc:0-0 Timestamp: 2025-06-30T11:52:11.055Z Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Prefer functional programming patternsLearnt from: kingston PR: halfdomelabs/baseplate#592 File: plugins/plugin-auth/src/auth0/generators/react/auth0-hooks/templates/src/hooks/use-required-user-id.ts:1-2 Timestamp: 2025-07-07T18:24:17.522Z Learning: Files under templates/** directories can use `// @ts-nocheck` because they are templates meant for code generation, not direct type checking.Learnt from: CR PR: halfdomelabs/baseplate#0 File: .cursor/rules/code-style.mdc:0-0 Timestamp: 2025-06-30T11:52:11.055Z Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Extract repeated components into distinct functions or components where applicableLearnt from: CR PR: halfdomelabs/baseplate#0 File: .cursor/rules/code-style.mdc:0-0 Timestamp: 2025-06-30T11:52:11.055Z Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use TypeScript with strict type checking enabledplugins/plugin-storage/src/storage/core/schema/migrations.ts (1)
26-148: Well-designed migration with comprehensive error handlingThe migration properly:
- Handles both existing and new transformers
- Converts category names to CONSTANT_CASE for consistency
- Maintains data integrity with proper error messages
- Uses typed interfaces for safety
The logic correctly maps old category structure to the new transformer-embedded format.
plugins/plugin-storage/src/storage/transformers/web.ts (1)
75-81: Good defensive programming with relation validationThe added validation ensures the relation exists before using it, preventing runtime errors.
plugins/plugin-storage/src/storage/core/generators/file-categories/file-categories.generator.ts (3)
1-38: Imports and schema definition look good!The imports correctly use
.jsextensions following Node 16 module resolution, and the schema properly validates file category structure with appropriate constraints.
80-88: Add explicit return type to nested function.The
getFileCategoryImportFragmentfunction should have an explicit return type.- function getFileCategoryImportFragment(name: string): TsCodeFragment { + function getFileCategoryImportFragment(name: string): TsCodeFragment {Note: The function already has the correct return type, so no change is needed here.
47-49: Add explicit return type to function.According to the coding guidelines, all functions (excluding one-liner arrow functions) require explicit return types.
-function getFileCategoryExportName(name: string) { +function getFileCategoryExportName(name: string): string { return `${camelCase(name)}FileCategory`; }⛔ Skipped due to learnings
Learnt from: CR PR: halfdomelabs/baseplate#0 File: CLAUDE.md:0-0 Timestamp: 2025-06-30T11:51:48.395Z Learning: Applies to **/*.{ts,tsx} : Specify explicit return types on all functionsLearnt from: CR PR: halfdomelabs/baseplate#0 File: .cursor/rules/code-style.mdc:0-0 Timestamp: 2025-06-30T11:52:11.055Z Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : All functions (excluding one-liner arrow functions) require explicit return typesLearnt from: CR PR: halfdomelabs/baseplate#0 File: CLAUDE.md:0-0 Timestamp: 2025-06-30T11:51:48.395Z Learning: Applies to **/*.{ts,tsx} : If a particular interface or type is not exported, change the file so it is exportedLearnt from: CR PR: halfdomelabs/baseplate#0 File: CLAUDE.md:0-0 Timestamp: 2025-06-30T11:51:48.395Z Learning: Applies to **/*.{ts,tsx} : Always include return types on top-level functions including React components (`React.ReactElement`)Learnt from: CR PR: halfdomelabs/baseplate#0 File: CLAUDE.md:0-0 Timestamp: 2025-06-30T11:51:48.395Z Learning: Applies to **/*.{ts,tsx} : Use camelCase for variables/functions, PascalCase for types/classesLearnt from: CR PR: halfdomelabs/baseplate#0 File: .cursor/rules/code-style.mdc:0-0 Timestamp: 2025-06-30T11:52:11.055Z Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use camelCase for variables and functionsLearnt from: CR PR: halfdomelabs/baseplate#0 File: CLAUDE.md:0-0 Timestamp: 2025-06-30T11:51:48.395Z Learning: Applies to **/*.test.ts : Use descriptive test names that explain what is being testedLearnt from: CR PR: halfdomelabs/baseplate#0 File: CLAUDE.md:0-0 Timestamp: 2025-06-30T11:51:48.395Z Learning: Applies to **/*.{ts,tsx} : TypeScript with strict type checkingLearnt from: CR PR: halfdomelabs/baseplate#0 File: .cursor/rules/code-style.mdc:0-0 Timestamp: 2025-06-30T11:52:11.055Z Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use PascalCase for types and classesLearnt from: CR PR: halfdomelabs/baseplate#0 File: .cursor/rules/code-style.mdc:0-0 Timestamp: 2025-06-30T11:52:11.055Z Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Prefer functional programming patternsplugins/plugin-storage/src/generators/fastify/storage-module/storage-module.generator.ts (3)
57-72: Config provider setup looks good!The new registry-based pattern using
createConfigProviderTaskwith a Map for file categories aligns well with the PR's modularization objectives.
247-249: Correct implementation of publicUrl rename.The change from
hostedUrltopublicUrlis properly implemented and aligns with the adapter interface updates mentioned in the PR summary.
279-286: Proper implementation of registry-based file categories.The code correctly retrieves file categories from the config provider and passes them as an array of fragments, implementing the new modular pattern effectively.
plugins/plugin-storage/src/generators/fastify/storage-module/extractor.json (3)
24-49: Well-structured config templates for registry pattern.The new
config-adaptersandconfig-categoriestemplates provide excellent type-safe exports including lookup functions (getCategoryByName,getCategoryByNameOrThrow) that support the new registry-based file category system.
50-109: Schema updates properly implement enum-based categories.The changes from string-based to enum-based file categories (renaming to
file-category.enum.ts) and addition of thepublic-urlfield enhance type safety and align with the GraphQL schema improvements mentioned in the PR.
182-287: Service and utility reorganization improves modularity.The updates to service templates (especially
validate-file-input) and the separation of types from utilities demonstrate good architectural practices, supporting the new validation patterns and authorization model.
| modelLocalRelationEntityType, | ||
| modelTransformerEntityType, | ||
| } from '@baseplate-dev/project-builder-lib'; | ||
| import { CASE_VALIDATORS } from '@baseplate-dev/utils'; |
There was a problem hiding this comment.
Add .js extension to import statement
Per the coding guidelines, always use .js extensions in imports, even for TypeScript files.
-import { CASE_VALIDATORS } from '@baseplate-dev/utils';
+import { CASE_VALIDATORS } from '@baseplate-dev/utils/index.js';📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| import { CASE_VALIDATORS } from '@baseplate-dev/utils'; | |
| -import { CASE_VALIDATORS } from '@baseplate-dev/utils'; | |
| +import { CASE_VALIDATORS } from '@baseplate-dev/utils/index.js'; |
🤖 Prompt for AI Agents
In
plugins/plugin-storage/src/storage/transformers/schema/file-transformer.schema.ts
at line 11, the import statement for CASE_VALIDATORS is missing the required .js
extension. Update the import path to include the .js extension as per coding
guidelines, changing it to '@baseplate-dev/utils.js'.
| import type { PluginConfigMigration } from '@baseplate-dev/project-builder-lib'; | ||
|
|
||
| import { modelTransformerEntityType } from '@baseplate-dev/project-builder-lib'; | ||
| import { constantCase } from 'es-toolkit'; |
There was a problem hiding this comment.
Add .js extension to import statement
Per the coding guidelines, always include .js extensions in imports.
-import { constantCase } from 'es-toolkit';
+import { constantCase } from 'es-toolkit/index.js';📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| import { constantCase } from 'es-toolkit'; | |
| -import { constantCase } from 'es-toolkit'; | |
| +import { constantCase } from 'es-toolkit/index.js'; |
🤖 Prompt for AI Agents
In plugins/plugin-storage/src/storage/core/schema/migrations.ts at line 4, the
import statement for 'es-toolkit' is missing the '.js' extension. Update the
import to include the '.js' extension as 'es-toolkit.js' to comply with the
coding guidelines requiring explicit file extensions in import statements.
| PluginUtils, | ||
| } from '@baseplate-dev/project-builder-lib'; | ||
| import { modelTransformerWebSpec } from '@baseplate-dev/project-builder-lib/web'; | ||
| import { constantCase } from 'es-toolkit'; |
There was a problem hiding this comment.
Add .js extension to import statement
Per the coding guidelines, always include .js extensions in imports.
-import { constantCase } from 'es-toolkit';
+import { constantCase } from 'es-toolkit/index.js';📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| import { constantCase } from 'es-toolkit'; | |
| -import { constantCase } from 'es-toolkit'; | |
| +import { constantCase } from 'es-toolkit/index.js'; |
🤖 Prompt for AI Agents
In plugins/plugin-storage/src/storage/transformers/web.ts at line 12, the import
statement for 'es-toolkit' is missing the required '.js' extension. Update the
import to include the '.js' extension at the end of the module path to comply
with the coding guidelines.
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
plugins/plugin-storage/src/storage/core/components/storage-definition-editor.tsx (1)
39-43: Add explicit return type to the function.According to the coding guidelines, all functions including React components should have explicit return types.
export function StorageDefinitionEditor({ definition: pluginMetadata, metadata, onSave, -}: WebConfigProps): React.JSX.Element { +}: WebConfigProps): React.ReactElement {
🧹 Nitpick comments (2)
plugins/plugin-storage/src/storage/core/components/adapter-dialog.tsx (1)
56-59: Remove unnecessary type assertion.The type assertion is redundant since
datafrom the form already has the correct type inferred fromAdapterFormData.const onSubmit = handleSubmit((data) => { - onSave(data as StoragePluginDefinitionInput['s3Adapters'][0]); + onSave(data); onOpenChange?.(false); });plugins/plugin-storage/src/storage/core/components/adapter-editor-form.tsx (1)
130-134: Simplify the isNew calculation.The current logic is redundant - it checks if the adapter exists in the array when
adapterToEditis already set from that array.isNew={ - adapterToEdit - ? !adapters.some((a) => a.id === adapterToEdit.id) - : true + !adapterToEdit || !adapters.some((a) => a.id === adapterToEdit.id) }
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
plugins/plugin-storage/package.json(1 hunks)plugins/plugin-storage/src/storage/core/components/adapter-dialog.tsx(1 hunks)plugins/plugin-storage/src/storage/core/components/adapter-editor-form.tsx(1 hunks)plugins/plugin-storage/src/storage/core/components/storage-definition-editor.tsx(5 hunks)plugins/plugin-storage/src/storage/core/web.ts(2 hunks)
✅ Files skipped from review due to trivial changes (1)
- plugins/plugin-storage/src/storage/core/web.ts
🚧 Files skipped from review as they are similar to previous changes (1)
- plugins/plugin-storage/package.json
🧰 Additional context used
📓 Path-based instructions (6)
**/*.{ts,tsx}
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- CLAUDE.md
**/*
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- CLAUDE.md
**/*.tsx
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- CLAUDE.md
plugins/*/**/*.tsx
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- CLAUDE.md
{packages,plugins}/**/*.{ts,tsx}
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- .cursor/rules/code-style.mdc
plugins/plugin-*/**/*.tsx
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- plugins/CLAUDE.md
🧠 Learnings (4)
📓 Common learnings
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to plugins/*/**/*.tsx : In plugins, prefix all Tailwind classes with the plugin name (e.g., `auth-`, `storage-`)
plugins/plugin-storage/src/storage/core/components/storage-definition-editor.tsx (4)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Extract repeated components into distinct functions or components where applicable
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to plugins/*/**/*.tsx : In plugins, prefix all Tailwind classes with the plugin name (e.g., `auth-`, `storage-`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use camelCase for variables and functions
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
plugins/plugin-storage/src/storage/core/components/adapter-dialog.tsx (4)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.tsx : Use ShadCN-based components from `@baseplate-dev/ui-components` instead of creating custom ones
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Extract repeated components into distinct functions or components where applicable
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Prefer functional programming patterns
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
plugins/plugin-storage/src/storage/core/components/adapter-editor-form.tsx (4)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Prefer functional programming patterns
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Extract repeated components into distinct functions or components where applicable
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.tsx : Use ShadCN-based components from `@baseplate-dev/ui-components` instead of creating custom ones
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
🧬 Code Graph Analysis (1)
plugins/plugin-storage/src/storage/core/components/adapter-dialog.tsx (2)
plugins/plugin-storage/src/storage/core/schema/plugin-definition.ts (1)
StoragePluginDefinitionInput(51-53)packages/ui-components/src/components/button/button.tsx (1)
Button(51-51)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Lint
- GitHub Check: test
- GitHub Check: Test E2E
🔇 Additional comments (3)
plugins/plugin-storage/src/storage/core/components/adapter-dialog.tsx (1)
40-48: Add explicit return type to the function.According to the coding guidelines, all functions should have explicit return types.
export function AdapterDialog({ open, onOpenChange, adapter, isNew = false, onSave, asChild, children, -}: AdapterDialogProps): React.JSX.Element { +}: AdapterDialogProps): React.ReactElement {⛔ Skipped due to learnings
Learnt from: CR PR: halfdomelabs/baseplate#0 File: CLAUDE.md:0-0 Timestamp: 2025-06-30T11:51:48.395Z Learning: Applies to **/*.{ts,tsx} : Always include return types on top-level functions including React components (`React.ReactElement`)Learnt from: CR PR: halfdomelabs/baseplate#0 File: CLAUDE.md:0-0 Timestamp: 2025-06-30T11:51:48.395Z Learning: Applies to **/*.{ts,tsx} : Specify explicit return types on all functionsLearnt from: CR PR: halfdomelabs/baseplate#0 File: .cursor/rules/code-style.mdc:0-0 Timestamp: 2025-06-30T11:52:11.055Z Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : All functions (excluding one-liner arrow functions) require explicit return typesLearnt from: CR PR: halfdomelabs/baseplate#0 File: CLAUDE.md:0-0 Timestamp: 2025-06-30T11:51:48.395Z Learning: Applies to **/*.tsx : Use ShadCN-based components from `@baseplate-dev/ui-components` instead of creating custom onesLearnt from: CR PR: halfdomelabs/baseplate#0 File: CLAUDE.md:0-0 Timestamp: 2025-06-30T11:51:48.395Z Learning: Applies to **/*.{ts,tsx} : TypeScript with strict type checkingLearnt from: CR PR: halfdomelabs/baseplate#0 File: .cursor/rules/code-style.mdc:0-0 Timestamp: 2025-06-30T11:52:11.055Z Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Prefer functional programming patternsplugins/plugin-storage/src/storage/core/components/storage-definition-editor.tsx (1)
128-178: Well-structured UI with proper class prefixing.The refactored UI structure using
SectionListcomponents provides better semantic organization, and all Tailwind classes are correctly prefixed withstorage:as required.plugins/plugin-storage/src/storage/core/components/adapter-editor-form.tsx (1)
42-53: Add explicit return type to the function.According to the coding guidelines, all functions (excluding one-liner arrow functions) should have explicit return types.
function handleSaveAdapter( newAdapter: StoragePluginDefinitionInput['s3Adapters'][0], - ): void { + ): void {Wait, it already has
: void. Let me re-check... Yes, it does have the return type. My mistake.
| control: Control<StoragePluginDefinitionInput>; | ||
| } | ||
|
|
||
| function AdapterEditorForm({ className, control }: Props): React.JSX.Element { |
There was a problem hiding this comment.
Add explicit return type to the function.
According to the coding guidelines, all functions should have explicit return types.
-function AdapterEditorForm({ className, control }: Props): React.JSX.Element {
+function AdapterEditorForm({ className, control }: Props): React.ReactElement {📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| function AdapterEditorForm({ className, control }: Props): React.JSX.Element { | |
| -function AdapterEditorForm({ className, control }: Props): React.JSX.Element { | |
| +function AdapterEditorForm({ className, control }: Props): React.ReactElement { |
🤖 Prompt for AI Agents
In plugins/plugin-storage/src/storage/core/components/adapter-editor-form.tsx at
line 29, the AdapterEditorForm function lacks an explicit return type. Add the
explicit return type React.JSX.Element to the function signature to comply with
coding guidelines requiring all functions to have explicit return types.
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
plugins/plugin-storage/src/index.ts(1 hunks)plugins/plugin-storage/src/storage/core/generators/file-categories/file-categories.generator.ts(1 hunks)plugins/plugin-storage/src/storage/core/generators/file-categories/index.ts(1 hunks)plugins/plugin-storage/src/storage/core/generators/index.ts(1 hunks)plugins/plugin-storage/src/storage/core/index.ts(1 hunks)plugins/plugin-storage/src/storage/index.ts(1 hunks)
✅ Files skipped from review due to trivial changes (4)
- plugins/plugin-storage/src/storage/core/index.ts
- plugins/plugin-storage/src/storage/core/generators/file-categories/index.ts
- plugins/plugin-storage/src/storage/index.ts
- plugins/plugin-storage/src/storage/core/generators/index.ts
🚧 Files skipped from review as they are similar to previous changes (1)
- plugins/plugin-storage/src/storage/core/generators/file-categories/file-categories.generator.ts
🧰 Additional context used
📓 Path-based instructions (4)
**/*.{ts,tsx}
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- CLAUDE.md
**/*
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- CLAUDE.md
**/index.{ts,tsx}
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- CLAUDE.md
{packages,plugins}/**/*.{ts,tsx}
Instructions used from:
Sources:
📄 CodeRabbit Inference Engine
- .cursor/rules/code-style.mdc
🧠 Learnings (2)
📓 Common learnings
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to plugins/*/**/*.tsx : In plugins, prefix all Tailwind classes with the plugin name (e.g., `auth-`, `storage-`)
plugins/plugin-storage/src/index.ts (13)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : If a particular interface or type is not exported, change the file so it is exported
Learnt from: kingston
PR: halfdomelabs/baseplate#428
File: packages/project-builder-server/src/sync/index.ts:5-5
Timestamp: 2025-01-23T09:12:46.178Z
Learning: Avoid importing directly from 'dist' directories. Instead, expose functionality through the package's public API and import from the main package entry point.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/index.{ts,tsx} : Prefer barrel exports e.g. `export * from './foo.js'` instead of individual named exports
Learnt from: kingston
PR: halfdomelabs/baseplate#571
File: packages/core-generators/src/renderers/extractor/plugins/typed-templates-file.ts:102-106
Timestamp: 2025-06-11T18:31:22.247Z
Learning: For `templateExtractorBarrelExportPlugin.addGeneratedBarrelExport`, the generated barrel exports are written into `generated/index.ts`, therefore the `moduleSpecifier` must be specified relative to that file (e.g., `./typed-templates.js`), not the project root.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to plugins/*/**/*.tsx : In plugins, prefix all Tailwind classes with the plugin name (e.g., `auth-`, `storage-`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Extract repeated components into distinct functions or components where applicable
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Node 16 module resolution - include file extensions in imports (`.js`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T11:51:48.395Z
Learning: Applies to **/*.{ts,tsx} : Include absolute paths in import statements via tsconfig paths (`@src/` is the alias for `src/`)
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{ts,tsx} : Use camelCase for variables and functions
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/code-style.mdc:0-0
Timestamp: 2025-06-30T11:52:11.055Z
Learning: Applies to {packages,plugins}/**/*.{unit,int}.test.ts : Always import vitest globals explicitly (describe, it, expect)
Learnt from: kingston
PR: halfdomelabs/baseplate#539
File: scripts/check-changesets.ts:10-13
Timestamp: 2025-05-08T12:56:59.222Z
Learning: Node.js 22.0.0 and later versions include both `glob` and `globSync` functionality in the core `node:fs` module, making `import { promises as fs, globSync } from 'node:fs';` valid syntax.
Learnt from: kingston
PR: halfdomelabs/baseplate#539
File: scripts/check-changesets.ts:10-13
Timestamp: 2025-05-08T12:56:59.222Z
Learning: Node.js 20.12.0 and above include `globSync` in the core `node:fs` module, so `import { promises as fs, globSync } from 'node:fs';` is valid syntax in projects using these Node.js versions.
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: .cursor/rules/ui-rules.mdc:0-0
Timestamp: 2025-06-30T11:52:33.318Z
Learning: Applies to *.{tsx},packages/project-builder-web/**,packages/ui-components/** : We use a rough analog of ShadCN components that can be imported from @baseplate-dev/ui-components
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Test E2E
Merged
This was referenced Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
If-None-MatchHTTP header to prevent overwrites during S3 uploads.AdapterDialogcomponent and improved UI for managing adapters and storage definitions.Improvements
Bug Fixes
Refactor
Chores
Tests