refactor: Upgrade Storybook to v9 and replace storybook-dark-mode implementation #609

kingston · 2025-07-14T11:54:07Z

Summary by CodeRabbit

New Features
- Added a custom ESLint rule to detect and automatically fix unused dependencies in generator tasks.
Bug Fixes
- Improved Storybook theming with a new dark mode manager addon and unified theme switching via the global toolbar.
- Ensured toaster notifications render only once per page in Storybook previews.
Refactor
- Migrated Storybook configuration and stories to support Storybook 9 and @storybook/react-vite.
- Simplified dark mode handling and removed legacy dark mode utilities.
Chores
- Upgraded Storybook and related packages to version 9.
- Updated ESLint and Storybook dependencies for improved compatibility and performance.
- Cleaned up and standardized story metadata with explicit title properties.

…ify and autofix unused dependencies in `createGeneratorTask` definitions.

vercel · 2025-07-14T11:54:10Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
baseplate-project-builder-web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 14, 2025 11:55am

changeset-bot · 2025-07-14T11:54:11Z

🦋 Changeset detected

Latest commit: ce550ef

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2025-07-14T11:54:14Z

Walkthrough

This update introduces a new ESLint rule, no-unused-generator-dependencies, to detect and autofix unused dependencies in createGeneratorTask definitions. The rule is integrated into the TypeScript ESLint config for generator files. Additionally, Storybook dependencies and configurations are upgraded to version 9, with related code and configuration files refactored accordingly.

Changes

File(s) / Group	Change Summary
`.changeset/add-no-unused-generator-dependencies-rule.md`	Documents the addition of the new ESLint rule `no-unused-generator-dependencies`.
`packages/tools/eslint-configs/rules/no-unused-generator-dependencies.js`	Adds a new ESLint rule to detect and autofix unused dependencies in `createGeneratorTask` definitions.
`packages/tools/eslint-configs/typescript.js`	Integrates the new rule into the TypeScript ESLint config for generator files.
`packages/react-generators/src/generators/apollo/apollo-sentry/...`	Removes an unused dependency from the `apolloSentryGenerator`.
`packages/tools/package.json`	Upgrades `eslint-plugin-storybook` from `0.12.0` to `9.0.16`.
`packages/tools/eslint-configs/storybook.js`	Updates Storybook ESLint plugin import and config for compatibility with Storybook 9.
`packages/ui-components/package.json`	Upgrades Storybook packages to version 9, removes deprecated/unused addons, updates dependencies accordingly.
`packages/ui-components/.storybook/main.ts`, `manager.ts`, `preview.tsx`	Refactors Storybook configuration: updates addons, replaces dark mode handling, unifies theme management.
`packages/ui-components/.storybook/custom-theme.ts`	Updates import path for `ThemeVarsColors` type.
`packages/ui-components/.storybook/dark-mode.ts`	Removes file and exported functions for manual dark mode management.
`packages/ui-components/src/components/*/.stories.tsx`	Changes Storybook type imports to `@storybook/react-vite`, adds/updates `title` properties in meta objects.
`packages/ui-components/src/stories/form.stories.tsx`, `typography.stories.tsx`	Updates Storybook type imports to `@storybook/react-vite`.
`packages/ui-components/src/stories/typography.mdx`	Changes Storybook docs block imports to `@storybook/addon-docs/blocks`.

Sequence Diagram(s)

sequenceDiagram
    participant ESLint
    participant RuleModule as no-unused-generator-dependencies.js
    participant SourceFile

    ESLint->>RuleModule: Analyze SourceFile
    RuleModule->>SourceFile: Find createGeneratorTask calls
    RuleModule->>SourceFile: Extract dependencies and run parameter destructuring
    RuleModule->>RuleModule: Compare destructured params vs dependencies
    alt Unused dependency found
        RuleModule-->>SourceFile: Report unused dependency (with autofix)
    end

Possibly related PRs

halfdomelabs/baseplate#588: Adds the same ESLint rule no-unused-generator-dependencies and removes an unused dependency from apollo-sentry.generator.ts, indicating direct code-level relation.

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 2

🔭 Outside diff range comments (2)

packages/ui-components/src/stories/typography.stories.tsx (1)
59-62: Specify the StoryObj generic to preserve strong typings

Without the generic argument, StoryObj falls back to any, losing prop/type safety in the story.
-export const Headings: StoryObj = {
+export const Headings: StoryObj<typeof meta> = {
   name: 'Typography',
   render: () => <Typography />,
 };
packages/ui-components/src/stories/form.stories.tsx (1)
44-48: Use the concrete FormData type throughout to improve type-safety

Type the callback parameter.

Pass FormData to useForm so control/handleSubmit stay strongly typed.
-function Form({
-  onSubmit: onSubmitProp,
-}: {
-  onSubmit?: (data: unknown) => void;
-}): React.JSX.Element {
+function Form({
+  onSubmit: onSubmitProp,
+}: {
+  onSubmit?: (data: FormData) => void;
+}): React.JSX.Element {
@@
-} = useForm({
+} = useForm<FormData>({
   resolver: zodResolver(schema),
   defaultValues,
 });
Also applies to: 64-67

🧹 Nitpick comments (2)

packages/ui-components/src/components/form-action-bar/form-action-bar.stories.tsx (1)

12-13: Add title prop—great; consider stricter naming

components/FormActionBar matches the folder; fine.
If you later nest stories, prefer kebab-case segment (components/form-action-bar) to stay consistent with file-name guideline.

packages/ui-components/src/components/calendar/calendar.stories.tsx (1)

9-10: title added – ensure consistent casing

Consider aligning with kebab-case (components/calendar) like other titles to avoid Storybook sidebar duplicates.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 25f1d83 and ce550ef.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (62)

.changeset/add-no-unused-generator-dependencies-rule.md (1 hunks)
packages/react-generators/src/generators/apollo/apollo-sentry/apollo-sentry.generator.ts (0 hunks)
packages/tools/eslint-configs/rules/no-unused-generator-dependencies.js (1 hunks)
packages/tools/eslint-configs/storybook.js (2 hunks)
packages/tools/eslint-configs/typescript.js (2 hunks)
packages/tools/package.json (1 hunks)
packages/ui-components/.storybook/custom-theme.ts (1 hunks)
packages/ui-components/.storybook/dark-mode.ts (0 hunks)
packages/ui-components/.storybook/main.ts (1 hunks)
packages/ui-components/.storybook/manager.ts (1 hunks)
packages/ui-components/.storybook/preview.tsx (2 hunks)
packages/ui-components/package.json (2 hunks)
packages/ui-components/src/components/alert/alert.stories.tsx (2 hunks)
packages/ui-components/src/components/badge/badge-with-icon.stories.tsx (1 hunks)
packages/ui-components/src/components/badge/badge.stories.tsx (1 hunks)
packages/ui-components/src/components/breadcrumb/breadcrumb.stories.tsx (2 hunks)
packages/ui-components/src/components/button-group/button-group.stories.tsx (1 hunks)
packages/ui-components/src/components/button/button.stories.tsx (1 hunks)
packages/ui-components/src/components/calendar/calendar.stories.tsx (1 hunks)
packages/ui-components/src/components/card/card.stories.tsx (2 hunks)
packages/ui-components/src/components/checkbox-field/checkbox-field.stories.tsx (1 hunks)
packages/ui-components/src/components/circular-progress/circular-progress.stories.tsx (1 hunks)
packages/ui-components/src/components/color-picker/color-picker.stories.tsx (1 hunks)
packages/ui-components/src/components/combobox-field/combobox-field.stories.tsx (1 hunks)
packages/ui-components/src/components/combobox/combobox.stories.tsx (2 hunks)
packages/ui-components/src/components/confirm-dialog/confirm-dialog.stories.tsx (1 hunks)
packages/ui-components/src/components/date-picker-field/date-picker-field.stories.tsx (2 hunks)
packages/ui-components/src/components/date-time-picker-field/date-time-picker-field.stories.tsx (2 hunks)
packages/ui-components/src/components/dialog/dialog.stories.tsx (2 hunks)
packages/ui-components/src/components/dropdown/dropdown.stories.tsx (2 hunks)
packages/ui-components/src/components/empty-display/empty-display.stories.tsx (1 hunks)
packages/ui-components/src/components/error-display/error-display.stories.tsx (1 hunks)
packages/ui-components/src/components/errorable-loader/errorable-loader.stories.tsx (1 hunks)
packages/ui-components/src/components/form-action-bar/form-action-bar.stories.tsx (2 hunks)
packages/ui-components/src/components/input-field/input-field.stories.tsx (1 hunks)
packages/ui-components/src/components/input/input.stories.tsx (1 hunks)
packages/ui-components/src/components/label/label.stories.tsx (1 hunks)
packages/ui-components/src/components/loader/loader.stories.tsx (1 hunks)
packages/ui-components/src/components/multi-combobox-field/multi-combobox-field.stories.tsx (1 hunks)
packages/ui-components/src/components/multi-combobox/multi-combobox.stories.tsx (2 hunks)
packages/ui-components/src/components/navigation-menu/navigation-menu.stories.tsx (2 hunks)
packages/ui-components/src/components/navigation-tabs/navigation-tabs.stories.tsx (1 hunks)
packages/ui-components/src/components/popover/popover.stories.tsx (1 hunks)
packages/ui-components/src/components/record-view/record-view.stories.tsx (2 hunks)
packages/ui-components/src/components/scroll-area/scroll-area.stories.tsx (1 hunks)
packages/ui-components/src/components/section-list/section-list.stories.tsx (2 hunks)
packages/ui-components/src/components/select-field/select-field.stories.tsx (1 hunks)
packages/ui-components/src/components/select/select.stories.tsx (2 hunks)
packages/ui-components/src/components/separator/separator.stories.tsx (1 hunks)
packages/ui-components/src/components/sheet/sheet.stories.tsx (2 hunks)
packages/ui-components/src/components/sidebar-layout/sidebar-layout.stories.tsx (2 hunks)
packages/ui-components/src/components/switch-field/switch-field.stories.tsx (1 hunks)
packages/ui-components/src/components/switch/switch.stories.tsx (1 hunks)
packages/ui-components/src/components/table/table.stories.tsx (2 hunks)
packages/ui-components/src/components/tabs/tabs.stories.tsx (1 hunks)
packages/ui-components/src/components/textarea-field/textarea-field.stories.tsx (1 hunks)
packages/ui-components/src/components/textarea/textarea.stories.tsx (1 hunks)
packages/ui-components/src/components/toaster/toaster.stories.tsx (2 hunks)
packages/ui-components/src/components/tooltip/tooltip.stories.tsx (2 hunks)
packages/ui-components/src/stories/form.stories.tsx (1 hunks)
packages/ui-components/src/stories/typography.mdx (1 hunks)
packages/ui-components/src/stories/typography.stories.tsx (1 hunks)

💤 Files with no reviewable changes (2)

packages/ui-components/.storybook/dark-mode.ts
packages/react-generators/src/generators/apollo/apollo-sentry/apollo-sentry.generator.ts

🧰 Additional context used

📓 Path-based instructions (5)

**/*.{ts,tsx}

Instructions used from: