-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Refactor auth plugin into base + implementation plugins #622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Refactor auth plugin into base + implementation plugins #622
Conversation
…ase-implementation-plugins
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 20b753f The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Caution Review failedThe pull request is closed. WalkthroughThis change implements a comprehensive refactor of the authentication plugin system. It splits the original monolithic auth plugin into a managed plugin architecture, introduces new metadata and configuration schemas, migrates plugin identifiers from "id" to "key", updates plugin discovery to use Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant WebUI as Project Builder Web UI
participant PluginMgr as Plugin Manager (Base Auth Plugin)
participant ImplPlugin as Implementation Plugin (e.g., local-auth, auth0)
participant Config as Config Store
User->>WebUI: Open Plugins Page
WebUI->>PluginMgr: List available plugins
PluginMgr->>ImplPlugin: Discover managed plugins via managedBy
PluginMgr->>WebUI: Group and display main and managed plugins
User->>WebUI: Click "Configure" on managed plugin
WebUI->>PluginMgr: Redirect to manager's config page
User->>WebUI: Select implementation provider in base auth config
WebUI->>PluginMgr: Update implementationPluginKey in config
PluginMgr->>Config: Save configuration
PluginMgr->>ImplPlugin: Enable selected implementation, disable others
User->>WebUI: Edit implementation plugin settings
WebUI->>ImplPlugin: Show provider-specific config UI
ImplPlugin->>Config: Save provider config
Estimated code review effort🎯 5 (Critical) | ⏱️ ~90 minutes Possibly related PRs
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Summary by CodeRabbit
New Features
Bug Fixes
Refactor
Chores