-
Notifications
You must be signed in to change notification settings - Fork 0
fix: Export PgBossQueue class #647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Export PgBossQueue class #647
Conversation
🦋 Changeset detectedLatest commit: ad06128 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughExports PgBossQueue from two service files and adds a changeset entry for a patch release of @baseplate-dev/plugin-queue. No behavior or control-flow changes; only visibility/export and release metadata updates. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
examples/blog-with-auth/packages/backend/baseplate/generated/src/services/pg-boss.service.tsis excluded by!**/generated/**,!**/generated/**
📒 Files selected for processing (3)
.changeset/true-times-roll.md(1 hunks)examples/blog-with-auth/packages/backend/src/services/pg-boss.service.ts(1 hunks)plugins/plugin-queue/src/pg-boss/core/generators/pg-boss/templates/src/services/pg-boss.service.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (6)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/code-style.mdc)
**/*.{ts,tsx}: TypeScript with strict type checking
Always include return types on top-level functions including React components (React.ReactElement)
Include absolute paths in import statements via tsconfig paths (@src/is the alias forsrc/)
If a particular interface or type is not exported, change the file so it is exportedIf a particular interface or type is not exported, update the TypeScript file so it is exported
Files:
examples/blog-with-auth/packages/backend/src/services/pg-boss.service.tsplugins/plugin-queue/src/pg-boss/core/generators/pg-boss/templates/src/services/pg-boss.service.ts
**/*.{js,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/code-style.mdc)
Node 16 module resolution - include file extensions in imports (
.js)
Files:
examples/blog-with-auth/packages/backend/src/services/pg-boss.service.tsplugins/plugin-queue/src/pg-boss/core/generators/pg-boss/templates/src/services/pg-boss.service.ts
**/*.{ts,tsx,js}
📄 CodeRabbit inference engine (.cursor/rules/code-style.mdc)
**/*.{ts,tsx,js}: Sort imports by group: external libs first, then local imports
Use camelCase for variables/functions, PascalCase for types/classes
Order functions such that functions are placed below the variables/functions they use
We use the prefer using nullish coalescing operator (??) ESLint rule instead of a logical or (||), as it is a safer operator
Use console.info/warn/error instead of console.log
Files:
examples/blog-with-auth/packages/backend/src/services/pg-boss.service.tsplugins/plugin-queue/src/pg-boss/core/generators/pg-boss/templates/src/services/pg-boss.service.ts
**/*
📄 CodeRabbit inference engine (.cursor/rules/code-style.mdc)
Use kebab-case for file names
Files:
examples/blog-with-auth/packages/backend/src/services/pg-boss.service.tsplugins/plugin-queue/src/pg-boss/core/generators/pg-boss/templates/src/services/pg-boss.service.ts
examples/blog-with-auth/packages/**/src/**/*.{ts,tsx}
📄 CodeRabbit inference engine (examples/blog-with-auth/CLAUDE.md)
examples/blog-with-auth/packages/**/src/**/*.{ts,tsx}: Always use .js extensions in import statements (even when importing from TypeScript files)
Useimport typefor type-only imports
Always specify explicit return types for all functions
Add JSDoc to all exported functions, interfaces, and classes (document parameters, return values, and fields)
Files:
examples/blog-with-auth/packages/backend/src/services/pg-boss.service.ts
.changeset/*.md
📄 CodeRabbit inference engine (CLAUDE.md)
When adding or changing a feature, add a Changeset in
.changeset/with frontmatter using'package-name': patchand a description
Files:
.changeset/true-times-roll.md
🧠 Learnings (1)
📚 Learning: 2025-09-03T17:01:46.369Z
Learnt from: CR
PR: halfdomelabs/baseplate#0
File: CLAUDE.md:0-0
Timestamp: 2025-09-03T17:01:46.369Z
Learning: Applies to .changeset/*.md : When adding or changing a feature, add a Changeset in `.changeset/` with frontmatter using `'package-name': patch` and a description
Applied to files:
.changeset/true-times-roll.md
🧬 Code graph analysis (2)
examples/blog-with-auth/packages/backend/src/services/pg-boss.service.ts (2)
plugins/plugin-queue/src/pg-boss/core/generators/pg-boss/templates/src/services/pg-boss.service.ts (1)
PgBossQueue(166-291)plugins/plugin-queue/src/queue/core/generators/queues/templates/src/types/queue.types.ts (1)
Queue(8-28)
plugins/plugin-queue/src/pg-boss/core/generators/pg-boss/templates/src/services/pg-boss.service.ts (2)
examples/blog-with-auth/packages/backend/src/services/pg-boss.service.ts (1)
PgBossQueue(165-290)plugins/plugin-queue/src/queue/core/generators/queues/templates/src/types/queue.types.ts (1)
Queue(8-28)
🪛 LanguageTool
.changeset/true-times-roll.md
[grammar] ~5-~5: Ensure spelling is correct
Context: ... patch --- Small tweaks to fix pg boss impelementation
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Lint
- GitHub Check: Test E2E
- GitHub Check: test
🔇 Additional comments (3)
.changeset/true-times-roll.md (1)
1-3: Changeset frontmatter looks correct.Package name and patch bump are properly declared.
plugins/plugin-queue/src/pg-boss/core/generators/pg-boss/templates/src/services/pg-boss.service.ts (1)
166-166: Export added for PgBossQueue — LGTM.This aligns the template with the intended public API.
examples/blog-with-auth/packages/backend/src/services/pg-boss.service.ts (1)
165-165: Export added for PgBossQueue — LGTM.Makes the class available to consumers within the example app.
| '@baseplate-dev/plugin-queue': patch | ||
| --- | ||
|
|
||
| Small tweaks to fix pg boss impelementation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix typo and clarify description.
Spelling: “impelementation” → “implementation”. Consider explicitly stating the export change.
Apply this diff:
-Small tweaks to fix pg boss impelementation
+Export PgBossQueue class to make it publicly available (pg-boss implementation).📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| Small tweaks to fix pg boss impelementation | |
| Export PgBossQueue class to make it publicly available (pg-boss implementation). |
🧰 Tools
🪛 LanguageTool
[grammar] ~5-~5: Ensure spelling is correct
Context: ... patch --- Small tweaks to fix pg boss impelementation
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
🤖 Prompt for AI Agents
In .changeset/true-times-roll.md around line 5, fix the typo "impelementation"
to "implementation" and update the changelog sentence to explicitly state the
export change (e.g., mention which symbol or module export changed or was
added/removed). Ensure the line reads clearly and concisely, correcting spelling
and adding a short phrase like "and clarify export of <name>" or "now exports
<name>" to make the export change explicit.
Summary by CodeRabbit