feat: Move Docker Compose generation from backend to root package #690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move Redis setting to Infrastructure tab
🦋 Changeset detectedLatest commit: dd66a50 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Caution Review failedThe pull request is closed. WalkthroughMigrates Docker Compose generation from backend packages to the monorepo root and centralizes Redis enablement into new infrastructure settings; adds schema migration and tests, updates compilers and example projects, adds infrastructure UI route, and threads ignore-pattern support through sync metadata operations. Changes
Sequence Diagram(s)sequenceDiagram
participant Old as Old Config Flow
participant New as New Config Flow
rect rgba(220,240,255,0.6)
note over Old,New: Config read
Old->>Old: backend.app.enableRedis
New->>New: settings.infrastructure.redis.enabled
end
rect rgba(255,235,205,0.6)
note over Old,New: Build/Compile
Old->>Old: BackendCompiler checks app.enableRedis
New->>New: BackendCompiler asks isRedisEnabled()
end
rect rgba(205,255,220,0.6)
note over Old,New: Generation target
Old->>Old: Generates Redis in backend package/docker
New->>New: Generates Redis in root docker/ when enabled
end
rect rgba(240,220,240,0.6)
note over New: Migration
New->>New: migration-020 moves field and removes per-app flag
end
sequenceDiagram
participant Compiler as Project Compiler
participant Root as Root Compiler
participant Backend as Backend Compiler
participant Infra as Infrastructure Utils
participant Fastify as Fastify Builder
Compiler->>Root: build root package
Root->>Infra: getPostgresSettings(projectDef)
Root->>Infra: isRedisEnabled(projectDef) -> if true getRedisSettings()
Root->>Root: include docker-compose generator with returned settings
Compiler->>Backend: build backend package
Backend->>Fastify: build fastify service
Fastify->>Infra: isRedisEnabled(projectDef)?
alt enabled
Fastify->>Infra: getRedisSettings() -> use returned URL in generator
else disabled
Fastify->>Fastify: omit Redis feature
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes
Possibly related PRs
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Disabled knowledge base sources:
⛔ Files ignored due to path filters (26)
📒 Files selected for processing (51)
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
kingston
deleted the
kingston/eng-912-move-docker-compose-file-to-root-instead-of-backend
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Documentation
Refactor
Bug Fixes