Skip to content

Conversation

@kingston
Copy link
Collaborator

@kingston kingston commented Nov 25, 2025

Summary by CodeRabbit

  • Chores
    • Upgraded AWS SDK storage dependencies to version 3.934.0, improving compatibility and access to latest SDK enhancements across storage operations.

✏️ Tip: You can customize this high-level summary in your review settings.

@vercel
Copy link

vercel bot commented Nov 25, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
baseplate-project-builder-web Error Error Nov 25, 2025 8:22pm

@changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2025

🦋 Changeset detected

Latest commit: 027a649

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@baseplate-dev/plugin-storage Patch
@baseplate-dev/project-builder-common Patch
@baseplate-dev/project-builder-cli Patch
@baseplate-dev/project-builder-test Patch
@baseplate-dev/create-project Patch
@baseplate-dev/code-morph Patch
@baseplate-dev/core-generators Patch
@baseplate-dev/fastify-generators Patch
@baseplate-dev/project-builder-lib Patch
@baseplate-dev/project-builder-server Patch
@baseplate-dev/project-builder-web Patch
@baseplate-dev/react-generators Patch
@baseplate-dev/sync Patch
@baseplate-dev/tools Patch
@baseplate-dev/ui-components Patch
@baseplate-dev/utils Patch
@baseplate-dev/plugin-auth Patch
@baseplate-dev/plugin-queue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link

coderabbitai bot commented Nov 25, 2025

Walkthrough

This pull request upgrades AWS SDK dependencies from version 3.370.0 to 3.934.0 across the plugin-storage configuration and an example project. A changeset entry documents the patch release for @baseplate-dev/plugin-storage.

Changes

Cohort / File(s) Summary
Changeset Documentation
\.changeset/spotty-sloths-grow\.md
Added changeset entry documenting patch release for @baseplate-dev/plugin-storage with AWS SDK upgrade note
Example Project Dependencies
examples/todo-with-auth0/apps/backend/package\.json
Updated four AWS SDK package versions from 3.370.0 to 3.934.0: @aws-sdk/client-s3, @aws-sdk/lib-storage, @aws-sdk/s3-presigned-post, @aws-sdk/s3-request-presigner
Plugin Storage Constants
plugins/plugin-storage/src/constants/storage-packages\.ts
Updated STORAGE_PACKAGES exported constant to map four AWS SDK packages to version 3.934.0 instead of 3.370.0

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

  • All changes consist of consistent version string replacements with no logic modifications
  • Pattern is identical across all affected files and entries
  • Quick verification needed to ensure version consistency across files

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'feat: Upgrade AWS SDK to 3.934.0' is directly related to the main change in the changeset, which updates AWS SDK dependencies from 3.370.0 to 3.934.0 across multiple packages.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch kingston/eng-918-upgrade-aws-lib-storage

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 11fa86f and 027a649.

⛔ Files ignored due to path filters (4)
  • examples/blog-with-auth/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
  • examples/todo-with-auth0/apps/backend/baseplate/generated/package.json is excluded by !**/generated/**, !**/generated/**
  • examples/todo-with-auth0/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
  • tests/simple/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml, !tests/**
📒 Files selected for processing (3)
  • .changeset/spotty-sloths-grow.md (1 hunks)
  • examples/todo-with-auth0/apps/backend/package.json (1 hunks)
  • plugins/plugin-storage/src/constants/storage-packages.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (4)
.changeset/*.md

📄 CodeRabbit inference engine (AGENTS.md)

Add a new Changeset in the '.changeset/' directory with format '---\npackage-name: patch\n---\nDescription of the feature or change' for new features or changes

Files:

  • .changeset/spotty-sloths-grow.md
**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/code-style.mdc)

**/*.{ts,tsx}: Use TypeScript with strict type checking enabled
Always include return types on top-level functions including React components (React.ReactElement)
Include absolute paths in import statements via tsconfig paths (@src/ is the alias for src/)
If a particular interface or type is not exported, change the file so it is exported
If caught on a typing loop where forcing the any type is necessary, do not iterate too much - leave the typing as broken and let the user fix it

If target code is not easily testable, refactor it to be more testable (e.g., export types or functions)

Export interfaces and types that are not currently exported by modifying the file to export them

Files:

  • plugins/plugin-storage/src/constants/storage-packages.ts
**/*.{ts,tsx,js}

📄 CodeRabbit inference engine (.cursor/rules/code-style.mdc)

**/*.{ts,tsx,js}: Node 16 module resolution - include file extensions in imports (.js)
Sort imports by group: external libs first, then local imports
Use camelCase for variables/functions, PascalCase for types/classes
Order functions such that functions are placed below the variables/functions they use
Prefer using nullish coalescing operator (??) instead of logical or (||), enforced via ESLint rule
Prefer barrel exports e.g. export * from './foo.js' instead of individual named exports
Use console.info/warn/error instead of console.log

Files:

  • plugins/plugin-storage/src/constants/storage-packages.ts
**/*.{tsx,ts,jsx,js}

📄 CodeRabbit inference engine (AGENTS.md)

Import UI components from '@baseplate-dev/ui-components' package (e.g., Button, Input, Card, Dialog, etc.)

Files:

  • plugins/plugin-storage/src/constants/storage-packages.ts
🧠 Learnings (1)
📚 Learning: 2025-05-08T12:56:11.723Z
Learnt from: kingston
Repo: halfdomelabs/baseplate PR: 539
File: scripts/check-changesets.ts:70-79
Timestamp: 2025-05-08T12:56:11.723Z
Learning: In the check-changesets.ts script for monorepo validation, `npm pack ${pkg.name}latest` is intentionally used to pack the most recently published version (not local changes) for comparison purposes to determine if changes require new changesets.

Applied to files:

  • plugins/plugin-storage/src/constants/storage-packages.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Lint Examples (blog-with-auth)
  • GitHub Check: Lint Examples (todo-with-auth0)
  • GitHub Check: Test E2E
  • GitHub Check: test
  • GitHub Check: Lint
🔇 Additional comments (3)
.changeset/spotty-sloths-grow.md (1)

1-5: Changeset format and scope look good

Front‑matter matches the expected package: patch format and the description clearly reflects the AWS SDK upgrade affecting @baseplate-dev/plugin-storage.

examples/todo-with-auth0/apps/backend/package.json (1)

34-37: AWS S3 SDK dependency bump is consistent

All four S3‑related AWS SDK packages are upgraded together to "3.934.0", which keeps this example’s dependencies internally consistent and aligned with the storage plugin constants in this PR.

Please confirm CI/tests against the upgraded AWS SDK versions (and check AWS release notes if needed) to ensure there are no behavioral changes impacting this example backend.

plugins/plugin-storage/src/constants/storage-packages.ts (1)

2-5: STORAGE_PACKAGES AWS SDK versions updated consistently

The four AWS SDK S3‑related entries are all bumped to '3.934.0', matching the example backend dependencies and preserving internal consistency of the storage plugin’s package map.

Please double‑check that any peerDependency/optionalDependency declarations and downstream projects using these packages are kept in sync with 3.934.0 and pass their tests with this version.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​aws-sdk/​lib-storage@​3.370.0 ⏵ 3.934.099 +110085 +498 +1100
Updated@​aws-sdk/​s3-presigned-post@​3.370.0 ⏵ 3.934.099 +110010098 +1100
Updated@​aws-sdk/​s3-request-presigner@​3.370.0 ⏵ 3.934.0100 +1100100 +298 +1100
Updated@​aws-sdk/​client-s3@​3.370.0 ⏵ 3.934.098 +110010098 +1100

View full report

@kingston kingston merged commit e8e1377 into main Nov 25, 2025
16 of 17 checks passed
@kingston kingston deleted the kingston/eng-918-upgrade-aws-lib-storage branch November 25, 2025 21:06
@github-actions github-actions bot mentioned this pull request Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants