Skip to content

Conversation

@kingston
Copy link
Collaborator

@kingston kingston commented Dec 23, 2025

Summary by CodeRabbit

  • New Features
    • Sidebar navigation now supports aria-current="page" attribute for improved accessibility compliance and standards adherence.
    • Navigation links updated with exact path matching to ensure accurate active state indication across admin interfaces.

✏️ Tip: You can customize this high-level summary in your review settings.

@vercel
Copy link

vercel bot commented Dec 23, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
baseplate-project-builder-web Ready Ready Preview, Comment Dec 23, 2025 11:03am

@changeset-bot
Copy link

changeset-bot bot commented Dec 23, 2025

🦋 Changeset detected

Latest commit: 4c3c774

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@baseplate-dev/react-generators Patch
@baseplate-dev/project-builder-server Patch
@baseplate-dev/plugin-auth Patch
@baseplate-dev/plugin-storage Patch
@baseplate-dev/project-builder-cli Patch
@baseplate-dev/project-builder-common Patch
@baseplate-dev/project-builder-test Patch
@baseplate-dev/project-builder-web Patch
@baseplate-dev/create-project Patch
@baseplate-dev/code-morph Patch
@baseplate-dev/core-generators Patch
@baseplate-dev/fastify-generators Patch
@baseplate-dev/project-builder-lib Patch
@baseplate-dev/sync Patch
@baseplate-dev/tools Patch
@baseplate-dev/ui-components Patch
@baseplate-dev/utils Patch
@baseplate-dev/plugin-queue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link

coderabbitai bot commented Dec 23, 2025

Warning

Rate limit exceeded

@kingston has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 13 minutes and 29 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 372af99 and 4c3c774.

⛔ Files ignored due to path filters (2)
  • examples/todo-with-auth0/apps/backend/baseplate/generated/package.json is excluded by !**/generated/**, !**/generated/**
  • examples/todo-with-auth0/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (3)
  • examples/todo-with-auth0/apps/backend/package.json
  • packages/fastify-generators/src/constants/fastify-packages.ts
  • packages/fastify-generators/src/generators/core/fastify-redis/fastify-redis.generator.ts

Walkthrough

The changes add support for the HTML5 aria-current="page" attribute as an active state indicator on sidebar menu button components across multiple packages and examples, complementing existing data-active="true" handling. Admin sidebar Home links are updated to use exact path matching, and the React generators package is extended to support optional activeOptions configuration in admin layout link items.

Changes

Cohort / File(s) Summary
Changeset documentation
.changeset/sidebar-aria-current-page.md
Documents a patch for @baseplate-dev/react-generators adding aria-current="page" support for sidebar menu button active state.
Admin sidebar Home link exact path matching
examples/blog-with-auth/apps/admin/src/components/layouts/app-sidebar.tsx, examples/todo-with-auth0/apps/admin/src/components/layouts/app-sidebar.tsx, packages/project-builder-server/src/compiler/web/web-compiler.ts
Adds activeOptions={{ exact: true }} to Home admin links to enforce exact path matching on the Link component.
Sidebar UI aria-current support
examples/blog-with-auth/apps/admin/src/components/ui/sidebar.tsx, examples/todo-with-auth0/apps/admin/src/components/ui/sidebar.tsx, examples/todo-with-auth0/apps/web/src/components/ui/sidebar.tsx, packages/react-generators/src/generators/core/react-components/templates/components/ui/sidebar.tsx
Extends sidebar button, menu action, badge, and sub-button components to include aria-[current=page] styling variants alongside existing data-active="true" rules for active-state presentation.
React generators admin layout
packages/react-generators/src/generators/admin/admin-layout/admin-layout.generator.ts
Adds optional activeOptions field (with exact?: boolean) to admin layout link items schema and injects it into generated Link components.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 5.26% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and specifically describes the main change: adding aria-current=page support to the sidebar menu button component for active state styling.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kingston kingston merged commit ae2aba1 into main Dec 23, 2025
15 checks passed
@kingston kingston deleted the kingston/eng-932-show-active-state-on-sidebar-navigation branch December 23, 2025 11:49
@github-actions github-actions bot mentioned this pull request Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants