Skip to content

check access token existence #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 7, 2019
Merged

check access token existence #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2059d3a
check access token existence
halnique Jun 7, 2019
45bcdaf
fix test
halnique Jun 7, 2019
fea3764
fix comparison
halnique Jun 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/WebAPI/Endpoints/WithAuthenticate.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ public function token(): string
{
$token = getenv('SLACK_API_ACCESS_TOKEN');

if (!$token) {
if ($token === false) {
throw new \RuntimeException('Require Slack Api Access Token to set env: SLACK_API_ACCESS_TOKEN');
}

return $token;
}
}
}
2 changes: 1 addition & 1 deletion tests/WebAPI/Endpoints/WithAuthenticateTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public function testToken()
*/
public function testTokenException()
{
putenv('SLACK_API_ACCESS_TOKEN=');
putenv('SLACK_API_ACCESS_TOKEN');
/** @var WithAuthenticate $withAuthenticate */
$withAuthenticate = $this->getMockForTrait(WithAuthenticate::class);
$this->expectException(\RuntimeException::class);
Expand Down