Skip to content

fix: cannot be published successfully after post or single page unpublished #2762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
f2c-ci-robot merged 2 commits into from
Nov 24, 2022
Merged

fix: cannot be published successfully after post or single page unpublished #2762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3b9d81
fix: cannot be published successfully after post or single page unpub…
guqing Nov 24, 2022
de6d0f8
Merge branch 'main' into refactor/post-publsih-after-cancel
JohnNiang Nov 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/main/java/run/halo/app/core/extension/reconciler/PostReconciler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,10 @@ private void publishPost(String name) {
if (StringUtils.isBlank(releaseSnapshot)) {
return;
}
// do nothing if release snapshot is not changed
if (StringUtils.equals(lastReleasedSnapshot, releaseSnapshot)) {

// do nothing if release snapshot is not changed and post is published
if (post.isPublished()
&& StringUtils.equals(lastReleasedSnapshot, releaseSnapshot)) {
return;
}
Post.PostStatus status = post.getStatusOrDefault();
Expand Down
5 changes: 3 additions & 2 deletions src/main/java/run/halo/app/core/extension/reconciler/SinglePageReconciler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,9 @@ private void publishPage(String name) {
if (StringUtils.isBlank(releaseSnapshot)) {
return;
}
// do nothing if release snapshot is not changed
if (StringUtils.equals(lastReleasedSnapshot, releaseSnapshot)) {
// do nothing if release snapshot is not changed and page is published
if (page.isPublished()
&& StringUtils.equals(lastReleasedSnapshot, releaseSnapshot)) {
return;
}
SinglePage.SinglePageStatus status = page.getStatusOrDefault();
Expand Down