Skip to content

Set docker image name properly when releasing #2872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JohnNiang merged 1 commit into from
Dec 7, 2022
Merged

Set docker image name properly when releasing #2872

JohnNiang merged 1 commit into from
Dec 7, 2022

Conversation

@JohnNiang
Copy link
Member

@JohnNiang JohnNiang commented Dec 7, 2022

What type of PR is this?

/kind improvement
/area core

What this PR does / why we need it:

Set docker image name to halo instead of halo-dev when releasing.

Special notes for your reviewer:

Please refer to a real test at https://github.com/JohnNiang/halo/actions/runs/3636780100/jobs/6137100454

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/improvement Categorizes issue or PR as related to a improvement. area/core Issues or PRs related to the Halo Core labels Dec 7, 2022
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and lan-yonghui December 7, 2022 07:41
ruibaby
ruibaby reviewed Dec 7, 2022
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2022
guqing
guqing reviewed Dec 7, 2022
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2022
@JohnNiang
Copy link
Member Author

JohnNiang commented Dec 7, 2022

/cherry-pick release-2.0

@halo-dev-bot
Copy link
Collaborator

halo-dev-bot commented Dec 7, 2022

@JohnNiang: once the present PR merges, I will cherry-pick it on top of release-2.0 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JohnNiang JohnNiang merged commit cd5cc74 into halo-dev:main Dec 7, 2022
@halo-dev-bot halo-dev-bot mentioned this pull request Dec 7, 2022
Merged
@halo-dev-bot
Copy link
Collaborator

halo-dev-bot commented Dec 7, 2022

@JohnNiang: new pull request created: #2873

Details

In response to this:

/cherry-pick release-2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request Dec 7, 2022
@halo-dev-bot
[release-2.0] Set docker image name properly when releasing (#2873)
dcf2d38 
This is an automated cherry-pick of #2872

/assign JohnNiang

```release-note
None
```
@JohnNiang JohnNiang deleted the chore/calculate-image-name branch March 15, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruibaby ruibaby ruibaby left review comments

@guqing guqing guqing left review comments

@lan-yonghui lan-yonghui Awaiting requested review from lan-yonghui

Assignees

@guqing guqing

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JohnNiang @halo-dev-bot @ruibaby @guqing