Skip to content

Avoid NPE problems when querying the list of posts in the console #3068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
f2c-ci-robot merged 2 commits into from
Dec 29, 2022
Merged

Avoid NPE problems when querying the list of posts in the console #3068

f2c-ci-robot merged 2 commits into from
Dec 29, 2022

Conversation

@guqing
Copy link
Member

@guqing guqing commented Dec 29, 2022 •
edited by JohnNiang
Loading

What type of PR is this?

/kind improvement
/area core
/milestone 2.1.x

What this PR does / why we need it:

迁移后文章过多，当文章的 Reconciler 还没有执行完时访问 Console 端文章列表会因为 post.status 为 Null 出现 NPE 问题
使用文章的 status 时需要对其进行判空

/cherry-pick release-2.0

Which issue(s) this PR fixes:

Fixes #3066

Special notes for your reviewer:

/cc @halo-dev/sig-halo

Does this PR introduce a user-facing change?

修复查询文章列表可能出现的空指针异常

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/improvement Categorizes issue or PR as related to a improvement. labels Dec 29, 2022
@f2c-ci-robot f2c-ci-robot bot added this to the 2.1.x milestone Dec 29, 2022
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Dec 29, 2022
ruibaby
ruibaby reviewed Dec 29, 2022
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 29, 2022
@ruibaby
Copy link
Member

ruibaby commented Dec 29, 2022

/cherry-pick release-2.0

@halo-dev-bot
Copy link
Collaborator

halo-dev-bot commented Dec 29, 2022

@ruibaby: once the present PR merges, I will cherry-pick it on top of release-2.0 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JohnNiang JohnNiang changed the title refactor: avoid NPE problems when reconciler does not finish after migration Avoid NPE problems when querying the list of posts in the console Dec 29, 2022
JohnNiang
JohnNiang approved these changes Dec 29, 2022
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 29, 2022
@f2c-ci-robot f2c-ci-robot bot merged commit 5dbd5a0 into halo-dev:main Dec 29, 2022
@halo-dev-bot halo-dev-bot mentioned this pull request Dec 29, 2022
Merged
@halo-dev-bot
Copy link
Collaborator

halo-dev-bot commented Dec 29, 2022

@ruibaby: new pull request created: #3075

Details

In response to this:

/cherry-pick release-2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ruibaby ruibaby mentioned this pull request Dec 29, 2022
Closed
@ruibaby ruibaby modified the milestones: 2.1.x, 2.1.0 Dec 29, 2022
f2c-ci-robot bot pushed a commit that referenced this pull request Dec 29, 2022
@halo-dev-bot
[release-2.0] Avoid NPE problems when querying the list of posts in t…
c4d435e 
…he console (#3075)

This is an automated cherry-pick of #3068

/assign ruibaby

```release-note
None
```
@guqing guqing deleted the refactor/3066 branch December 29, 2022 10:08
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruibaby ruibaby ruibaby left review comments

@JohnNiang JohnNiang JohnNiang approved these changes

Assignees

@ruibaby ruibaby

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

2.1.0

Development

Successfully merging this pull request may close these issues.

1.5.4迁移2.0.2失败

4 participants

@guqing @ruibaby @halo-dev-bot @JohnNiang