Skip to content

Conversation

@JohnNiang
Copy link
Member

What type of PR is this?

/kind bug
/area core
/milestone 2.2.x

What this PR does / why we need it:

Make requires field of Theme not required.

Which issue(s) this PR fixes:

Fixes #3177

Special notes for your reviewer:

  1. Clear Halo working directory
  2. Start Halo freshly

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels Jan 31, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.2.x milestone Jan 31, 2023
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Jan 31, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from lan-yonghui and ruibaby January 31, 2023 08:45
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2023
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jan 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 0c18fb3 into halo-dev:main Jan 31, 2023
@ruibaby ruibaby modified the milestones: 2.2.x, 2.2.0 Jan 31, 2023
@JohnNiang JohnNiang deleted the bug/default-theme-not-initialized branch March 15, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

在无旧版halo2-dev时,访问主题侧报错

3 participants