-
Notifications
You must be signed in to change notification settings - Fork 4
Adding Ipopt callbacks to DTO (previously implemented in QC) #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@BBhattacharyya1729 does this capture the full spirit of your local callbacks reimplementation? |
be21514 to
7f01474
Compare
|
@jack-champagne Let me know if you like the "take 2" factory pattern better (I included usage examples below; waiting to add my tests once we decide which way to go with this); it seems a bit more flexible wrt writing new callbacks/composing existing callbacks. I had initially written the individual callbacks ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor changes! looking good to me
…e tests to QuantumCollocation rather than here
… incorporation into unit tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fantastic! let's get this merged. @gennadiryan bump the project toml version number first before you merge.
Fixes harmoniqs/QuantumCollocation.jl#157 (broken following deprecation of QuantumCollocationCore); other PR will build on this to serialize optimizer state as well.