Skip to content

[Bug/Feature]: PiccoloOptions will not propagate to min time #202

@andgoldschmidt

Description

@andgoldschmidt

Feature Description

The current options will not propagate from problem to problem.

For example, a problem created with a PiccoloOptions(timesteps_all_equal=false), when passed to a minimum time problem, will use the default options. If that is PiccoloOptions(timesteps_all_equal=true), we get a bug: only the final timestep will be minimized.

A few solutions:

  • Store and share options
  • Print used options at problem construction (this likely means options need to be separate from trajectory initialization, to make sure the code does this with the apply_piccolo_options! call.
  • Make sure the minimum time objective always uses every time point, separately.

The safest way forward might be the last two options. The middle will require refactoring how initialization accesses and uses some kwargs. The last option might change how minimum time behaves by putting independent pressure on the points, but I don't think this is a bad thing!

Importance

1 (lowest)

What does this feature affect?

  • quantum system construction
  • problem setup
  • problem solution
  • problem performance
  • solution analysis
  • plotting
  • documentation
  • tests
  • other (please specify below)

Other information

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions