-
Notifications
You must be signed in to change notification settings - Fork 15
Feature: Ipopt callbacks #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
7f9c195
feat: add boilerplate and inner function call
jack-champagne 7f35b40
add callbacks tests
jack-champagne f25a057
add tmp callback changes
jack-champagne 1a0e8fb
Merge branch 'main' into feature/ipopt-callbacks
jack-champagne f88cde8
add docstrings
jack-champagne 81cbad7
add generic callback factory
jack-champagne 6b4a6cc
Merge commit '18d52526351f71093d7bca9b111779ac00e77bb4' into feature/…
andgoldschmidt 6428fa6
add get best iterate to callbacks lib
jack-champagne 70d5fa1
fix renamed callback
jack-champagne 972aea9
move callback tests, rename callbacks
andgoldschmidt 587c051
Merge branch 'feature/ipopt-callbacks' of github.com:kestrelquantum/Q…
andgoldschmidt bc406f3
local project toml changes
jack-champagne d267338
remove pulse animation pngs
jack-champagne ddb9f0e
add NamedTrajectories to docs compat
jack-champagne e5e64c6
fix typo NM version
jack-champagne 1701f19
roll back callback fidelity
andgoldschmidt e8dabda
Merge branch 'feature/ipopt-callbacks' of github.com:kestrelquantum/Q…
andgoldschmidt 0ecef44
rm manifest
jack-champagne 1c4d641
test unitary fid callback
andgoldschmidt f712b40
fix doctests
jack-champagne e4f7cbc
fixup docs
jack-champagne a1586aa
callbacks version bump
jack-champagne File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,117 @@ | ||
| """ | ||
| Testing callback features | ||
|
|
||
| - callback gives early stopping | ||
| - callback gives trajectory data | ||
| - callback example test with full argument list | ||
| """ | ||
|
|
||
| @testitem "Callback returns false early stops" begin | ||
| using MathOptInterface | ||
| const MOI = MathOptInterface | ||
|
|
||
| T = 50 | ||
| Δt = 0.2 | ||
| sys = QuantumSystem(0.1 * GATES[:Z], [GATES[:X], GATES[:Y]]) | ||
| ψ_init = [1.0, 0.0] | ||
| ψ_target = [0.0, 1.0] | ||
|
|
||
| # Single initial and target states | ||
| # -------------------------------- | ||
| prob = QuantumStateSmoothPulseProblem( | ||
| sys, ψ_init, ψ_target, T, Δt; | ||
| ipopt_options=IpoptOptions(print_level=1), | ||
| piccolo_options=PiccoloOptions(verbose=false) | ||
| ) | ||
|
|
||
| my_callback = (kwargs...) -> false | ||
|
|
||
| initial = fidelity(prob) | ||
| solve!(prob, max_iter=20, callback=my_callback) | ||
| final = fidelity(prob) | ||
|
|
||
| # callback forces problem to exit early as per Ipopt documentation | ||
| @test MOI.get(prob.optimizer, MOI.TerminationStatus()) == MOI.INTERRUPTED | ||
| @test initial ≈ final atol=1e-2 | ||
| end | ||
|
|
||
|
|
||
| @testitem "Callback can get internal history" begin | ||
| using MathOptInterface | ||
| using NamedTrajectories | ||
| const MOI = MathOptInterface | ||
|
|
||
| T = 50 | ||
| Δt = 0.2 | ||
| sys = QuantumSystem(0.1 * GATES[:Z], [GATES[:X], GATES[:Y]]) | ||
| ψ_init = [1.0, 0.0] | ||
| ψ_target = [0.0, 1.0] | ||
|
|
||
| # Single initial and target states | ||
| # -------------------------------- | ||
| prob = QuantumStateSmoothPulseProblem( | ||
| sys, ψ_init, ψ_target, T, Δt; | ||
| ipopt_options=IpoptOptions(print_level=1), | ||
| piccolo_options=PiccoloOptions(verbose=false) | ||
| ) | ||
|
|
||
| trajectory_history = NamedTrajectory[] | ||
| function get_history_callback( | ||
| kwargs... | ||
| ) | ||
| x_vals = map(x -> MOI.get(prob.optimizer, MOI.CallbackVariablePrimal(prob.optimizer), x), prob.variables) | ||
| push!(trajectory_history, NamedTrajectory(x_vals, prob.trajectory)) | ||
| return true | ||
| end | ||
|
|
||
| initial = fidelity(prob) | ||
| solve!(prob, max_iter=20, callback=get_history_callback) | ||
|
|
||
| # for (iter, traj) in enumerate(trajectory_history) | ||
| # plot("./iteration-$iter-trajectory.png", traj, [:ψ̃1, :a]) | ||
| # end | ||
| @test length(trajectory_history) == 21 | ||
| end | ||
|
|
||
| @testitem "Callback with full parameter test" begin | ||
| using MathOptInterface | ||
| using NamedTrajectories | ||
| const MOI = MathOptInterface | ||
|
|
||
| T = 50 | ||
| Δt = 0.2 | ||
| sys = QuantumSystem(0.1 * GATES[:Z], [GATES[:X], GATES[:Y]]) | ||
| ψ_init = [1.0, 0.0] | ||
| ψ_target = [0.0, 1.0] | ||
|
|
||
| # Single initial and target states | ||
| # -------------------------------- | ||
| prob = QuantumStateSmoothPulseProblem( | ||
| sys, ψ_init, ψ_target, T, Δt; | ||
| ipopt_options=IpoptOptions(print_level=1), | ||
| piccolo_options=PiccoloOptions(verbose=false) | ||
| ) | ||
|
|
||
| obj_vals = [] | ||
| function get_history_callback( | ||
| alg_mod::Cint, | ||
| iter_count::Cint, | ||
| obj_value::Float64, | ||
| inf_pr::Float64, | ||
| inf_du::Float64, | ||
| mu::Float64, | ||
| d_norm::Float64, | ||
| regularization_size::Float64, | ||
| alpha_du::Float64, | ||
| alpha_pr::Float64, | ||
| ls_trials::Cint, | ||
| ) | ||
| push!(obj_vals, obj_value) | ||
| return iter_count < 3 | ||
| end | ||
|
|
||
| solve!(prob, max_iter=20, callback=get_history_callback) | ||
|
|
||
| @test MOI.get(prob.optimizer, MOI.TerminationStatus()) == MOI.INTERRUPTED | ||
| @test length(obj_vals) == 4 # problem init, iter 1, iter 2, iter 3 (terminate) | ||
| end |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.