core peeloff #173
Merged
core peeloff #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…core-functionality-into-quantumcollocationcorejl-package
…d clean up function parameters
…ial and goal states
…meter and streamline integrator modifications
9 tasks
jack-champagne
requested changes
Jan 10, 2025
Member
jack-champagne
left a comment
jack-champagne
left a comment
There was a problem hiding this comment.
Looking great, left a few questions/comments on the review to remind myself/act as future reference (+ decision making). Didn't get to pull down to my machine and test this out myself but we have those merge conflicts to sort out tomorrow as well before this is done! @aarontrowbridge
…-quantumcollocationcorejl-package
…system return values
… in quantum state sampling problems
jack-champagne
requested changes
Jan 15, 2025
Member
There was a problem hiding this comment.
Conversations resolved, just waiting on harmoniqs/QuantumCollocationCore.jl#9 to be merged and tagged for this to work
jack-champagne
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
peeled off core solving code into
QuantumCollocationCore.jl