Skip to content

Conversation

@martin-klacan
Copy link
Contributor

This PR fixes issue #204

Added tests to files:
transmons.jl
trajectory_initialization.jl

Hopefully achieved test coverage above 80%.
Made necessary changes to make all tests work

@martin-klacan
Copy link
Contributor Author

Hi aarontrowbridge, does this PR bring the test coverage above 80%? And could I potentially start working on bringing it above 95% for another bounty?

@andgoldschmidt
Copy link
Member

@jack-champagne I'm seeing a missing head commit at https://app.codecov.io/gh/harmoniqs/QuantumCollocation.jl/pull/205 when trying to check the status

@martin-klacan
Copy link
Contributor Author

@jack-champagne I'm seeing a missing head commit at https://app.codecov.io/gh/harmoniqs/QuantumCollocation.jl/pull/205 when trying to check the status

@andgoldschmidt is there anything I can do to fix the missing head commit?

@codecov
Copy link

codecov bot commented Jun 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@andgoldschmidt
Copy link
Member

Ok we did fix the codecov issues, looks like we're at 79.57% 🙃

I guess it does round up! One of us will look closer and see if we have any feedback on this before we go ahead and accept.

@martin-klacan
Copy link
Contributor Author

Oh wow :D Thanks for the round up! Let me know if any changes are necessary!

@martin-klacan
Copy link
Contributor Author

@andgoldschmidt are we able to close this issue and issue #203 by tomorrow? Because 11.6. is the deadline for UnitaryHack bounties

@martin-klacan
Copy link
Contributor Author

Thanks for the review @andgoldschmidt ! I have addressed all your comments in my last commit. One issue I encountered was the lift_operator function, I was not able to import it in any way, it doesn't seem to be in a module. So I copied it to transmons.jl as a temporary fix. I hope this would be a quick-fix for you and we'd be able to close this issue by midnight CDT :)

Copy link
Member

@andgoldschmidt andgoldschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be able to import lift_operator then good to go

@martin-klacan
Copy link
Contributor Author

the lift_opertor is used in the function TransmonDipoleCoupling, not a test. I added 'using PiccoloQuantumObjects' at the top of the file, but I get error with all of these options:
a_i = lift_operator(...
a_i = PiccoloQuantumObjects.lift_operator(...
a_i = PiccoloQuantumObjects.QuantumSystems.lift_operator(...
Am I missing something?

Copy link
Member

@andgoldschmidt andgoldschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving in the TODO from PiccoloQuantumObjects, this is good to go

@andgoldschmidt andgoldschmidt merged commit 8c618b0 into harmoniqs:main Jun 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants