Repository navigation
fix(groq): add default model name + clarify unvalidated manual entry warning - #1014
Merged
Merged
Conversation
…y warning - llm.py: add fallback model_name 'llama-3.3-70b-versatile' for groq provider, consistent with other providers (g4f, gemini, mimo, aihubmix) that set defaults in _generate_response rather than relying only on WebUI - webui/Main.py: clarify caption when model list fails to load — explicitly note that manually entered model names are not validated until generation, so users understand a wrong name will fail at request time Fixes harry0703#1013
Contributor
Author
|
Thanks for the quick review and merge, |
helloquocbao
pushed a commit
to helloquocbao/MoneyPrinterTurbo
that referenced
this pull request
Jun 21, 2026
…y warning (harry0703#1014) - llm.py: add fallback model_name 'llama-3.3-70b-versatile' for groq provider, consistent with other providers (g4f, gemini, mimo, aihubmix) that set defaults in _generate_response rather than relying only on WebUI - webui/Main.py: clarify caption when model list fails to load — explicitly note that manually entered model names are not validated until generation, so users understand a wrong name will fail at request time Fixes harry0703#1013 Co-authored-by: kapilvus <kapilvus@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1013
Changes
app/services/llm.pymodel_name = "llama-3.3-70b-versatile"whengroq_model_nameis not set in config — consistent with how other providers handle missing model names (g4f,gemini,mimo,aihubmixall set defaults here rather than relying solely on the WebUI default)webui/Main.pyWhy
When
get_groq_model_ids()fails (network issue, outage, bad API key), the UI falls back to a text input. The previous caption said "you can still enter a model name manually" but didn't warn that the name would go unvalidated. Combined with@st.cache_data(ttl=300), a user could spend 5 minutes trying a wrong model name before realising the issue.The
llm.pydefault also helps users who configure Groq viaconfig.tomldirectly without the WebUI — they get a working default instead of a validation error if they forget to setgroq_model_name.