Repository navigation
fix: handle empty Qwen choices - #994
Merged
Merged
Conversation
Owner
|
Thank you for the focused contribution. I reviewed the patch and verified it locally with: uv run --with pytest pytest test/services/test_llm.py -k qwen -q
# 4 passed
uv run --with pytest pytest test/services/test_llm.py -q
# 45 passed, 1 skippedThe change is small and targeted: Qwen responses with an explicit empty Merged into |
Contributor
|
Thanks for reviewing and addressing this so quickly. Glad the finding was useful and resulted in a fix. Really appreciate the discussion and contribution from everyone involved. 🙌 This issue was originally surfaced during analysis with VeriQA, so it's encouraging to see the feedback loop work in a real open-source project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #984
Testing