Skip to content

PHP considers somthing numeric which is not in JavaScript #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hasbridge merged 1 commit into from
Jan 9, 2015
Merged

PHP considers somthing numeric which is not in JavaScript #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Check if an entity is a string when validating it against integer, nu… 
…mber and boolean

is_numeric(), is_int() and is_bool() are not sufficient when checking the data type of an entity. E.g. "2" is not numerical in javascript but in PHP it is.
  • Loading branch information
@slopjong
slopjong committed Feb 18, 2013
commit 6ac4207956ca12c880de49b42018ec9f5cb89d3a
8 changes: 4 additions & 4 deletions src/Json/Validator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,19 +218,19 @@ protected function validateType($entity, $schema, $entityName)
}
break;
case 'integer':
if (is_int($entity)) {
if (!is_string($entity) && is_int($entity)) {
$this->checkTypeInteger($entity, $schema, $entityName);
$valid = true;
}
break;
case 'number':
if (is_numeric($entity)) {
if (!is_string($entity) && is_numeric($entity)) {
$this->checkTypeNumber($entity, $schema, $entityName);
$valid = true;
}
break;
case 'boolean':
if (is_bool($entity)) {
if (!is_string($entity) && is_bool($entity)) {
$this->checkTypeBoolean($entity, $schema, $entityName);
$valid = true;
}
Expand Down Expand Up @@ -756,4 +756,4 @@ protected function checkDivisibleBy($entity, $schema, $entityName)

return $this;
}
}
}