Skip to content

Fixed the checkMinimum and checkMaximum to accept zero properly #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hasbridge merged 1 commit into from
Jan 9, 2015
Merged

Fixed the checkMinimum and checkMaximum to accept zero properly #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fixed the checkMinimum and checkMaximum to accept zero properly
  • Loading branch information
@czhang-ck
czhang-ck committed Sep 24, 2014
commit f89fb203576c79d2f7d1a30e848c6cc471eb50bd
4 changes: 2 additions & 2 deletions src/Json/Validator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ protected function checkTypeAny($entity, $schema, $entityName)
*/
protected function checkMinimum($entity, $schema, $entityName)
{
if (isset($schema->minimum) && $schema->minimum) {
if (isset($schema->minimum)) {
if ($entity < $schema->minimum) {
throw new ValidationException(sprintf('Invalid value for [%s], minimum is [%s]', $entityName, $schema->minimum));
}
Expand All @@ -439,7 +439,7 @@ protected function checkMinimum($entity, $schema, $entityName)
*/
protected function checkMaximum($entity, $schema, $entityName)
{
if (isset($schema->maximum) && $schema->maximum) {
if (isset($schema->maximum)) {
if ($entity > $schema->maximum) {
throw new ValidationException(sprintf('Invalid value for [%s], maximum is [%s]', $entityName, $schema->maximum));
}
Expand Down