This repository was archived by the owner on Jan 25, 2023. It is now read-only.
Fixes issue #148 by adding python3 support to sign_request.py #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bastianb
force-pushed
the
fix_issue_148_python3_support_for_sign_request_script
branch
from
784f79a to
fc0ccde
Compare
bastianb
force-pushed
the
fix_issue_148_python3_support_for_sign_request_script
branch
from
fc0ccde to
84f82e7
Compare
yorinasub17
reviewed
Jun 10, 2021
Comment on lines
+25
to
37
| def decode_bytes_from_dict_values(dict_, to_go_style=False): | ||
| retval = {} | ||
| for k, v in headers.iteritems(): | ||
| retval[k] = [v] | ||
| for k, v in dict_.items(): | ||
| try: | ||
| value = v.decode() | ||
| except AttributeError: | ||
| value = v | ||
|
|
||
| if to_go_style: | ||
| value = [value] | ||
|
|
||
| retval[k] = value | ||
| return retval |
Contributor
There was a problem hiding this comment.
I think using a single function for these two purposes is confusing. I would probably convert these function calls to inline dict comprehensions (which are 2 and 3 compatible) that do the things we want for each case.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to fix #148
Adds supports for python3 to sign_request.py