Skip to content
This repository was archived by the owner on Jan 25, 2023. It is now read-only.

Feature/launch template #97

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Feature/launch template #97

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ef23524
First pass at using launch_template as an alternative to launch_confi…
jcejohnson Aug 24, 2018
72aee03
WIP experiment but failed due to: https://github.com/terraform-provid…
efx-jjohnson Aug 24, 2018
0ee25b9
Set the cluster name tag (etc) after cluster_extra_tags (etc) so that…
efx-jjohnson Aug 28, 2018
055132e
It's not pretty but it works. Though I think we should wait for https…
efx-jjohnson Aug 28, 2018
af10a1f
Working launch_template without any hacks.
efx-jjohnson Oct 1, 2018
cbd44e2
Fix default vaule and explain the choices
efx-jjohnson Oct 4, 2018
ed5cebe
Wrong dependency for launch_configuration based autoscaling group
jcejohnson Oct 6, 2018
bb7a7a6
Cleaner approach for setting the cluster_size output value
jcejohnson Oct 6, 2018
234f63b
launch_configuration can also request volume encryption
jcejohnson Oct 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix default vaule and explain the choices
  • Loading branch information
@efx-jjohnson
efx-jjohnson committed Oct 4, 2018
commit cbd44e21a4dba3323f5e51ecd1f52732622ade8f
7 changes: 6 additions & 1 deletion modules/vault-cluster/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,8 +201,13 @@ variable "force_destroy_s3_bucket" {
# Launch Template Extensions

variable "asg_launch_mechanism" {
# Choices are launch_configuration and launch_template.
# launch_template gives you the opportunithy to declare volume encryption and
Copy link
Collaborator

@brikis98 brikis98 Oct 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can enable volume encryption with a launch config too: https://www.terraform.io/docs/providers/aws/r/launch_configuration.html#encrypted

Copy link
Contributor Author

@jcejohnson jcejohnson Oct 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed it can. Comment updated.
(FWIW, that ability isn't currently exposed in this module)

Copy link
Collaborator

@brikis98 brikis98 Oct 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should expose the ability to encrypt EBS volumes in the module for both launch configs and launch templates...

# set tags on instance volumes.
#
description = "Select between launch_config-driven or launch_template-driven autoscaling group."
default = "launch_config"

default = "launch_configuration"
}

variable "launch_template_tags" {
Expand Down