backend/azure: Remove legacy helper/schema dependency #34990
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'm no longer at HashiCorp after today, so I won't be able to work on this any further but I'm going to leave it open to keep it visible in case someone else wants to take over this branch in a new PR. |
apparentlymart
force-pushed
the
nolegacysdk-azure
branch
from
c3e94cc to
03e8946
Compare
jbardin
previously approved these changes
Sep 9, 2024
Member
|
@hashicorp/terraform-azure, could someone with Azure credentials run the acceptance tests for the azure backend to verify the changes? Thanks! |
This now uses the backendbase package's "SDK-like" helpers instead, which provide a much smaller subset of the former legacy SDK functionality but enough for what this backend needs.
jbardin
force-pushed
the
nolegacysdk-azure
branch
from
44c14b5 to
5877d2e
Compare
3 tasks
Member
|
Resolved in #37225 🙌🏻 |
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of our efforts to remove the large snapshot of the legacy SDK that we've been using, this replaces the uses of that package with our new lightweight
backendbasepackage, which is a collection of helpers that can substitute for most of the parts of the legacy SDK that backends tend to use.In the long run we're still planning to move all of the state storage backends out to provider plugins, at which point they'll presumably use the modern plugin framework, but in the meantime the legacy SDK is quite a liability because few people know how to maintain it while hopefully this interim
backendbasepackage is easier to maintain (if needed) due to its relative simplicity.I don't have any test environment for this backend, so I've only tested this through its unit tests. I'd appreciate if a backend maintainer could, along with reviewing this code, also run the acceptance test suite in case there are regressions that the unit tests aren't able to catch. Thanks!