Skip to content

Conversation

@SarahFrench
Copy link
Member

@SarahFrench SarahFrench commented Dec 4, 2025

As part of identifying whether we need to make the validate command compatible with pluggable state storage I added some tests to characterise what the validate command checks for in backend blocks.

It turns out that resources are validated using their schemas, while backend blocks aren't validated using their schemas.

Target Release

N/A

Rollback Plan

  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@SarahFrench SarahFrench added the no-changelog-needed Add this to your PR if the change does not require a changelog entry label Dec 4, 2025
@SarahFrench SarahFrench force-pushed the sarah/investigate-validate-cmd branch from bca1a9e to 83e3ac5 Compare December 4, 2025 20:30
@SarahFrench SarahFrench marked this pull request as ready for review December 5, 2025 11:13
@SarahFrench SarahFrench requested a review from a team as a code owner December 5, 2025 11:13
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there was ever a good reason for not doing any schema-based validation for backends but I think there was probably a lot of caution related to the handling of empty strings and partial configuration.

We can almost certainly afford to be a bit braver with state stores though and try to do the validation there! 😄

@SarahFrench SarahFrench merged commit 3eea12a into main Dec 5, 2025
15 checks passed
@SarahFrench SarahFrench deleted the sarah/investigate-validate-cmd branch December 5, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog-needed Add this to your PR if the change does not require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants