Skip to content

test: Add more test coverage of validate command's interaction with backend blocks #37977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
SarahFrench wants to merge 3 commits into
base: main
Choose a base branch
from
+32 −4
Draft

test: Add more test coverage of validate command's interaction with backend blocks #37977

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22e9b4a
test: Show how the validate command doesn't detect when an unknown ba…
SarahFrench Dec 5, 2025
bb86673
test: Minor fixes to error messages when test fails
SarahFrench Dec 5, 2025
2398fe4
test: Add some TODOs in code comments
SarahFrench Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: Add some TODOs in code comments 
These tests are here to define existing behaviour, not define desired behaviour. I wanted to make that clear!
  • Loading branch information
@SarahFrench
SarahFrench committed Dec 5, 2025
commit 2398fe460e8dae1b8d34524d77d5f9eb1e181b6c
2 changes: 2 additions & 0 deletions internal/command/validate_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,6 +547,7 @@ func TestValidate_backendBlocks(t *testing.T) {
}
})

// TODO: Should this validation be added?
t.Run("NOT invalid when the backend type is unknown", func(t *testing.T) {
output, code := setupTest(t, "invalid-backend-configuration/unknown-backend-type")
if code != 0 {
Expand All @@ -562,6 +563,7 @@ func TestValidate_backendBlocks(t *testing.T) {
})

// Backend blocks aren't validated using their schemas currently.
// TODO: Should this validation be added?
t.Run("NOT invalid when there's an unknown attribute present", func(t *testing.T) {
output, code := setupTest(t, "invalid-backend-configuration/unknown-attr")
if code != 0 {
Expand Down