Skip to content

refactor: Change how we pass backend state around when creating a plan file #37984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SarahFrench wants to merge 14 commits into from
Closed

refactor: Change how we pass backend state around when creating a plan file #37984

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
f03346b
refactor: Rename Meta's backendState field to backendConfigState
SarahFrench Nov 13, 2025
fb35d84
fix: Only set backendConfigState to synthetic object if it's nil due …
SarahFrench Nov 13, 2025
d0f8834
feat: Enable recording a state store's details in an Operation, and u…
SarahFrench Nov 14, 2025
aaffae2
fix: Include provider config when writing a plan file using pluggable…
SarahFrench Nov 25, 2025
59a8f83
fix: Having `backendConfigState` be nil may be valid, but it definite…
SarahFrench Nov 26, 2025
9243396
test: Add integration test showing that a plan command creates a plan…
SarahFrench Nov 26, 2025
e6218a5
refactor: Apply suggestion from @radeksimko
SarahFrench Dec 9, 2025
0b65499
fix: Allow panics to occur if an unexpected implementation of `backen…
SarahFrench Dec 10, 2025
8979828
Merge branch 'main' into pss/state-store-in-plan-file
SarahFrench Dec 10, 2025
a52e51b
docs: Add code comment explaining the current situation with passing …
SarahFrench Dec 10, 2025
8b9be31
refactor: Replace use of in-memory copy of backend configuration stat…
SarahFrench Dec 10, 2025
676b2a6
refactor: Back-track by resuming storing backend state in the Meta, i…
SarahFrench Dec 10, 2025
9ed3dba
fix: Handle scenario where the backend state file exists but is empty.
SarahFrench Dec 10, 2025
4cbed02
refactor: Favour use of `Empty` method over nil checks
SarahFrench Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: Apply suggestion from @radeksimko 
Co-authored-by: Radek Simko <[email protected]>
  • Loading branch information
@SarahFrench @radeksimko
SarahFrench and radeksimko authored Dec 9, 2025
commit e6218a5936fdee9e36aa71edf353b42c96738ac1
4 changes: 2 additions & 2 deletions internal/command/meta_backend.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,8 +223,8 @@ func (m *Meta) Backend(opts *BackendOpts) (backendrun.OperationsBackend, tfdiags
// the user, since the local backend should only be used when learning or
// in exceptional cases and so it's better to help the user learn that
// by introducing it as a concept.
backendInUse := opts.StateStoreConfig == nil
if backendInUse && m.backendConfigState == nil {
stateStoreInUse := opts.StateStoreConfig != nil
if !stateStoreInUse && m.backendConfigState == nil {
// NOTE: This synthetic object is intentionally _not_ retained in the
// on-disk record of the backend configuration, which was already dealt
// with inside backendFromConfig, because we still need that codepath
Expand Down