Use GHC2021#4033
Merged
Merged
Conversation
michaelpj
requested review from
July541,
drsooch,
eddiemundo,
fendor,
georgefst,
joyfulmantis,
kokobd,
konn,
ozkutuk,
pepeiborra,
santiweight,
soulomoon and
wz1000
as code owners
Collaborator
|
I like this idea. |
jhrcek
approved these changes
Feb 2, 2024
jhrcek
left a comment
jhrcek
left a comment
Collaborator
There was a problem hiding this comment.
I like this idea especially in a codebase that's more like an application than like a library.
FYI I resolved merge conflict caused by my PR and pushed to this branch.
Let me know if you find it inappropriate for people to push to other people's branches.
Collaborator
Author
I think it's generally helpful in the case of resolving conflicts (unless you do it wrong :p ). So thanks! |
fendor
approved these changes
Feb 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this looks fairly good, cuts down our extension spam a bit.