Fix misplaced inlay hints by applying PositionMapping#4571
Merged
Conversation
fendor
approved these changes
Apr 25, 2025
fendor
left a comment
fendor
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, didn't check this works correctly now, and I am not sure whether we even could add a test for this that isn't incredibly flaky.
fendor
reviewed
Apr 25, 2025
auto-merge was automatically disabled
April 25, 2025 08:25
Head branch was pushed to by a user without write access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #4561.
fixed
hls-explicit-imports-plugin,hls-explicit-record-fields-plugin.