all: rewrite bfgd and popmd, remove bssd#396
Merged
joshuasing merged 326 commits intomainfrom Jul 16, 2025
Merged
Conversation
github-actions
bot
added
area: bss
AL-CT
added
the
size: XXL
marcopeereboom
force-pushed
the
toni/bfg-rework
branch
from
af2768f to
9783f91
Compare
marcopeereboom
changed the title
Contributor
|
@VolodymyrBg check this out |
github-actions
bot
added
area: bfg
AL-CT
changed the title
This was referenced Apr 22, 2025
joshuasing
added
type: refactor
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
marcopeereboom
requested review from
a team,
ClaytonNorthey92,
joshuasing and
marcopeereboom
as code owners
jcvernaleo
requested changes
Jul 8, 2025
Contributor
jcvernaleo
left a comment
jcvernaleo
left a comment
There was a problem hiding this comment.
Couple minor things.
And a reminder that localnode path must be set back to normal before merged. It is really important that the node running doc be at a stable path.
| localnetPrivateKey = "dfe61681b31b12b04f239bc0692965c61ffc79244ed9736ffa1a72d00a23a530" | ||
| retries = 10 | ||
| btcAddress = "mw47rj9rG25J67G6W8bbjRayRQjWN5ZSEG" | ||
| btcAddress = "mv5gj33YaFviPFDmkkUpb31C4uxoB4ZZ5D" |
Contributor
There was a problem hiding this comment.
Not for this PR, but @ClaytonNorthey92 is there a reason you have this address in a .env file above and hardcoded here? Might be better to only specify once.
Contributor
There was a problem hiding this comment.
@jcvernaleo likely no good reason. we can just use the .env file
1 task
Contributor
|
Pending |
re-added localnode. removed _localnode_fixme. now using releases of hemi daemons to support backwards-compatibility (if we were to "build" the current daemons they would error unless we update all of localnode).
ClaytonNorthey92
approved these changes
Jul 16, 2025
joshuasing
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Now that we have arrived at mainnet it is time to pay off the technical debt we incurred. For all the right reasons, bfg became a dumping ground for functionality our users needed. TBC has caught up and implements the primitives that bfg needs so that it can drastically shrink in scope and functionality.
Changes