Skip to content

ttl: fix typos in comments#434

Merged
AL-CT merged 3 commits intohemilabs:mainfrom
Pricstas:fix/update
Mar 14, 2025
Merged

ttl: fix typos in comments#434
AL-CT merged 3 commits intohemilabs:mainfrom
Pricstas:fix/update

Conversation

@Pricstas
Copy link
Copy Markdown
Contributor

@Pricstas Pricstas commented Mar 11, 2025 •
edited
Loading

  • "callback functions" → "callback function" (singular)
  • "key value pair" → "key-value pair" (hyphenated)
  • "Len return" → "Len returns" (grammar fix)

@Pricstas Pricstas requested a review from a team as a code owner March 11, 2025 14:32
joshuasing
joshuasing requested changes Mar 12, 2025
View reviewed changes
@joshuasing joshuasing changed the title Fix typos and improve comments in TTL implementation ttl: fix typos in comments Mar 12, 2025
AL-CT
AL-CT approved these changes Mar 13, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@AL-CT AL-CT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

joshuasing
joshuasing approved these changes Mar 13, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@joshuasing joshuasing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@AL-CT AL-CT merged commit 944c245 into hemilabs:main Mar 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcopeereboom marcopeereboom marcopeereboom approved these changes

@joshuasing joshuasing joshuasing approved these changes

@AL-CT AL-CT AL-CT approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Pricstas @marcopeereboom @joshuasing @AL-CT