Skip to content

docker: add profiles to compose files#442

Merged
jcvernaleo merged 1 commit intomainfrom
jcv_dockerProfile
Mar 27, 2025
Merged

docker: add profiles to compose files#442
jcvernaleo merged 1 commit intomainfrom
jcv_dockerProfile

Conversation

@jcvernaleo
Copy link
Copy Markdown
Contributor

@jcvernaleo jcvernaleo commented Mar 12, 2025

Summary

Changes

@jcvernaleo jcvernaleo self-assigned this Mar 12, 2025
@jcvernaleo jcvernaleo requested a review from a team as a code owner March 12, 2025 17:49
@jcvernaleo jcvernaleo marked this pull request as draft March 12, 2025 17:49
ClaytonNorthey92
ClaytonNorthey92 reviewed Mar 12, 2025
View reviewed changes
joshuasing
joshuasing approved these changes Mar 18, 2025
View reviewed changes
@jcvernaleo jcvernaleo force-pushed the jcv_dockerProfile branch 2 times, most recently from fd47f9a to 73b6b31 Compare March 26, 2025 20:19
@jcvernaleo jcvernaleo marked this pull request as ready for review March 26, 2025 20:20
joshuasing
joshuasing approved these changes Mar 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@joshuasing joshuasing left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

To keep commit messages consistent (e.g.):

- Add profiles to docker compose
+ docker: add profiles to compose files

@jcvernaleo jcvernaleo changed the title Add profiles to docker compose docker: add profiles to compose files Mar 26, 2025
@jcvernaleo
Copy link
Copy Markdown
Contributor Author

jcvernaleo commented Mar 26, 2025

@joshuasing commit message and title fixed.

@jcvernaleo jcvernaleo merged commit b57b388 into main Mar 27, 2025
10 checks passed
@jcvernaleo jcvernaleo deleted the jcv_dockerProfile branch March 27, 2025 12:19
@joshuasing joshuasing added the type: enhancement This improves existing functionality label Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ClaytonNorthey92 ClaytonNorthey92 ClaytonNorthey92 approved these changes

@joshuasing joshuasing joshuasing approved these changes

@AL-CT AL-CT Awaiting requested review from AL-CT

Assignees

@jcvernaleo jcvernaleo

Labels

type: enhancement This improves existing functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jcvernaleo @ClaytonNorthey92 @joshuasing