popm: don't instantly noop if bfg response channel is busy#450
Merged
ClaytonNorthey92 merged 3 commits intomainfrom Mar 20, 2025
Merged
popm: don't instantly noop if bfg response channel is busy#450ClaytonNorthey92 merged 3 commits intomainfrom
ClaytonNorthey92 merged 3 commits intomainfrom
Conversation
…iner was busy, we would no-op. this happened often because the channel was not buffered. this would happen silently as well. add a timeout to sending messages to the non-buffered channel and log and error if we time out
ClaytonNorthey92
approved these changes
Mar 19, 2025
joshuasing
added
type: refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix #422
Changes
Prior, whenever the channel that would receive bfg responses in pop miner was busy, we would no-op. this happened often because the channel was not buffered. this would happen silently as well. add a timeout to sending messages to the non-buffered channel and log and error if we time out