BFG: save db records in processBitcoinBlock in a single tx#456
Merged
ClaytonNorthey92 merged 1 commit intomainfrom Mar 24, 2025
Merged
BFG: save db records in processBitcoinBlock in a single tx#456ClaytonNorthey92 merged 1 commit intomainfrom
ClaytonNorthey92 merged 1 commit intomainfrom
Conversation
github-actions
bot
added
the
area: bfg
when saving records from processing bitcoin blocks, prior they were not done atomically (in a db tx). this means that if one failed others may succeed. this change makes it all-or-nothing; we either save everything we want from a btc block or we don't, so we don't half-save.
ClaytonNorthey92
force-pushed
the
clayton/save-btc-in-tx
branch
from
0210908 to
ff108c7
Compare
ClaytonNorthey92
changed the title
ClaytonNorthey92
added
size: L
ClaytonNorthey92
requested review from
AL-CT,
jcvernaleo,
joshuasing,
marcopeereboom and
max-sanchez
marcopeereboom
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
when saving records from processing bitcoin blocks, prior they were not done atomically (in a db tx). this means that if one failed others may succeed. this change makes it all-or-nothing; we either save everything we want from a btc block or we don't, so we don't half-save.
Changes
see summary