keep all data needed for btc finality in one table#519
Merged
ClaytonNorthey92 merged 9 commits intomainfrom May 28, 2025
Merged
keep all data needed for btc finality in one table#519ClaytonNorthey92 merged 9 commits intomainfrom
ClaytonNorthey92 merged 9 commits intomainfrom
Conversation
github-actions
bot
added
the
area: bfg
prior, we were calculating finality at request/query-time. this is a relatively-expensive (and complex) calculation. now, store the "lowest btc block height" in the l2_keystones table. this allows us to return finality with no joins at request/query-time. this is all done during bitcoin block processing. our finality lookup for a keystone is, for lack of a better term, now "constant-time" lookup. as the l2_keystone_abrev_hash is indexed (and that's our lookup key).
ClaytonNorthey92
force-pushed
the
clayton/constant-finality-lookup
branch
from
a8ac33a to
b0c64ca
Compare
ClaytonNorthey92
changed the title
ClaytonNorthey92
changed the title
ClaytonNorthey92
requested review from
AL-CT,
jcvernaleo,
marcopeereboom and
max-sanchez
ClaytonNorthey92
removed request for
a team,
AL-CT,
jcvernaleo,
marcopeereboom and
max-sanchez
ClaytonNorthey92
requested review from
AL-CT,
jcvernaleo,
marcopeereboom and
max-sanchez
| log.Tracef("BtcBlockUpdateKeystones") | ||
| defer log.Tracef("BtcBlockUpdateKeystones exit") | ||
|
|
||
| // give me all distinct l2 block numbers mined to this btc block |
Contributor
Author
There was a problem hiding this comment.
"distinct l2 keystone abrev hashes"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prior, we were calculating finality at request/query-time. this is a relatively-expensive (and complex) calculation.
Changes
now, store the "lowest btc block height" in the l2_keystones table. this allows us to return finality with no joins at request/query-time. this is all done during bitcoin block processing.
our finality lookup for a keystone is, for lack of a better term, now "constant-time" lookup. as the l2_keystone_abrev_hash is indexed (and that's our lookup key).