Conversation
marcopeereboom
added
type: feature
joshuasing
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
AL-CT
approved these changes
Jun 17, 2025
ClaytonNorthey92
requested changes
Jun 18, 2025
Contributor
ClaytonNorthey92
left a comment
ClaytonNorthey92
left a comment
There was a problem hiding this comment.
the db upgrade test should be re-written; we're not testing individual error cases as far as I can tell. we should also get rid of that large test file.
I also think that we're silencing possible large issues with a continue.
a few more things that I feel need addressing. I left comments
joshuasing
requested changes
Jun 19, 2025
AL-CT
force-pushed
the
marco_keystoneindex
branch
from
3d1da12 to
b30b827
Compare
This reverts commit 72fdbf6.
--------- Co-authored-by: Joshua Sing <joshua@hemi.xyz> Co-authored-by: ClaytonNorthey92 <clayton.northey@gmail.com>
AL-CT
force-pushed
the
marco_keystoneindex
branch
from
b30b827 to
b7ce764
Compare
ClaytonNorthey92
approved these changes
Jun 25, 2025
joshuasing
approved these changes
Jun 27, 2025
Comment on lines
+371
to
+378
| //if !l.cfg.nonInteractive { | ||
| // log.Infof("This operation will take a long time. " + | ||
| // "Press ctrl-c within 30 seconds to abort upgrade!") | ||
| // select { | ||
| // case <-ctx.Done(): | ||
| // case <-time.Tick(30 * time.Second): | ||
| // } | ||
| //} |
Contributor
There was a problem hiding this comment.
Was this intentionally disabled?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add height hash index to keystone index so that we can have a notion of what the last super duper giga final keystone is.