Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ClaytonNorthey92
approved these changes
Jul 18, 2025
joshuasing
requested changes
Jul 18, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
marcopeereboom
requested changes
Jul 21, 2025
Co-authored-by: Joshua Sing <joshua@hemi.xyz>
joshuasing
approved these changes
Jul 22, 2025
marcopeereboom
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently, fee calculation for pop miners is done by the gozer. However, the only functional gozer is TBC, which requires the mempool to be enabled in order for fee estimation to work. This can be both expensive and potentially unreliable. As such, an option to override fee estimation with a static fee was added.
Changes
Introduce a way to set a static fee for the pop miner.
Changed the wallet transaction creation methods to allow float sats/byte fees.
Changed config.go to be able to parse float values in env vars.