This repository was archived by the owner on Dec 1, 2024. It is now read-only.
use ffp_parse_string instead of shelling out to hh_parse #537
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This yielded a dramatic speedup in HHAST for us, and as far as I can tell is absolutely equivalent.
Since the built-in type of
ParserCacheis opaque, I had toas dict<_, _>it, and to avoid adding FIXMEs I changed the type annotations where it's used to allow arraykey keys.The built-in parser doesn't seem to support old style xhp children declarations, but since those have been deprecated for several years I think it's ok to remove support for them in HHAST and the associated migration, so I've done that as well.