This repository was archived by the owner on Dec 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 43
Ssandler get ci working #538
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e69dc4d
support HHVM 4.168 on ubuntu 20.04, newer versions of ubuntu don't build
09658b6
update codegen/schema
0816b56
update required hhvm version in composer.json
86095e1
remove patch version number
56c45c3
fix the other job
3625755
Revert "Update updating-schema.md (#482)"
7ba2d82
remove update-schema job
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix the other job
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This effectively disables the job and HHAST auto-updating for nightlies - that might be fine (@Wilfred ? ), but if so, it's probably better to remove the job rather than change this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. It's currently broken on nightly, but for different reasons. Some other breaking change upstream causes it to fail https://github.com/hhvm/hhast/actions/runs/3991497523/jobs/6846355294
I don't think we can keep up with getting this to work for nightlies so might be ok to just go back to manual schema updates for the foreseeable future. Could remove or comment out this job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the job and also reverted the docs PR about it back to the old instructions, which I followed to get the codegen working.