Skip to content
This repository was archived by the owner on Dec 1, 2024. It is now read-only.

Random bug fixes #542

Merged
merged 15 commits into from
Oct 31, 2023
Merged

Random bug fixes #542

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
a9cc0ab
Document bug comparison empty statements
lexidor May 24, 2023
d2a9dfc
Fix false negative, `<=` and `>=` in NoEmptyStatementsLinter
lexidor May 24, 2023
14a8fea
Document bug NodeList::getChildrenOfItemsOfType() does not refine
lexidor May 24, 2023
99b1131
Fix type refinement of NodeList::getChildrenOfItemsOfType<T>()
lexidor May 24, 2023
f5d4890
Add NodeList::getChildrenOfItemsByType<T>()
lexidor May 24, 2023
6641652
Remove reference in comment to createMaybeEmptyList
lexidor May 24, 2023
8176da6
Post commit formatting
lexidor May 24, 2023
f2bca6d
Lint clean
lexidor May 24, 2023
e30d8a2
Lint clean (with HHClientLinter)
lexidor May 24, 2023
e5b7014
Post commit formatting
lexidor May 24, 2023
865a9d4
One (last) lint error from HHClientLinter
lexidor May 24, 2023
a693564
Demonstrate the `() ==> constant` can not be parsed
lexidor Jun 6, 2023
f599945
Regenerate codegen, allowing constants as lambda bodies
lexidor Jun 6, 2023
3d6ee36
Limit semaphore to cpu count
lexidor Jun 6, 2023
b65217d
Fix lint error in syntax example
lexidor Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Post commit formatting
  • Loading branch information
@lexidor
lexidor committed May 24, 2023
commit e5b70149e26bcce8cf9a255a38a365da050a0710
9 changes: 3 additions & 6 deletions src/Linters/UseStatementWIthoutKindLinter.hack
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,8 @@ final class UseStatementWithoutKindLinter extends AutoFixingASTLinter {
// We need to look at the full file to figure out if this should be a
// `use type`, or `use namespace`
$used = $this->getUnresolvedReferencedNames();
$used_as_ns = C\any(
$names,
$name ==> C\contains($used['namespaces'], $name),
);
$used_as_ns =
C\any($names, $name ==> C\contains($used['namespaces'], $name));
$used_as_type = C\any($names, $name ==> C\contains($used['types'], $name));

$leading = $node->getClauses()->getFirstTokenx()->getLeadingWhitespace();
Expand All @@ -92,8 +90,7 @@ final class UseStatementWithoutKindLinter extends AutoFixingASTLinter {
}

<<__Memoize>>
private function getUnresolvedReferencedNames(
): shape(
private function getUnresolvedReferencedNames(): shape(
'namespaces' => keyset<string>,
'types' => keyset<string>,
'functions' => keyset<string>,
Expand Down